All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Eric Farman <farman@linux.vnet.ibm.com>,
	borntraeger@de.ibm.com, agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target
Date: Tue, 15 Aug 2017 10:39:23 +0200	[thread overview]
Message-ID: <435fa5db-64a3-57f8-d71c-e88c1a11ab3a@redhat.com> (raw)
In-Reply-To: <20170815103221.2446bc3d.cohuck@redhat.com>

On 15.08.2017 10:32, Cornelia Huck wrote:
> On Tue, 15 Aug 2017 10:26:18 +0200
> Thomas Huth <thuth@redhat.com> wrote:
[...]
>> The parameter -R disables the built-in variables, so RM can indeed not
>> work here. Sorry, I wasn't aware of that setting yet, so your patch is
>> indeed the right fix here (or we should maybe define RM in rules.mak, too).
> 
> The other users are all in tests/tcg/.
> 
> Would there be value in using the built-in variables generally? (Well,
> value that outweighs having to go through the qemu build system...)

There are some non-posix shells where "rm -f" does not work (e.g.
COMMAND.COM on Windows), and this is where $(RM) is really useful. But
since we require a posix-style built environment anyway, it's not that
important for the QEMU build system. OTOH, $(RM) is a standard Make
variable, so other people might step into this trap as well - so it's
maybe better to define it in rules.mak to avoid future confusion?

 Thomas

  reply	other threads:[~2017-08-15  8:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 20:44 [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target Eric Farman
2017-08-14 20:44 ` [Qemu-devel] [PATCH 1/1] pc-bios/s390-ccw: Use rm command during make clean Eric Farman
2017-08-15  7:23   ` Cornelia Huck
2017-08-15  5:02 ` [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target Thomas Huth
2017-08-15  7:03   ` Cornelia Huck
2017-08-15  8:01     ` Thomas Huth
2017-08-15  8:26       ` Thomas Huth
2017-08-15  8:32         ` Cornelia Huck
2017-08-15  8:39           ` Thomas Huth [this message]
2017-08-15 10:27         ` Eric Farman
2017-08-15 10:00 ` Peter Maydell
2017-08-15 11:07   ` Cornelia Huck
2017-08-15 11:10     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=435fa5db-64a3-57f8-d71c-e88c1a11ab3a@redhat.com \
    --to=thuth@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=farman@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.