From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NDGLV-0000AY-8G
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:47:41 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NDGLQ-000085-CY
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:47:40 -0500
Received: from [199.232.76.173] (port=55493 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NDGLP-00007v-Vz
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:47:36 -0500
Received: from cantor.suse.de ([195.135.220.2]:36128 helo=mx1.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1NDGLP-0001aJ-JR
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:47:35 -0500
Subject: Re: [Qemu-devel] [PATCH 06/13] Add support for S390x system emulation
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Alexander Graf <agraf@suse.de>
In-Reply-To: <200911251146.14502.paul@codesourcery.com>
Date: Wed, 25 Nov 2009 12:47:31 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <4364342F-8294-490C-897F-F69F2C6FD9CE@suse.de>
References: <1259083781-14642-1-git-send-email-agraf@suse.de>
	<1259083781-14642-7-git-send-email-agraf@suse.de>
	<200911251146.14502.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>


On 25.11.2009, at 12:46, Paul Brook wrote:

>> --- a/target-s390x/cpu.h
>> +++ b/target-s390x/cpu.h
>> @@ -30,8 +30,7 @@
>>=20
>> #include "softfloat.h"
>>=20
>> -#define NB_MMU_MODES 2 // guess
>> -#define MMU_USER_IDX 0 // guess
>> +#define NB_MMU_MODES 2
>=20
> The fact that you're modifying a file you added earlier in the same =
patch=20
> series gives me very little confidence...

I tried to keep the later patches as close to what they were in previous =
version as possible.
If you like I can merge the changes, but I figured this makes is easier =
for review.


Alex=