All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Björn Stenberg" <bjst@enea.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/2] bitbake: ensure -f causes dependent tasks to be re-run
Date: Wed, 20 Jun 2012 00:50:46 +0100	[thread overview]
Message-ID: <4368013.N53ZsVQnoH@helios> (raw)
In-Reply-To: <20120619193539.GA2530@giant>

On Tuesday 19 June 2012 21:35:39 Björn Stenberg wrote:
> Paul Eggleton wrote:
> > If -f is specified, force dependent tasks to be re-run next time. This
> > works by changing the force behaviour so that instead of deleting the
> > task's stamp, we write a "taint" file into the stamps directory, which
> > will alter the taskhash randomly and thus trigger the task to re-run
> 
> I'm concerned about calling this -f/--force. I don't think I'm alone in
> interpreting -f / --force as "run all commands, even if the dependencies
> say we don't need to".

Well, what it used to do was just cause the specified task to be run even if 
there is a stamp recording that it was already done; dependencies don't come 
into it (although perhaps you meant stamps?)

> I would expect the same output as the first time,
> with the same sstate checksum.

So my assumption is -f is most often used for the purpose of manually forcing 
a recompile after you have made modifications to the already extracted source 
code under the workdir. If that is the case, there are two consequences as I 
see it:

 * When Bitbake next checks whether you want to run dependent tasks, given 
that the output of the task almost certainly changed due to your modifications, 
you would want those dependent tasks to be re-run again also. i.e. if you've 
forced a compile, you would expect for the results to be installed and 
packaged when you next ask for the do_install / do_package tasks to run.

 * You don't really want those modifications going into the sstate package that 
effectively claims to be produced from inputs that only come from the metadata. 
Now, obviously it doesn't physically prevent you from ever getting modified 
data into an sstate package with the same signature, but it makes it less 
likely.

My question would be, are you using -f for something different or do you 
disagree with one or both of the consequences above?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2012-06-20  0:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 15:45 [PATCH 0/2] Signature-based rebuild improvements Paul Eggleton
2012-06-18 15:45 ` [PATCH 1/2] bitbake: ensure -f causes dependent tasks to be re-run Paul Eggleton
2012-06-19 19:35   ` Björn Stenberg
2012-06-19 23:50     ` Paul Eggleton [this message]
2012-06-20  7:45       ` Björn Stenberg
2012-06-20  7:55       ` Björn Stenberg
2012-06-20  8:38         ` Richard Purdie
2012-06-20  8:40         ` Paul Eggleton
2012-06-21 11:25           ` Björn Stenberg
2012-06-21 12:10             ` Paul Eggleton
2012-06-21 12:26               ` Björn Stenberg
2012-06-21 13:25                 ` Paul Eggleton
2012-06-21 13:41                 ` Björn Stenberg
2012-06-21 13:52                   ` Paul Eggleton
2012-06-21 14:44                 ` Richard Purdie
2012-06-18 15:45 ` [PATCH 2/2] bitbake: add -C option to invalidate a task and rebuild the target Paul Eggleton
2012-06-19 11:43 ` [PATCH 0/2] Signature-based rebuild improvements Jason Wessel
2012-06-19 13:02   ` Paul Eggleton
2012-06-19 17:20   ` Gopi - College
2012-06-20 18:11     ` p2020rdb - httpd+php Gopi - College
2012-06-20  8:42   ` [PATCH 0/2] Signature-based rebuild improvements Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4368013.N53ZsVQnoH@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=bjst@enea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.