From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
gwml@vger.gnuweeb.org, x86@kernel.org, stable@vger.kernel.org,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
Jiri Hladky <hladky.jiri@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v4 2/2] x86/mce/amd: Fix memory leak when `threshold_create_bank()` fails
Date: Thu, 3 Mar 2022 06:20:09 +0700 [thread overview]
Message-ID: <4371a592-6686-c535-4daf-993dedb43cd4@gnuweeb.org> (raw)
In-Reply-To: <Yh+oyD/5M3TW5ZMM@yaz-ubuntu>
On 3/3/22 12:26 AM, Yazen Ghannam wrote:
> Hi Ammar,
Hi Yazen,
> ...
> The threshold interrupt handler uses this pointer. I think the goal here is to
> set this pointer when the list is fully formed and clear this pointer before
> making any changes to the list. Otherwise, the interrupt handler will operate
> on incomplete data if an interrupt comes in the middle of these updates.
>
> The changes below should deal with memory leak issue while avoiding a race
> with the threshold interrupt. What do you think?
Thanks for taking a look into this. I didn't notice that before. The
changes look good to me, extra improvements:
1) _mce_threshold_remove_device() should be static as we don't use it
in another translation unit.
2) Minor cleanup, we don't need "goto out_err", just early return
directly.
I will fold them in...
--
Ammar Faizi
next prev parent reply other threads:[~2022-03-02 23:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 9:46 [PATCH v4 0/2] Two x86 fixes Ammar Faizi
2022-03-01 9:46 ` [PATCH v4 1/2] x86/delay: Fix the wrong asm constraint in `delay_loop()` Ammar Faizi
2022-03-01 9:54 ` David Laight
2022-03-03 0:14 ` Ammar Faizi
2022-03-01 11:33 ` Alviro Iskandar Setiawan
2022-03-03 0:06 ` Ammar Faizi
2022-03-03 0:35 ` David Laight
2022-03-01 9:46 ` [PATCH v4 2/2] x86/mce/amd: Fix memory leak when `threshold_create_bank()` fails Ammar Faizi
2022-03-02 17:26 ` Yazen Ghannam
2022-03-02 23:20 ` Ammar Faizi [this message]
2022-03-02 23:27 ` Ammar Faizi
2022-03-03 1:58 ` Alviro Iskandar Setiawan
2022-03-03 2:07 ` Ammar Faizi
2022-03-03 2:32 ` Ammar Faizi
2022-03-03 2:51 ` Alviro Iskandar Setiawan
2022-03-07 0:27 ` Ammar Faizi
2022-03-09 20:55 ` Yazen Ghannam
2022-03-10 1:56 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4371a592-6686-c535-4daf-993dedb43cd4@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwml@vger.gnuweeb.org \
--cc=hladky.jiri@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.