From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 2/4] net/netvsc: add hyper-v netvsc
 network device
Date: Wed, 18 Apr 2018 14:19:52 +0100
Message-ID: <438086f5-76f4-3c72-5c2f-b54577d12af2@intel.com>
References: <20180417215324.8576-1-sthemmin@microsoft.com>
 <20180417215324.8576-3-sthemmin@microsoft.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Stephen Hemminger <sthemmin@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id CA61D8BA7
 for <dev@dpdk.org>; Wed, 18 Apr 2018 15:19:55 +0200 (CEST)
In-Reply-To: <20180417215324.8576-3-sthemmin@microsoft.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/17/2018 10:53 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> 
> The driver supports Hyper-V networking directly like
> virtio for KVM or vmxnet3 for VMware.
> 
> This code is based off of the FreeBSD driver. The file and variable
> names are kept the same to help with understanding (with most of the
> BSD style warts removed).
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  MAINTAINERS                                   |    7 +
>  config/common_base                            |    8 +
>  config/common_linuxapp                        |    2 +-
>  drivers/net/Makefile                          |    1 +
>  drivers/net/netvsc/Makefile                   |   23 +
>  drivers/net/netvsc/hn_ethdev.c                |  760 ++++++++++
>  drivers/net/netvsc/hn_logs.h                  |   35 +
>  drivers/net/netvsc/hn_nvs.c                   |  533 +++++++
>  drivers/net/netvsc/hn_nvs.h                   |  243 ++++
>  drivers/net/netvsc/hn_rndis.c                 | 1101 +++++++++++++++
>  drivers/net/netvsc/hn_rndis.h                 |   26 +
>  drivers/net/netvsc/hn_rxtx.c                  | 1221 +++++++++++++++++
>  drivers/net/netvsc/hn_var.h                   |  140 ++
>  drivers/net/netvsc/ndis.h                     |  378 +++++
>  drivers/net/netvsc/rndis.h                    |  414 ++++++
>  drivers/net/netvsc/rte_pmd_netvsc_version.map |    5 +
>  mk/rte.app.mk                                 |    1 +

Can you please add .ini file (doc/guides/nics/features/*.ini) to document PMD
features?

<...>

> @@ -479,6 +479,13 @@ F: drivers/net/enic/
>  F: doc/guides/nics/enic.rst
>  F: doc/guides/nics/features/enic.ini
>  
> +Hyper-V netvsc
> +M: Stephen Hemminger <sthemmin@microsoft.com>
> +M: K. Y. Srinivasan" <kys@microsoft.com>

Is " a typo?

<...>

> +/* XXX Why is this not generic in RTE? */
> +static int
> +hn_dev_atomic_write_link_status(struct rte_eth_dev *dev,
> +		struct rte_eth_link *link)
> +{

It is indeed generic now thanks to you :)
Can you switch to your generic functions?

<...>

> +/* enables testpmd to collect per queue stats. */
> +static int
> +hn_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *eth_dev,
> +			       __rte_unused uint16_t queue_id,
> +			       __rte_unused uint8_t stat_idx,
> +			       __rte_unused uint8_t is_rx)
> +{
> +	return 0;
> +}

IS this dev_ops needed at all?

<...>

> @@ -0,0 +1,5 @@
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +
> +DPDK_18.02 {

v18.05