From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751579AbdCNM6q (ORCPT ); Tue, 14 Mar 2017 08:58:46 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:40037 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbdCNM6l (ORCPT ); Tue, 14 Mar 2017 08:58:41 -0400 X-AuditID: b6c32a36-f79c56d000001a35-bc-58c7e8fefa7f From: Bartlomiej Zolnierkiewicz To: linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Kukjin Kim , Javier Martinez Canillas , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Date: Tue, 14 Mar 2017 13:58:35 +0100 Message-id: <4386279.iJpUOasmTG@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170311172527.16368-5-krzk@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsWy7bCmru6/F8cjDB59ErSYf+Qcq8Wbt2uY LPofv2a2OH9+A7vFpsfXWC0u75rDZjHj/D4mixvr9rFbPFl4hsmide8RdotbM16wOnB7XNss 5rFpVSebx+Yl9R5b+u+ye+z83sDu8XmTXABbFJdNSmpOZllqkb5dAlfGhFW3WQoOs1Rsub2J pYHxCnMXIyeHhICJxN3919khbDGJC/fWs3UxcnEICexglPh3YT4ThNPOJHFk9164jssLt0FV zWGUWDhrCiuE85VR4uHPk6wgVWwCVhIT21cxgtgiAhoSU7oes4MUMQu8YJJ4vu05UBEHh7BA mMTaPxkgNSwCqhLrnx5lAgnzCmhKXJnHBxIWFfCS2LKvnQnE5hQwlejZ+ABsPK+AoMSPyfdY QGxmAXmJffunskLYOhJnj61jhDj0HLvEwheVICMlBGQlNh1ghjBdJLrmW0NUCEu8Or4F6nlp iVX/bjFB2NMZJbb/lgA5WEJgM6PEqt0ToIqsJQ4fvwi1ik/i3dceVoiZvBIdbUIQJR4Svw62 QJU7Svz89hsaVEBzFh+ewDyBUX4Wkg9mIflgFpIPFjAyr2IUSy0ozk1PLTYsMNIrTswtLs1L 10vOz93ECE4/WmY7GBed8znEKMDBqMTD2zDnWIQQa2JZcWXuIUYJDmYlEd6/z45HCPGmJFZW pRblxxeV5qQWH2KU5mBREudlNZgYISSQnliSmp2aWpBaBJNl4uCUamCc8U404o3poktR8/81 z+gTkH9ecpvnSFPEA8nr6b/vt+xa2LjoR9nUORfXPGLkmRfxI7zjVS3fMd0p85UVvP794w86 +2biLinLSR/fmDk/eRfYmNQScVMv/nB0Wte5xC+3TWvf+TP9kSpsarqnrfS28GXetDVCFuFx Jda2TYeX8jgn32W5xbdaiaU4I9FQi7moOBEAbbSJ2DsDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsVy+t9jQd2/L45HGKy6rGMx/8g5Vos3b9cw WfQ/fs1scf78BnaLTY+vsVpc3jWHzWLG+X1MFjfW7WO3eLLwDJNF694j7Ba3ZrxgdeD2uLZZ zGPTqk42j81L6j229N9l99j5vYHd4/MmuQC2KDebjNTElNQihdS85PyUzLx0W6XQEDddCyWF vMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nbJbhlTFh1m6XgMEvFltubWBoYrzB3MXJy SAiYSFxeuI0NwhaTuHBvPZgtJDCLUeJHd2gXIxeQ/ZVRYsraaawgCTYBK4mJ7asYQWwRAQ2J KV2P2UGKmAVeMUlceLMOrFtYIExiV/c2sAYWAVWJ9U+PMnUxcnDwCmhKXJnHBxIWFfCS2LKv nQnE5hQwlejZ+IAVYnG8xMZl+8HivAKCEj8m32MBsZkF5CX27Z/KCmFrSazfeZxpAiPQlQhl s5CUzUJStoCReRWjRGpBckFxUnquYV5quV5xYm5xaV66XnJ+7iZGcEQ+k9rBeHCX+yFGAQ5G JR7eG/OORQixJpYVV+YeYpTgYFYS4f377HiEEG9KYmVValF+fFFpTmrxIUZToP8mMkuJJucD k0VeSbyhibmJubGBhbmlpYmRkjhv4+xn4UIC6YklqdmpqQWpRTB9TBycUg2MUzrsXlXcNy8y 2HlsgXlT2A+eqINnT1aqGi2Lj7LXKFRqMn1zIWme5V/P2cKWG4W9H6rt3uEQ/fL6o7N/H610 /qAfvPia95dasQWPLVtvpZ89KLwteNZm4Y2fmnZ9PjehYMUZfovHSsp73wVmqQkttHZ6/TNk 0sG47J6vViIPYz18bkje+p0RrMRSnJFoqMVcVJwIANWCbpLeAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170314125837epcas1p481afc11bcf7fc11ef477edda28bccc74 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170314125837epcas1p481afc11bcf7fc11ef477edda28bccc74 X-RootMTR: 20170314125837epcas1p481afc11bcf7fc11ef477edda28bccc74 References: <20170311172527.16368-1-krzk@kernel.org> <20170311172527.16368-5-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: > Watchdog module does not have external dependencies so it can be safely > enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based > boards. > > Signed-off-by: Krzysztof Kozlowski Please first fix the driver w.r.t. infinite interrupt in soft mode issue and only then enable it on more hardware. IOW this patch should be placed after patch #7 in the series. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Date: Tue, 14 Mar 2017 13:58:35 +0100 Message-ID: <4386279.iJpUOasmTG@amdc3058> References: <20170311172527.16368-1-krzk@kernel.org> <20170311172527.16368-5-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: In-reply-to: <20170311172527.16368-5-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Krzysztof Kozlowski , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Kukjin Kim , Javier Martinez Canillas , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: > Watchdog module does not have external dependencies so it can be safely > enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based > boards. > > Signed-off-by: Krzysztof Kozlowski Please first fix the driver w.r.t. infinite interrupt in soft mode issue and only then enable it on more hardware. IOW this patch should be placed after patch #7 in the series. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz) Date: Tue, 14 Mar 2017 13:58:35 +0100 Subject: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards In-Reply-To: <20170311172527.16368-5-krzk@kernel.org> References: <20170311172527.16368-1-krzk@kernel.org> <20170311172527.16368-5-krzk@kernel.org> Message-ID: <4386279.iJpUOasmTG@amdc3058> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote: > Watchdog module does not have external dependencies so it can be safely > enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based > boards. > > Signed-off-by: Krzysztof Kozlowski Please first fix the driver w.r.t. infinite interrupt in soft mode issue and only then enable it on more hardware. IOW this patch should be placed after patch #7 in the series. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics