From mboxrd@z Thu Jan 1 00:00:00 1970 From: "William H. Taber" Subject: Re: [RFC PATCH]autofs4: hang and proposed fix Date: Tue, 29 Nov 2005 11:34:03 -0500 Message-ID: <438C82FB.50706@us.ibm.com> References: <20051116101740.GA9551@RAM> <438B3C34.2050509@us.ibm.com> <1133219572.27824.24.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Badari Pulavarty , Ram Pai , autofs mailing list , linux-fsdevel Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:50356 "EHLO e32.co.us.ibm.com") by vger.kernel.org with ESMTP id S932112AbVK2QeW (ORCPT ); Tue, 29 Nov 2005 11:34:22 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.12.11/8.12.11) with ESMTP id jATGYJqC021507 for ; Tue, 29 Nov 2005 11:34:19 -0500 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VERS6.8) with ESMTP id jATGZjnR024246 for ; Tue, 29 Nov 2005 09:35:46 -0700 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id jATGYGAU013422 for ; Tue, 29 Nov 2005 09:34:17 -0700 To: Ian Kent In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Ian Kent wrote: > We'll need to do an analysis of all callers of the revalidate method. You are right. Searching through the sources, it would appear that I missed fixing autofs and devfs. Everyone else just defines a revalidate routine but doesn't call one. You may find devfs to be interesting because they have code to determine whether they need to release the i_sem lock or not. I am working on an updated patch to include the changes needed for these two modules. Will