From: Vlastimil Babka <vbabka@suse.cz>
To: Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [GIT PULL] tracing: Fixes to bootconfig memory management
Date: Wed, 15 Sep 2021 00:47:59 +0200 [thread overview]
Message-ID: <4392e867-0cce-d04a-e3d1-cba152daaa1f@suse.cz> (raw)
In-Reply-To: <20210914170553.7c1e1faa@oasis.local.home>
On 9/14/21 23:05, Steven Rostedt wrote:
> On Tue, 14 Sep 2021 13:48:15 -0700
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>> On Tue, Sep 14, 2021 at 12:38 PM Linus Torvalds
>> <torvalds@linux-foundation.org> wrote:
>> >
>> > So I'll do a minimal conversion that adds "memblock_free_ptr()" and
>> > hope that people start using that. And then we can later try to move
>> > "memblock_free()" to a name that isn't so misleading.
>>
>> Commit 77e02cf57b6c ("memblock: introduce saner 'memblock_free_ptr()'
>> interface") should hopefully fix that panic that Vlastimil saw, and
>> the kernel test robot report as well.
>>
>> And it should make it easy to cleanly fix that 'copy' leak too.
>>
>
> Vlastimil,
>
> Can you confirm that Linus's changes addresses your issue?
Well, looks like I can't. Commit 77e02cf57b6cf does boot fine for me,
multiple times. But so now does the parent commit 6a4746ba06191. Looks like
the magic is gone. I'm now surprised how deterministic it was during the
bisect (most bad cases manifested on first boot, only few at second).
> Masami,
>
> Care to rebase on top of Linus's change?
>
> Thanks!
>
> -- Steve
>
next prev parent reply other threads:[~2021-09-14 22:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 14:56 [GIT PULL] tracing: Fixes to bootconfig memory management Steven Rostedt
2021-09-14 18:01 ` Linus Torvalds
2021-09-14 18:01 ` Linus Torvalds
2021-09-14 18:59 ` Steven Rostedt
2021-09-14 19:05 ` Linus Torvalds
2021-09-14 19:05 ` Linus Torvalds
2021-09-14 19:14 ` Steven Rostedt
2021-09-14 19:23 ` Linus Torvalds
2021-09-14 19:23 ` Linus Torvalds
2021-09-14 19:38 ` Linus Torvalds
2021-09-14 19:38 ` Linus Torvalds
2021-09-14 20:48 ` Linus Torvalds
2021-09-14 20:48 ` Linus Torvalds
2021-09-14 21:05 ` Steven Rostedt
2021-09-14 22:47 ` Vlastimil Babka [this message]
2021-09-14 23:29 ` Linus Torvalds
2021-09-14 23:29 ` Linus Torvalds
2021-09-15 9:28 ` Vlastimil Babka
2021-09-14 23:44 ` Masami Hiramatsu
2021-09-17 20:10 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4392e867-0cce-d04a-e3d1-cba152daaa1f@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.