All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcus Sundberg <marcus@ingate.com>
To: Harald Welte <laforge@netfilter.org>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] nfsim: Support more netfilter modules
Date: Thu, 12 Jan 2006 11:25:43 +0100	[thread overview]
Message-ID: <43C62EA7.5020001@ingate.com> (raw)
In-Reply-To: <20060106144048.GE4898@sunbeam.de.gnumonks.org>

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

Harald Welte wrote:
> On Tue, Dec 13, 2005 at 02:51:01PM +0100, Marcus Sundberg wrote:
> 
>>this patch adds nfsim support for building most of the netfilter stuff
>>in 2.6.15. The things still not compiling are CONFIG_IP_NF_CONNTRACK_NETLINK
>>and CONFIG_IP_NF_MATCH_STRING
> 
> thanks, applied.

Hi,

the patch contained a bogus msleep() implementation, please accept
the following correction.

//Marcus
-- 
---------------------------------------+--------------------------
   Marcus Sundberg <marcus@ingate.com>  | Firewalls with SIP & NAT
  Software Developer, Ingate Systems AB |  http://www.ingate.com/

[-- Attachment #2: nfsim-2.diff --]
[-- Type: text/x-patch, Size: 468 bytes --]

[NFSIM] Implement msleep() better

There's no point in actually sleeping in the nfsim framework,
just increment time properly.

Signed-off-by: Marcus Sundberg <marcus@ingate.com>


--- nfsim/kernelenv/include/kernelenv.h	(revision 6395)
+++ nfsim/kernelenv/include/kernelenv.h	(working copy)
@@ -1231,7 +1231,7 @@
 
 /* delay.h */
 
-#define msleep(x)	do{unsigned int y = (x)*1000; usleep(y);}while(0)
+#define msleep(x)	increment_time((x)*HZ/1000)
 
 /* timer.h */
 

  reply	other threads:[~2006-01-12 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13 13:51 [PATCH] nfsim: Support more netfilter modules Marcus Sundberg
2005-12-13 18:47 ` Marcus Sundberg
2005-12-15  2:21   ` Patrick McHardy
2005-12-15  1:15 ` Patrick McHardy
2006-01-06 14:40 ` Harald Welte
2006-01-12 10:25   ` Marcus Sundberg [this message]
2006-01-12 11:14     ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43C62EA7.5020001@ingate.com \
    --to=marcus@ingate.com \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.