From: "Saarinen, Jani" <jani.saarinen@intel.com>
To: "Sarvela, Tomi P" <tomi.p.sarvela@intel.com>,
"Srivatsa, Anusha" <anusha.srivatsa@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/i915/huc: Load HuC v03.00.2555 for Geminilake.
Date: Wed, 23 May 2018 08:00:10 +0000 [thread overview]
Message-ID: <43D4F724E12AB6478FC1572B3FBE89D076083A96@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <21d9f46b-375f-d36a-7d5c-ae3b40923050@intel.com>
HI.
> -----Original Message-----
> From: Sarvela, Tomi P
> Sent: keskiviikko 23. toukokuuta 2018 10.53
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Spotswood, John A <john.a.spotswood@intel.com>; Saarinen, Jani
> <jani.saarinen@intel.com>
> Subject: Re: [PATCH 2/3] drm/i915/huc: Load HuC v03.00.2555 for Geminilake.
>
> On 05/23/2018 09:15 AM, Anusha Srivatsa wrote:
> > load the v03.00.2555 huC on geminilake.
> >
> > v2:
> > - rebased.
> > - Load the correct the version. (John Spotswood)
> >
> > Cc: John Spotswood <john.a.spotswood@intel.com>
> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> > Cc: Jani Saarinen <jani.saarinen@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_huc_fw.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c
> > b/drivers/gpu/drm/i915/intel_huc_fw.c
> > index f93d238..ae293f9 100644
> > --- a/drivers/gpu/drm/i915/intel_huc_fw.c
> > +++ b/drivers/gpu/drm/i915/intel_huc_fw.c
> > @@ -34,6 +34,10 @@
> > #define KBL_HUC_FW_MINOR 00
> > #define KBL_BLD_NUM 1810
> >
> > +#define GLK_HUC_FW_MAJOR 03
> > +#define GLK_HUC_FW_MINOR 00
> > +#define GLK_BLD_NUM 2555
>
> Can you check if this should be
>
> #define GLK_BLD_NUM 2225
In patch 0/3 you have
WHENCE | 7 +++++++
i915/glk_guc_ver11_98.bin | Bin 0 -> 154240 bytes
i915/glk_huc_ver03_00_2225.bin | Bin 0 -> 220032 bytes
3 files changed, 7 insertions(+)
create mode 100644 i915/glk_guc_ver11_98.bin create mode 100644 i915/glk_huc_ver03_00_2225.bin
So most probably typo like Tomi says.
>
> This is the newest GLK HuC firmware version I have seen.
>
> Best regards,
>
> Tomi Sarvela
>
> > +
> > #define HUC_FW_PATH(platform, major, minor, bld_num) \
> > "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \
> > __stringify(minor) "_" __stringify(bld_num) ".bin"
> > @@ -50,6 +54,10 @@ MODULE_FIRMWARE(I915_BXT_HUC_UCODE);
> > KBL_HUC_FW_MINOR, KBL_BLD_NUM)
> > MODULE_FIRMWARE(I915_KBL_HUC_UCODE);
> >
> > +#define I915_GLK_HUC_UCODE HUC_FW_PATH(glk, GLK_HUC_FW_MAJOR,
> \
> > + GLK_HUC_FW_MINOR, GLK_BLD_NUM)
> > +MODULE_FIRMWARE(I915_GLK_HUC_UCODE);
> > +
> > static void huc_fw_select(struct intel_uc_fw *huc_fw)
> > {
> > struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw);
> > @@ -76,6 +84,10 @@ static void huc_fw_select(struct intel_uc_fw *huc_fw)
> > huc_fw->path = I915_KBL_HUC_UCODE;
> > huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR;
> > huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR;
> > + } else if (IS_GEMINILAKE(dev_priv)) {
> > + huc_fw->path = I915_GLK_HUC_UCODE;
> > + huc_fw->major_ver_wanted = GLK_HUC_FW_MAJOR;
> > + huc_fw->minor_ver_wanted = GLK_HUC_FW_MINOR;
> > } else {
> > DRM_WARN("%s: No firmware known for this platform!\n",
> > intel_uc_fw_type_repr(huc_fw->type));
> >
>
> --
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-23 8:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 6:15 [PATCH 0/3] Load Guc and huC on Geminilake Anusha Srivatsa
2018-05-23 6:15 ` [PATCH 1/3] drm/i915/guc: Load GuC v11.98 for Geminilake Anusha Srivatsa
2018-05-23 6:15 ` [PATCH 2/3] drm/i915/huc: Load HuC v03.00.2555 " Anusha Srivatsa
2018-05-23 7:53 ` Tomi Sarvela
2018-05-23 8:00 ` Saarinen, Jani [this message]
2018-05-23 6:15 ` [PATCH 3/3] Enable guc loading " Anusha Srivatsa
2018-05-23 6:49 ` ✗ Fi.CI.BAT: failure for Load Guc and huC on Geminilake (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-04-27 23:33 [PATCH 0/3] GuC, HuC Loading Support for Geminilake Anusha Srivatsa
2018-04-27 23:33 ` [PATCH 2/3] drm/i915/huc: Load HuC v03.00.2555 " Anusha Srivatsa
2018-05-17 21:27 ` John Spotswood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43D4F724E12AB6478FC1572B3FBE89D076083A96@IRSMSX106.ger.corp.intel.com \
--to=jani.saarinen@intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.