From: "Rose, Gregory V" <gregory.v.rose@intel.com>
To: Ian Campbell <ijc@hellion.org.uk>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: RE: [net-next 1/8] pci: Add flag indicating device has been assigned by KVM
Date: Fri, 23 Sep 2011 07:41:36 -0700 [thread overview]
Message-ID: <43F901BD926A4E43B106BF17856F0755019C518C0E@orsmsx508.amr.corp.intel.com> (raw)
In-Reply-To: <1316762872.23371.88.camel@zakaz.uk.xensource.com>
> -----Original Message-----
> From: Ian Campbell [mailto:ijc@hellion.org.uk]
> Sent: Friday, September 23, 2011 12:28 AM
> To: Kirsher, Jeffrey T
> Cc: davem@davemloft.net; konrad.wilk@oracle.com; Jesse Barnes; Rose,
> Gregory V; netdev@vger.kernel.org; gospo@redhat.com; linux-
> pci@vger.kernel.org
> Subject: Re: [net-next 1/8] pci: Add flag indicating device has been
> assigned by KVM
>
> On Thu, 2011-09-22 at 21:16 -0700, Jeff Kirsher wrote:
> >
> >
> > Jesse/Konrad/Ian-
> >
> > I sent this patch out as part of a pull request for David Miller's
> > net-next tree. I know that Greg sent this originally out to the
> > linux-pci mailing list as a RFC. Since Greg also has a patch against
> > ixgbe which implemented this flag, I sent both patches for inclusion
> > into David Miller's net-next.
> >
> > Dave is wanting to ensure that the PCI maintainers have reviewed this
> > and are ok with it before pulls my series of patches.
>
> I'm not a PCI maintainer by any stretch of the imagination but FWIW this
> change is fine by me.
>
> My original reason for commenting on this patch was just to wonder
> whether this would also be useful for Xen and I think the answer is we
> should patch xen-pciback to use this new flag but I've not had time to
> look into that.
>
> I suppose by that measure the comment could be less KVM specific:
> > + /* Provide indication device is assigned by KVM */
> > + PCI_DEV_FLAGS_ASSIGNED = (__force pci_dev_flags_t) 4,
We can resubmit with a more generic comment, maybe this:
/* Provide indication device is assigned by a Virtual Machine Manager */
>
> but that's not exactly a big deal.
>
> I suppose really the flag indicates "VF in use" rather than necessarily
> "assigned"? Would it be just as bad to have a VF driver in the host
> active when the PF was unloaded?
There is no issue with unloading an active VF in the host because the hot remove event is seen by the host and accesses to the device stop. However, when you hot remove the device the host and it is assigned to a VM the VM is unaware of the event and has no way of propagating the hot remove event. So it really is a VF assigned to VM flag. There's no need to mark VFs as in use in the host.
- Greg
next prev parent reply other threads:[~2011-09-23 14:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 10:12 [net-next 0/8][pull request] Intel Wired LAN Driver Update Jeff Kirsher
2011-09-21 10:12 ` [net-next 1/8] pci: Add flag indicating device has been assigned by KVM Jeff Kirsher
2011-09-23 4:16 ` Jeff Kirsher
2011-09-23 5:20 ` Jesse Barnes
[not found] ` <20110923104957.2f76d1a4@jbarnes-x220>
2011-09-23 5:23 ` Jeff Kirsher
2011-09-23 7:27 ` Ian Campbell
2011-09-23 14:41 ` Rose, Gregory V [this message]
2011-09-23 15:03 ` Ian Campbell
2011-09-23 15:11 ` Rose, Gregory V
2011-09-23 15:45 ` Jeff Kirsher
2011-09-23 16:43 ` Konrad Rzeszutek Wilk
2011-09-23 17:04 ` Rose, Gregory V
2011-09-23 18:00 ` Konrad Rzeszutek Wilk
2011-09-23 18:24 ` Rose, Gregory V
2011-09-23 19:05 ` Konrad Rzeszutek Wilk
2011-09-23 19:20 ` Rose, Gregory V
2011-09-24 4:41 ` Jeff Kirsher
2011-09-26 16:25 ` [net-next 1/8] pci: Add flag indicating device has been assigned by KVM [and Xen] Konrad Rzeszutek Wilk
2011-09-26 16:31 ` Rose, Gregory V
2011-09-26 16:42 ` Konrad Rzeszutek Wilk
2011-09-26 17:01 ` Rose, Gregory V
2011-09-21 10:12 ` [net-next 2/8] ixgbe: Reconfigure SR-IOV Init Jeff Kirsher
2011-09-21 10:12 ` [net-next 3/8] ixgbe: DCB, do not call set_state() from IEEE mode Jeff Kirsher
2011-09-21 10:12 ` [net-next 4/8] ixgbe: cleanup X540 interrupt enablement Jeff Kirsher
2011-09-21 10:12 ` [net-next 5/8] ixgbe: dcb, set priority to traffic class mappings Jeff Kirsher
2011-09-21 10:12 ` [net-next 6/8] ixgbe: avoid HW lockup when adapter is reset with Tx work pending Jeff Kirsher
2011-09-21 10:12 ` [net-next 7/8] ixgbe: add WOL support for X540 Jeff Kirsher
2011-09-21 10:12 ` [net-next 8/8] ixgbe: remove global reset to the MAC Jeff Kirsher
2011-09-21 19:13 ` [net-next 0/8][pull request] Intel Wired LAN Driver Update David Miller
2011-09-21 19:58 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F901BD926A4E43B106BF17856F0755019C518C0E@orsmsx508.amr.corp.intel.com \
--to=gregory.v.rose@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=ijc@hellion.org.uk \
--cc=jbarnes@virtuousgeek.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.