From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rose, Gregory V" Subject: RE: [net-next 1/8] pci: Add flag indicating device has been assigned by KVM Date: Fri, 23 Sep 2011 10:04:59 -0700 Message-ID: <43F901BD926A4E43B106BF17856F0755019C518D57@orsmsx508.amr.corp.intel.com> References: <1316599974-23205-1-git-send-email-jeffrey.t.kirsher@intel.com> <1316599974-23205-2-git-send-email-jeffrey.t.kirsher@intel.com> <1316762872.23371.88.camel@zakaz.uk.xensource.com> <43F901BD926A4E43B106BF17856F0755019C518C0E@orsmsx508.amr.corp.intel.com> <1316790220.23371.105.camel@zakaz.uk.xensource.com> <43F901BD926A4E43B106BF17856F0755019C518C47@orsmsx508.amr.corp.intel.com> <1316792710.2182.124.camel@jtkirshe-mobl> <20110923164326.GA23363@phenom.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: Ian Campbell , "davem@davemloft.net" , Jesse Barnes , "netdev@vger.kernel.org" , "gospo@redhat.com" , "linux-pci@vger.kernel.org" To: Konrad Rzeszutek Wilk , "Kirsher, Jeffrey T" Return-path: In-Reply-To: <20110923164326.GA23363@phenom.oracle.com> Content-Language: en-US Sender: linux-pci-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > -----Original Message----- > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com] > Sent: Friday, September 23, 2011 9:43 AM > To: Kirsher, Jeffrey T > Cc: Rose, Gregory V; Ian Campbell; davem@davemloft.net; Jesse Barnes; > netdev@vger.kernel.org; gospo@redhat.com; linux-pci@vger.kernel.org > Subject: Re: [net-next 1/8] pci: Add flag indicating device has been > assigned by KVM > > On Fri, Sep 23, 2011 at 08:45:09AM -0700, Jeff Kirsher wrote: > > On Fri, 2011-09-23 at 08:11 -0700, Rose, Gregory V wrote: > > > > -----Original Message----- > > > > From: Ian Campbell [mailto:ijc@hellion.org.uk] > > > > Sent: Friday, September 23, 2011 8:04 AM > > > > To: Rose, Gregory V > > > > Cc: Kirsher, Jeffrey T; davem@davemloft.net; konrad.wilk@oracle.com; > Jesse > > > > Barnes; netdev@vger.kernel.org; gospo@redhat.com; linux- > > > > pci@vger.kernel.org > > > > Subject: RE: [net-next 1/8] pci: Add flag indicating device has been > > > > assigned by KVM > > > > > > > > On Fri, 2011-09-23 at 07:41 -0700, Rose, Gregory V wrote: > > > > > > -----Original Message----- > > > > > > From: Ian Campbell [mailto:ijc@hellion.org.uk] > > > > > > Sent: Friday, September 23, 2011 12:28 AM > > > > > > To: Kirsher, Jeffrey T > > > > > > Cc: davem@davemloft.net; konrad.wilk@oracle.com; Jesse Barnes; > Rose, > > > > > > Gregory V; netdev@vger.kernel.org; gospo@redhat.com; linux- > > > > > > pci@vger.kernel.org > > > > > > Subject: Re: [net-next 1/8] pci: Add flag indicating device has > been > > > > > > assigned by KVM > > > > > > > > > > > > I suppose by that measure the comment could be less KVM > specific: > > > > > > > + /* Provide indication device is assigned by KVM */ > > > > > > > + PCI_DEV_FLAGS_ASSIGNED = (__force pci_dev_flags_t) 4, > > > > > > > > > > We can resubmit with a more generic comment, maybe this: > > > > > > > > > > /* Provide indication device is assigned by a Virtual Machine > Manager */ > > > > > > > > Sounds good to me. > > > > > > Dave, Jeff, > > > > > > Should I resubmit the patch or would it be more convenient to post a > follow on patch that fixes up the comment? Either way is fine by me. > > > > > > - Greg > > > > > > > let's fix up the patch in my tree and add Jesse Barnes's ACK at the same > > time. > > Were are the patches now? I am kind of curious to see the changes to the > xen pciback. > > Version 2 of this patch with the modified comment was just posted to netdev. Ian Campbell had mentioned that the Xen pciback driver should be modified to use this flag but I don't believe any patches for it have been created yet. - Greg