From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754656AbcJEHiC (ORCPT ); Wed, 5 Oct 2016 03:38:02 -0400 Received: from mga11.intel.com ([192.55.52.93]:2246 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbcJEHiA (ORCPT ); Wed, 5 Oct 2016 03:38:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,448,1473145200"; d="scan'208";a="1040533123" Subject: Re: [PATCH 1/2] perf intel-pt: Fix estimated timestamps for cycle-accurate mode To: Arnaldo Carvalho de Melo References: <1475062896-22274-1-git-send-email-adrian.hunter@intel.com> Cc: Jiri Olsa , linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <43aa0250-fe84-f70a-8995-04af72c584f9@intel.com> Date: Wed, 5 Oct 2016 10:33:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1475062896-22274-1-git-send-email-adrian.hunter@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/16 14:41, Adrian Hunter wrote: > In cycle-accurate mode, timestamps can be calculated from CYC packets. The > decoder also estimates timestamps based on the number of instructions since > the last timestamp. For that to work in cycle-accurate mode, the > instruction count needs to be reset to zero when a timestamp is calculated > from a CYC packet, but that wasn't happening, so fix it. > > Signed-off-by: Adrian Hunter > Cc: stable@vger.kernel.org # v4.3+ Hi These 2 patches are still outstanding when you have time. Regards Adrian > --- > tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > index 7591a0c37473..3d1d446f037f 100644 > --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > @@ -1353,6 +1353,8 @@ static void intel_pt_calc_cyc_timestamp(struct intel_pt_decoder *decoder) > timestamp, decoder->timestamp); > else > decoder->timestamp = timestamp; > + > + decoder->timestamp_insn_cnt = 0; > } > > /* Walk PSB+ packets when already in sync. */ >