From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3268CCA47E for ; Tue, 7 Jun 2022 07:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237631AbiFGHYv (ORCPT ); Tue, 7 Jun 2022 03:24:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237622AbiFGHYu (ORCPT ); Tue, 7 Jun 2022 03:24:50 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 572D5C03AB for ; Tue, 7 Jun 2022 00:24:48 -0700 (PDT) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LHMLL1YXkzpXQM; Tue, 7 Jun 2022 15:24:26 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 7 Jun 2022 15:24:43 +0800 Received: from [10.174.177.211] (10.174.177.211) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 7 Jun 2022 15:24:43 +0800 Message-ID: <43b38b5c-f996-30e6-f120-a7bccee89d39@huawei.com> Date: Tue, 7 Jun 2022 15:24:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH 1/5] parse_layout_faulty: fix memleak To: Mariusz Tkaczyk CC: , , , References: <00992179-9572-ceb4-eb49-492c42e67695@huawei.com> <20220531093620.000058b4@linux.intel.com> From: Wu Guanghao In-Reply-To: <20220531093620.000058b4@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.211] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org 在 2022/5/31 15:36, Mariusz Tkaczyk 写道: > On Tue, 31 May 2022 14:49:17 +0800 > Wu Guanghao wrote: > >> char *m is allocated by xstrdup but not free() before return, will cause >> a memory leak >> >> Signed-off-by: Wu Guanghao >> --- >> util.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/util.c b/util.c >> index cc94f96e..da18a68d 100644 >> --- a/util.c >> +++ b/util.c >> @@ -429,6 +429,7 @@ int parse_layout_faulty(char *layout) >> int mode; >> m[ln] = 0; >> mode = map_name(faultylayout, m); >> + free(m); >> if (mode == UnSet) >> return -1; >> > > Hi, > Please add empty lines to separate declarations and not related code > sections. > Thanks for your reply. I will be modified in PATCH v2. > Thanks, > Mariusz > > . >