All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Hans Verkuil" <hverkuil-cisco@xs4all.nl>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Prabhakar <prabhakar.csengg@gmail.com>,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH v2 1/4] media: dt-bindings: Document Renesas RZ/G2L CSI-2 block
Date: Thu, 8 Sep 2022 13:38:32 +0200	[thread overview]
Message-ID: <43c63dce-60fc-f21e-4ca3-5ba2518b79b7@linaro.org> (raw)
In-Reply-To: <20220905230406.30801-2-prabhakar.mahadev-lad.rj@bp.renesas.com>

On 06/09/2022 01:04, Lad Prabhakar wrote:
> Document the CSI-2 block which is part of CRU found in Renesas
> RZ/G2L (and alike) SoCs.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Thank you for your patch. There is something to discuss/improve.

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/r9a07g044-cpg.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    csi: csi2@10830400 {

That's still not properly named. Node name just "csi".

With that:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

  reply	other threads:[~2022-09-08 11:38 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05 23:04 [PATCH v2 0/4] Add driver for CSI2 and CRU modules found on Renesas RZ/G2L SoC Lad Prabhakar
2022-09-05 23:04 ` [PATCH v2 1/4] media: dt-bindings: Document Renesas RZ/G2L CSI-2 block Lad Prabhakar
2022-09-08 11:38   ` Krzysztof Kozlowski [this message]
2022-09-08 11:39   ` Krzysztof Kozlowski
2022-09-21 12:31     ` Lad, Prabhakar
2022-09-21 15:49       ` Krzysztof Kozlowski
2022-09-05 23:04 ` [PATCH v2 2/4] media: dt-bindings: Document Renesas RZ/G2L CRU block Lad Prabhakar
2022-09-08 11:40   ` Krzysztof Kozlowski
2022-09-21 12:43     ` Laurent Pinchart
2022-09-21 15:51       ` Krzysztof Kozlowski
2022-09-21 17:29         ` Laurent Pinchart
2022-09-21 18:58           ` Krzysztof Kozlowski
2022-09-22 13:46             ` Laurent Pinchart
2022-09-30 10:49               ` Lad, Prabhakar
2022-09-30 12:07                 ` Krzysztof Kozlowski
2022-09-30 21:05                 ` Laurent Pinchart
2022-09-05 23:04 ` [PATCH v2 3/4] media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver Lad Prabhakar
2022-09-21 16:12   ` Laurent Pinchart
2022-09-22 12:08     ` Lad, Prabhakar
2022-09-22 12:34       ` Sakari Ailus
2022-09-22 12:51         ` Geert Uytterhoeven
2022-09-22 13:27           ` Lad, Prabhakar
2022-09-22 13:51             ` Laurent Pinchart
2022-09-22 19:13             ` Geert Uytterhoeven
2022-09-22 13:12         ` Lad, Prabhakar
2022-09-21 21:35   ` Sakari Ailus
2022-09-22 12:53     ` Lad, Prabhakar
2022-09-22 13:02       ` Sakari Ailus
2022-09-22 13:16         ` Lad, Prabhakar
2022-09-05 23:04 ` [PATCH v2 4/4] media: platform: Add Renesas RZ/G2L CRU driver Lad Prabhakar
2022-09-22 15:28   ` Laurent Pinchart
2022-09-23 19:02     ` Lad, Prabhakar
2022-09-26  8:59       ` Laurent Pinchart
2022-09-26 16:24         ` Lad, Prabhakar
2022-09-26 16:29           ` Laurent Pinchart
2022-09-26 17:27             ` Lad, Prabhakar
2022-09-26 18:11               ` Laurent Pinchart
2022-09-27 19:23                 ` Lad, Prabhakar
2022-09-23 20:14   ` Sakari Ailus
2022-09-24 11:38     ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43c63dce-60fc-f21e-4ca3-5ba2518b79b7@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=p.zabel@pengutronix.de \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.