From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/6] cfg80211: add wiphy_idx_valid to check for wiphy_idx sanity
Date: Thu, 12 Feb 2009 23:08:02 -0800 [thread overview]
Message-ID: <43e72e890902122308x375cc22fu1c27f8fe9aaac524@mail.gmail.com> (raw)
In-Reply-To: <1234507985.1327.15.camel@johannes.local>
On Thu, Feb 12, 2009 at 10:53 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Thu, 2009-02-12 at 21:35 -0800, Luis R. Rodriguez wrote:
>
>> - if (unlikely(drv->wiphy_idx < 0)) {
>> + if (!wiphy_idx_valid(drv->wiphy_idx)) {
>
>> +/* Note 0 is valid, hence phy0 */
>> +static inline
>> +bool wiphy_idx_valid(int wiphy_idx)
>> +{
>> + return (likely(wiphy_idx >= 0));
>> +}
>
> Does that really work properly with the likely in there?
Oh you mean !likely() won't give me my unlikely() effect? I think so
as the path is meant to not be optimized so the optimized path would
be put first, no?
Luis
next prev parent reply other threads:[~2009-02-13 7:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 5:35 [PATCH 0/6] cfg80211: adds a workqueue for regulatory hints Luis R. Rodriguez
2009-02-13 5:35 ` [PATCH 1/6] cfg80211: rename cfg80211_registered_device's idx to wiphy_idx Luis R. Rodriguez
2009-02-13 5:35 ` [PATCH 2/6] cfg80211: add wiphy_idx_valid to check for wiphy_idx sanity Luis R. Rodriguez
2009-02-13 5:36 ` [PATCH 3/6] cfg80211: rename cfg80211_drv_mutex to cfg80211_mutex Luis R. Rodriguez
2009-02-13 5:36 ` [PATCH 4/6] cfg80211: add assert_cfg80211_lock() to ensure proper protection Luis R. Rodriguez
2009-02-13 5:36 ` [PATCH 5/6] cfg80211: make regulatory_request use wiphy_idx instead of wiphy Luis R. Rodriguez
2009-02-13 5:36 ` [PATCH 6/6] cfg80211: move regulatory hints to workqueue Luis R. Rodriguez
2009-02-13 6:56 ` Johannes Berg
2009-02-13 7:09 ` Luis R. Rodriguez
2009-02-13 7:14 ` Luis R. Rodriguez
2009-02-13 7:14 ` Luis R. Rodriguez
2009-02-13 7:17 ` Johannes Berg
2009-02-13 7:35 ` Luis R. Rodriguez
2009-02-13 7:48 ` Johannes Berg
2009-02-13 7:57 ` Luis R. Rodriguez
2009-02-13 8:08 ` Johannes Berg
2009-02-13 8:19 ` Luis R. Rodriguez
2009-02-13 11:04 ` [PATCH 5/6] cfg80211: make regulatory_request use wiphy_idx instead of wiphy Johannes Berg
2009-02-13 18:21 ` Luis R. Rodriguez
2009-02-13 21:24 ` Johannes Berg
2009-02-13 21:40 ` Luis R. Rodriguez
2009-02-13 6:54 ` [PATCH 4/6] cfg80211: add assert_cfg80211_lock() to ensure proper protection Johannes Berg
2009-02-13 7:08 ` Luis R. Rodriguez
2009-02-13 6:53 ` [PATCH 2/6] cfg80211: add wiphy_idx_valid to check for wiphy_idx sanity Johannes Berg
2009-02-13 7:08 ` Luis R. Rodriguez [this message]
2009-02-13 7:18 ` Johannes Berg
2009-02-13 9:13 ` [PATCH 0/6] cfg80211: adds a workqueue for regulatory hints Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e890902122308x375cc22fu1c27f8fe9aaac524@mail.gmail.com \
--to=lrodriguez@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.