Re: Reverting 5d423 fixes loading of ath9k on Acer Extensa 7630EZ

From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Greg KH <greg@kroah.com>, Chris Wright <chrisw@sous-sol.org>,
	stable@kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Yannick Roehlly <yannick.roehlly@free.fr>,
	Yinghai Lu <yinghai@kernel.org>,
	Jesse Barnes <jesse.barnes@intel.com>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Andrew Morton <akpm@linux-foundation.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	berndl81@gmx.at, Ingo Molnar <mingo@elte.hu>,
	Stefan Bader <stefan.bader@canonical.com>
Subject: Re: Reverting 5d423 fixes loading of ath9k on Acer Extensa 7630EZ
Date: Tue, 10 Nov 2009 12:50:21 -0800	[thread overview]
Message-ID: <43e72e890911101250tcc8dcdk7a639bdbe7b00215@mail.gmail.com> (raw)
In-Reply-To: <43e72e890911101230t23933eaem4d7bc10237e1a725@mail.gmail.com>

On Tue, Nov 10, 2009 at 12:30 PM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> On Mon, Nov 9, 2009 at 7:49 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
>> On Sun, Nov 8, 2009 at 11:15 PM, Ingo Molnar <mingo@elte.hu> wrote:
>>>
>>> * Luis R. Rodriguez <mcgrof@gmail.com> wrote:
>>>
>>>> On Wed, Nov 4, 2009 at 11:14 PM, Ingo Molnar <mingo@elte.hu> wrote:
>>>> >
>>>> > * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>>>> >
>>>> >> On Wed, 4 Nov 2009, Luis R. Rodriguez wrote:
>>>> >> >
>>>> >> > Can you please consider reviewing this issue and help determine if
>>>> >> > this indeed needs to be reverted for 2.6.32 and the next 2.6.31.y.
>>>> >> >
>>>> >> > I am curious if other devices would work by reverting this as well.
>>>> >> > [ ... ] For details please feel free to check:
>>>> >> >
>>>> >> > http://bugzilla.kernel.org/show_bug.cgi?id=14402
>>>> >>
>>>> >> That same commit was the cause for
>>>> >>
>>>> >> ?? ?? ?? http://bugzilla.kernel.org/show_bug.cgi?id=13940
>>>> >>
>>>> >> and we just increased the rounding to make it go away (see commit
>>>> >> 15b812f1). But that was a hack.
>>>> >>
>>>> >> And if that didn't help the ath9k case, then we should just revert
>>>> >> entirely.
>>>> >
>>>> > Agreed - below is the combo 15b812f1 + 5d423ccd revert. (Would be nice
>>>> > to get the boot log of the latest post-15b812f1 kernel that Yinghai
>>>> > asked for before we revert, in the hope of better understanding the
>>>> > problem.)
>>>>
>>>> Bernhard has confirmed the new patch fixes this issue.
>>>
>>> Good - so latest kernels should be fine (on Bernhard's box) and no
>>> change is needed, right?
>>
>> Yea, but it does mean we need a fix propagated down to older kernels.
>
> Greg, please consider applying 15b812f1d0 to stable 2.6.31 as it fixes
> an issue introduced on 2.6.31 and only fixed now for 2.6.32. This
> should fix an issue when loading either sky2 or ath9k on some specific
> platforms.
>
> The details for the ath9k debugging are available on this bug:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=14402

Just noticed this did make it to 2.6.31.6, sorry for the noise and thanks.

  Luis