From: "Christian König" <christian.koenig@amd.com> To: Aman Jain <ahjain2706@gmail.com>, alexander.deucher@amd.com, airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] This patch replaces all the instances of dev_info with drm_info macro Date: Tue, 22 Jun 2021 08:40:26 +0200 [thread overview] Message-ID: <43f6b863-2594-1eb1-c2ef-f8251a10336b@amd.com> (raw) In-Reply-To: <YNF+Cr9wHupnt3Za@reb0rn> Am 22.06.21 um 08:07 schrieb Aman Jain: > When a driver has multiple instances it is necessary to differentiate > between them in the logs. This was done with dev_info/warn/err since > DRM_INFO/WARN/ERROR don't do this. We now have drm_info/warn/err for > printing the relevant debug messages. Hence, this patch uses > drm_* macros to achieve drm-formatted logging Well first of all patches for radeon should have a drm/radeon prefix in its subject line. Then I don't think this patch makes sense since this is about the hardware support of the module and not even remotely drm related. So we most likely don't want the drm-formating here in the first place. Regards, Christian. > > Signed-off-by: Aman Jain <ahjain2706@gmail.com> > --- > drivers/gpu/drm/radeon/radeon_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c > index efeb115ae70e..75e84914c29b 100644 > --- a/drivers/gpu/drm/radeon/radeon_drv.c > +++ b/drivers/gpu/drm/radeon/radeon_drv.c > @@ -308,7 +308,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, > case CHIP_VERDE: > case CHIP_OLAND: > case CHIP_HAINAN: > - dev_info(&pdev->dev, > + drm_info(&pdev->dev, > "SI support disabled by module param\n"); > return -ENODEV; > } > @@ -320,7 +320,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, > case CHIP_HAWAII: > case CHIP_KABINI: > case CHIP_MULLINS: > - dev_info(&pdev->dev, > + drm_info(&pdev->dev, > "CIK support disabled by module param\n"); > return -ENODEV; > }
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com> To: Aman Jain <ahjain2706@gmail.com>, alexander.deucher@amd.com, airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] This patch replaces all the instances of dev_info with drm_info macro Date: Tue, 22 Jun 2021 08:40:26 +0200 [thread overview] Message-ID: <43f6b863-2594-1eb1-c2ef-f8251a10336b@amd.com> (raw) In-Reply-To: <YNF+Cr9wHupnt3Za@reb0rn> Am 22.06.21 um 08:07 schrieb Aman Jain: > When a driver has multiple instances it is necessary to differentiate > between them in the logs. This was done with dev_info/warn/err since > DRM_INFO/WARN/ERROR don't do this. We now have drm_info/warn/err for > printing the relevant debug messages. Hence, this patch uses > drm_* macros to achieve drm-formatted logging Well first of all patches for radeon should have a drm/radeon prefix in its subject line. Then I don't think this patch makes sense since this is about the hardware support of the module and not even remotely drm related. So we most likely don't want the drm-formating here in the first place. Regards, Christian. > > Signed-off-by: Aman Jain <ahjain2706@gmail.com> > --- > drivers/gpu/drm/radeon/radeon_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c > index efeb115ae70e..75e84914c29b 100644 > --- a/drivers/gpu/drm/radeon/radeon_drv.c > +++ b/drivers/gpu/drm/radeon/radeon_drv.c > @@ -308,7 +308,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, > case CHIP_VERDE: > case CHIP_OLAND: > case CHIP_HAINAN: > - dev_info(&pdev->dev, > + drm_info(&pdev->dev, > "SI support disabled by module param\n"); > return -ENODEV; > } > @@ -320,7 +320,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, > case CHIP_HAWAII: > case CHIP_KABINI: > case CHIP_MULLINS: > - dev_info(&pdev->dev, > + drm_info(&pdev->dev, > "CIK support disabled by module param\n"); > return -ENODEV; > } _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-06-22 6:40 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-22 6:07 [PATCH] This patch replaces all the instances of dev_info with drm_info macro Aman Jain 2021-06-22 6:07 ` Aman Jain 2021-06-22 6:40 ` Christian König [this message] 2021-06-22 6:40 ` Christian König 2021-06-22 11:22 ` kernel test robot 2021-06-22 11:22 ` kernel test robot 2021-06-22 11:22 ` kernel test robot 2021-06-22 11:47 ` kernel test robot 2021-06-22 11:47 ` kernel test robot 2021-06-22 11:47 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=43f6b863-2594-1eb1-c2ef-f8251a10336b@amd.com \ --to=christian.koenig@amd.com \ --cc=ahjain2706@gmail.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=daniel@ffwll.ch \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.