From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932528AbdEDRru (ORCPT ); Thu, 4 May 2017 13:47:50 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:34292 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932411AbdEDRrm (ORCPT ); Thu, 4 May 2017 13:47:42 -0400 Subject: Re: [PATCH] ion: hisilicon: check the right value after ion_heap_create To: Yisheng Xie , sumit.semwal@linaro.org, gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, wporter82@gmail.com References: <1493909133-3868-1-git-send-email-ysxie@foxmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Laura Abbott Message-ID: <43fbdb96-78ed-2429-2ead-e79081b2a6fb@redhat.com> Date: Thu, 4 May 2017 10:47:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1493909133-3868-1-git-send-email-ysxie@foxmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/04/2017 07:45 AM, Yisheng Xie wrote: > From: Yisheng Xie > > It should check ipdev->heaps[i] whether it is error or null instead of > ipdev->heaps, after ion_heap_create() for ipdev->heaps[i]. > > Signed-off-by: Yisheng Xie > --- > drivers/staging/android/ion/hisilicon/hi6220_ion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c > index 0de7897..7f8eda5 100644 > --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c > +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c > @@ -66,7 +66,7 @@ static int hi6220_ion_probe(struct platform_device *pdev) > > for (i = 0; i < ipdev->data->nr; i++) { > ipdev->heaps[i] = ion_heap_create(&ipdev->data->heaps[i]); > - if (!ipdev->heaps) { > + if (IS_ERR_OR_NULL(ipdev->heaps[i])) { > ion_destroy_platform_data(ipdev->data); > return -ENOMEM; > } > This file was removed in a recent clean up series. Thanks, Laura