All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Paolo Lungaroni <paolo.lungaroni@uniroma2.it>,
	David Ahern <dsahern@kernel.org>,
	netdev@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Stefano Salsano <stefano.salsano@uniroma2.it>,
	Ahmed Abdelsalam <ahabdels.dev@gmail.com>,
	Andrea Mayer <andrea.mayer@uniroma2.it>
Subject: Re: [iproute2-next] seg6: add counters support for SRv6 Behaviors
Date: Sat, 1 May 2021 09:14:08 -0600	[thread overview]
Message-ID: <44091450-1b0d-664f-07e6-7eff48ca92c7@gmail.com> (raw)
In-Reply-To: <20210427155543.32268-1-paolo.lungaroni@uniroma2.it>

On 4/27/21 9:55 AM, Paolo Lungaroni wrote:
> @@ -932,6 +997,11 @@ static int parse_encap_seg6local(struct rtattr *rta, size_t len, int *argcp,
>  			if (!oif)
>  				exit(nodev(*argv));
>  			ret = rta_addattr32(rta, len, SEG6_LOCAL_OIF, oif);
> +		} else if (strcmp(*argv, "count") == 0) {
> +			if (counters_ok++)
> +				duparg2("count", *argv);
> +			ret = seg6local_fill_counters(rta, len,
> +						      SEG6_LOCAL_COUNTERS);
>  		} else if (strcmp(*argv, "srh") == 0) {
>  			NEXT_ARG();
>  			if (srh_ok++)
> 

change looks fine. Can you send a v2 with the help and route.8 man page
updates? Thanks,

  reply	other threads:[~2021-05-01 15:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 15:55 [iproute2-next] seg6: add counters support for SRv6 Behaviors Paolo Lungaroni
2021-05-01 15:14 ` David Ahern [this message]
2021-05-01 22:55   ` Paolo Lungaroni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44091450-1b0d-664f-07e6-7eff48ca92c7@gmail.com \
    --to=dsahern@gmail.com \
    --cc=ahabdels.dev@gmail.com \
    --cc=andrea.mayer@uniroma2.it \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paolo.lungaroni@uniroma2.it \
    --cc=stefano.salsano@uniroma2.it \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.