All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Sakoman" <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][dunfell 23/25] kernel.bbclass: run do_symlink_kernsrc before do_patch
Date: Sun, 30 Aug 2020 08:16:17 -1000	[thread overview]
Message-ID: <4425ddd70d77fa0b45ee08e405937ab5f31f16f8.1598810890.git.steve@sakoman.com> (raw)
In-Reply-To: <cover.1598810890.git.steve@sakoman.com>

From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

There's a race between do_symlink_kernsrc and do_populate_lic, since
the latter is ordered "after do_patch"; so the two may run in
parallel. In some cases, that actually causes do_populate_lic to fail
if it happens to look for a license file somewhere under ${S} in the
short window after shutil.move and before the symlink has been
created.

Fix that by simply ordering symlink_kernsrc before do_patch. Any task
that pokes around in ${S} looking for files should be ordered after
do_patch, so this should also fix similar latent races with other ad
hoc tasks.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit c5dfc2586b4135cc86e91bb04fed837daf505676)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 9e3c34ad48..9eb9bd2844 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -152,7 +152,7 @@ python do_symlink_kernsrc () {
             shutil.move(s, kernsrc)
             os.symlink(kernsrc, s)
 }
-addtask symlink_kernsrc before do_configure after do_unpack
+addtask symlink_kernsrc before do_patch after do_unpack
 
 inherit kernel-arch deploy
 
-- 
2.17.1


  parent reply	other threads:[~2020-08-30 18:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-30 18:15 [OE-core][dunfell 00/25] Patch review Steve Sakoman
2020-08-30 18:15 ` [OE-core][dunfell 01/25] oeqa: runtime_tests: Extra GPG debugging Steve Sakoman
2020-08-30 18:15 ` [OE-core][dunfell 02/25] runqemu: Show an error for conflicting graphics options Steve Sakoman
2020-08-30 18:15 ` [OE-core][dunfell 03/25] oeqa/manual/bsp-hw.json : remove shutdown_system test Steve Sakoman
2020-08-30 18:15 ` [OE-core][dunfell 04/25] oeqa/manual/bsp-hw.json : remove X_server_can_start_up_with_runlevel_5_boot test Steve Sakoman
2020-08-30 18:15 ` [OE-core][dunfell 05/25] package_tar.bbclass: Sync to the other package_* classes Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 06/25] package.bbclass: Sort shlib2 output for hash equivalency Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 07/25] package.bbclass: explode the RPROVIDES so we don't think the versions are provides Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 08/25] image_types_wic: Add ASSUME_PROVIDED to WICVARS Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 09/25] devtool: expand SRC_URI when guessing recipe update mode Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 10/25] weston: add missing packageconfigs Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 11/25] gpgme: fix multilib header conflict Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 12/25] perf: backport a fix for confusing non-fatal error Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 13/25] bind: update to 9.11.22 ESV Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 14/25] bluez5: fix builds that require ell support Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 15/25] conf/machine: set UBOOT_MACHINE for qemumips and qemumips64 Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 16/25] multilib.conf: add u-boot to NON_MULTILIB_RECIPES Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 17/25] libubootenv: uprev to v0.3 Steve Sakoman
2020-09-09 13:26   ` Stefano Babic
2020-08-30 18:16 ` [OE-core][dunfell 18/25] libubootenv: inherit uboot-config Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 19/25] linux-yocto/5.4: update to v5.4.59 Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 20/25] linux-yocto/5.4: update to v5.4.60 Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 21/25] linux-yocto/5.4: update to v5.4.61 Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 22/25] kernel-yocto: checksum all modifications to available kernel fragments directories Steve Sakoman
2020-08-30 18:16 ` Steve Sakoman [this message]
2020-09-12  1:40   ` [OE-core][dunfell 23/25] kernel.bbclass: run do_symlink_kernsrc before do_patch Chanho Park
2020-09-12 19:10     ` Steve Sakoman
     [not found]     ` <16341EFF0D914A74.16354@lists.openembedded.org>
2020-09-16 15:18       ` Steve Sakoman
2020-09-21  8:58         ` Rasmus Villemoes
2020-08-30 18:16 ` [OE-core][dunfell 24/25] linux-firmware: upgrade 20200619 -> 20200721 Steve Sakoman
2020-08-30 18:16 ` [OE-core][dunfell 25/25] linux-firmware: update 20200721 -> 20200817 Steve Sakoman
2020-09-01 11:07 ` [OE-core][dunfell 00/25] Patch review Richard Purdie
2020-09-01 14:06   ` Steve Sakoman
2020-09-02  3:28     ` Christopher Clark
2020-09-02 14:52       ` Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4425ddd70d77fa0b45ee08e405937ab5f31f16f8.1598810890.git.steve@sakoman.com \
    --to=steve@sakoman.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.