From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 05/10] qede: Add core driver
Date: Tue, 19 Apr 2016 14:35:13 +0200
Message-ID: <44291434.0HKUfuGdmz@xps13>
References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com>
 <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: bruce.richardson@intel.com, dev@dpdk.org, stephen@networkplumber.org,
 ameen.rahman@qlogic.com, harish.patil@qlogic.com, sony.chacko@qlogic.com
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id B4A182C65
 for <dev@dpdk.org>; Tue, 19 Apr 2016 14:35:16 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id e201so12106860wme.0
 for <dev@dpdk.org>; Tue, 19 Apr 2016 05:35:16 -0700 (PDT)
In-Reply-To: <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-31 19:15, Rasesh Mody:
> +#
> +# CFLAGS
> +#
> +CFLAGS_ECORE_DRIVER = -Wno-unused-parameter
> +CFLAGS_ECORE_DRIVER += -Wno-unused-value
> +CFLAGS_ECORE_DRIVER += -Wno-sign-compare
> +CFLAGS_ECORE_DRIVER += -Wno-missing-prototypes
> +CFLAGS_ECORE_DRIVER += -Wno-cast-qual
> +CFLAGS_ECORE_DRIVER += -Wno-unused-function
> +CFLAGS_ECORE_DRIVER += -Wno-unused-variable
> +CFLAGS_ECORE_DRIVER += -Wno-strict-aliasing
> +CFLAGS_ECORE_DRIVER += -Wno-missing-prototypes
> +CFLAGS_ECORE_DRIVER += -Wno-format-nonliteral
> +ifeq ($(OS_TYPE),Linux)
> +CFLAGS_ECORE_DRIVER += -Wno-shift-negative-value
> +endif
> +
> +ifneq (,$(filter gcc gcc48,$(CC)))
> +CFLAGS_ECORE_DRIVER += -Wno-unused-but-set-variable
> +CFLAGS_ECORE_DRIVER += -Wno-missing-declarations
> +CFLAGS_ECORE_DRIVER += -Wno-maybe-uninitialized
> +CFLAGS_ECORE_DRIVER += -Wno-strict-prototypes
> +else ifeq ($(CC), clang)
> +CFLAGS_ECORE_DRIVER += -Wno-format-extra-args
> +CFLAGS_ECORE_DRIVER += -Wno-visibility
> +CFLAGS_ECORE_DRIVER += -Wno-empty-body
> +CFLAGS_ECORE_DRIVER += -Wno-invalid-source-encoding
> +CFLAGS_ECORE_DRIVER += -Wno-sometimes-uninitialized
> +CFLAGS_ECORE_DRIVER += -Wno-pointer-bool-conversion
> +else
> +#icc flags
> +endif
> +
> +#
> +# Add extra flags for base ecore driver files
> +# to disable warnings in them
> +#
> +#
> +ECORE_DRIVER_OBJS=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c)))
> +$(foreach obj, $(ECORE_DRIVER_OBJS), $(eval CFLAGS+=$(CFLAGS_ECORE_DRIVER)))

CFLAGS_ECORE_DRIVER options apply only to base driver.
So why not name it CFLAGS_BASE_DRIVER?

This part of the Makefile should be in the patch importing the base driver.