From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 03/11] drm/i915/execlists: Pull submit after
 dequeue under timeline lock
Date: Mon, 4 Jun 2018 15:19:26 +0100
Message-ID: <442e82f9-c77b-ace1-3f6c-a56541d0f64a@linux.intel.com>
References: <20180531185204.19520-1-chris@chris-wilson.co.uk>
 <20180531185204.19520-4-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 645356E923
 for <intel-gfx@lists.freedesktop.org>; Mon,  4 Jun 2018 14:19:28 +0000 (UTC)
In-Reply-To: <20180531185204.19520-4-chris@chris-wilson.co.uk>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDMxLzA1LzIwMTggMTk6NTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiB0aGUgbmV4dCBw
YXRjaCwgd2Ugd2lsbCBiZWdpbiBwcm9jZXNzaW5nIHRoZSBDU0IgZnJvbSBpbnNpZGUgdGhlCj4g
aW50ZXJydXB0IGhhbmRsZXIuIFRoaXMgbWVhbnMgdGhhdCB1cGRhdGluZyB0aGUgZXhlY2xpc3Rz
LT5wb3J0W10gd2lsbAoKSSdkIHB1dCBhbiBleHRyYSBub3RlIGhlcmUgdGhhdCB0aGlzIGlzIHZp
YSB0aGUgdXNlciBpbnRlcnJ1cHQgaG9va3MgYW5kIApub3QgdGhlIG1vcmUgb2J2aW91cyBjc2Ig
aW50ZXJydXB0LgoKPiBubyBsb25nZXIgYmUgbG9ja2VkIGJ5IHRoZSB0YXNrbGV0IGJ1dCBieSB0
aGUgZW5naW5lLT50aW1lbGluZS5sb2NrCj4gaW5zdGVhZC4gUHVsbCBkZXF1ZXVlIGFuZCBzdWJt
aXQgdW5kZXIgdGhlIHNhbWUgbG9jayBmb3IgcHJvdGVjdGlvbi4KPiAoQW4gYWx0ZXJuYXRpdmUs
IGZ1dHVyZSwgcGxhbiBpcyB0byBrZWVwIHRoZSBpbi9vdXQgYXJyYXlzIHNlcGFyYXRlIGZvcgo+
IGNvbmN1cnJlbnQgcHJvY2Vzc2luZyBhbmQgcmVkdWNlZCBsb2NrIGNvdmVyYWdlLikKPiAKPiBT
aWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAt
LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMzIgKysrKysrKysrKysr
LS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCsp
LCAyMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IGU1
Y2YwNDljMThmOC4uZDIwN2ExYmY5ZGM5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK
PiBAQCAtNTYyLDcgKzU2Miw3IEBAIHN0YXRpYyB2b2lkIGNvbXBsZXRlX3ByZWVtcHRfY29udGV4
dChzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqZXhlY2xpc3RzKQo+ICAgCWV4ZWNsaXN0
c19jbGVhcl9hY3RpdmUoZXhlY2xpc3RzLCBFWEVDTElTVFNfQUNUSVZFX1BSRUVNUFQpOwo+ICAg
fQo+ICAgCj4gLXN0YXRpYyBib29sIF9fZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0IGludGVsX2Vu
Z2luZV9jcyAqZW5naW5lKQo+ICtzdGF0aWMgdm9pZCBfX2V4ZWNsaXN0c19kZXF1ZXVlKHN0cnVj
dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxfZW5naW5l
X2V4ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0cyA9ICZlbmdpbmUtPmV4ZWNsaXN0czsKPiAgIAlz
dHJ1Y3QgZXhlY2xpc3RfcG9ydCAqcG9ydCA9IGV4ZWNsaXN0cy0+cG9ydDsKPiBAQCAtNjE3LDEx
ICs2MTcsMTEgQEAgc3RhdGljIGJvb2wgX19leGVjbGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50ZWxf
ZW5naW5lX2NzICplbmdpbmUpCj4gICAJCSAqIHRoZSBIVyB0byBpbmRpY2F0ZSB0aGF0IGl0IGhh
cyBoYWQgYSBjaGFuY2UgdG8gcmVzcG9uZC4KPiAgIAkJICovCj4gICAJCWlmICghZXhlY2xpc3Rz
X2lzX2FjdGl2ZShleGVjbGlzdHMsIEVYRUNMSVNUU19BQ1RJVkVfSFdBQ0spKQo+IC0JCQlyZXR1
cm4gZmFsc2U7Cj4gKwkJCXJldHVybjsKPiAgIAo+ICAgCQlpZiAobmVlZF9wcmVlbXB0KGVuZ2lu
ZSwgbGFzdCwgZXhlY2xpc3RzLT5xdWV1ZV9wcmlvcml0eSkpIHsKPiAgIAkJCWluamVjdF9wcmVl
bXB0X2NvbnRleHQoZW5naW5lKTsKPiAtCQkJcmV0dXJuIGZhbHNlOwo+ICsJCQlyZXR1cm47Cj4g
ICAJCX0KPiAgIAo+ICAgCQkvKgo+IEBAIC02NDYsNyArNjQ2LDcgQEAgc3RhdGljIGJvb2wgX19l
eGVjbGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJCSAq
IHByaW9yaXRpZXMgb2YgdGhlIHBvcnRzIGhhdmVuJ3QgYmVlbiBzd2l0Y2guCj4gICAJCSAqLwo+
ICAgCQlpZiAocG9ydF9jb3VudCgmcG9ydFsxXSkpCj4gLQkJCXJldHVybiBmYWxzZTsKPiArCQkJ
cmV0dXJuOwo+ICAgCj4gICAJCS8qCj4gICAJCSAqIFdhSWRsZUxpdGVSZXN0b3JlOmJkdyxza2wK
PiBAQCAtNzQ2LDggKzc0NiwxMCBAQCBzdGF0aWMgYm9vbCBfX2V4ZWNsaXN0c19kZXF1ZXVlKHN0
cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAkJcG9ydCAhPSBleGVjbGlzdHMtPnBv
cnQgPyBycV9wcmlvKGxhc3QpIDogSU5UX01JTjsKPiAgIAo+ICAgCWV4ZWNsaXN0cy0+Zmlyc3Qg
PSByYjsKPiAtCWlmIChzdWJtaXQpCj4gKwlpZiAoc3VibWl0KSB7Cj4gICAJCXBvcnRfYXNzaWdu
KHBvcnQsIGxhc3QpOwo+ICsJCWV4ZWNsaXN0c19zdWJtaXRfcG9ydHMoZW5naW5lKTsKPiArCX0K
PiAgIAo+ICAgCS8qIFdlIG11c3QgYWx3YXlzIGtlZXAgdGhlIGJlYXN0IGZlZCBpZiB3ZSBoYXZl
IHdvcmsgcGlsZWQgdXAgKi8KPiAgIAlHRU1fQlVHX09OKGV4ZWNsaXN0cy0+Zmlyc3QgJiYgIXBv
cnRfaXNzZXQoZXhlY2xpc3RzLT5wb3J0KSk7Cj4gQEAgLTc1NiwyNCArNzU4LDE5IEBAIHN0YXRp
YyBib29sIF9fZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l
KQo+ICAgCWlmIChsYXN0KQo+ICAgCQlleGVjbGlzdHNfdXNlcl9iZWdpbihleGVjbGlzdHMsIGV4
ZWNsaXN0cy0+cG9ydCk7Cj4gICAKPiAtCXJldHVybiBzdWJtaXQ7Cj4gKwkvKiBJZiB0aGUgZW5n
aW5lIGlzIG5vdyBpZGxlLCBzbyBzaG91bGQgYmUgdGhlIGZsYWc7IGFuZCB2aWNlIHZlcnNhLiAq
Lwo+ICsJR0VNX0JVR19PTihleGVjbGlzdHNfaXNfYWN0aXZlKCZlbmdpbmUtPmV4ZWNsaXN0cywK
PiArCQkJCSAgICAgICBFWEVDTElTVFNfQUNUSVZFX1VTRVIpID09Cj4gKwkJICAgIXBvcnRfaXNz
ZXQoZW5naW5lLT5leGVjbGlzdHMucG9ydCkpOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZCBl
eGVjbGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICB7Cj4g
LQlzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0cyA9ICZlbmdp
bmUtPmV4ZWNsaXN0czsKPiAgIAl1bnNpZ25lZCBsb25nIGZsYWdzOwo+IC0JYm9vbCBzdWJtaXQ7
Cj4gICAKPiAgIAlzcGluX2xvY2tfaXJxc2F2ZSgmZW5naW5lLT50aW1lbGluZS5sb2NrLCBmbGFn
cyk7Cj4gLQlzdWJtaXQgPSBfX2V4ZWNsaXN0c19kZXF1ZXVlKGVuZ2luZSk7Cj4gKwlfX2V4ZWNs
aXN0c19kZXF1ZXVlKGVuZ2luZSk7Cj4gICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZW5naW5l
LT50aW1lbGluZS5sb2NrLCBmbGFncyk7Cj4gLQo+IC0JaWYgKHN1Ym1pdCkKPiAtCQlleGVjbGlz
dHNfc3VibWl0X3BvcnRzKGVuZ2luZSk7Cj4gLQo+IC0JR0VNX0JVR19PTihwb3J0X2lzc2V0KGV4
ZWNsaXN0cy0+cG9ydCkgJiYKPiAtCQkgICAhZXhlY2xpc3RzX2lzX2FjdGl2ZShleGVjbGlzdHMs
IEVYRUNMSVNUU19BQ1RJVkVfVVNFUikpOwo+ICAgfQo+ICAgCj4gICB2b2lkCj4gQEAgLTExNTYs
MTEgKzExNTMsNiBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0KHVu
c2lnbmVkIGxvbmcgZGF0YSkKPiAgIAo+ICAgCWlmICghZXhlY2xpc3RzX2lzX2FjdGl2ZSgmZW5n
aW5lLT5leGVjbGlzdHMsIEVYRUNMSVNUU19BQ1RJVkVfUFJFRU1QVCkpCj4gICAJCWV4ZWNsaXN0
c19kZXF1ZXVlKGVuZ2luZSk7Cj4gLQo+IC0JLyogSWYgdGhlIGVuZ2luZSBpcyBub3cgaWRsZSwg
c28gc2hvdWxkIGJlIHRoZSBmbGFnOyBhbmQgdmljZSB2ZXJzYS4gKi8KPiAtCUdFTV9CVUdfT04o
ZXhlY2xpc3RzX2lzX2FjdGl2ZSgmZW5naW5lLT5leGVjbGlzdHMsCj4gLQkJCQkgICAgICAgRVhF
Q0xJU1RTX0FDVElWRV9VU0VSKSA9PQo+IC0JCSAgICFwb3J0X2lzc2V0KGVuZ2luZS0+ZXhlY2xp
c3RzLnBvcnQpKTsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQgcXVldWVfcmVxdWVzdChzdHJ1
Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3Vs
aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg
bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl
c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==