From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id D07E8C433F5 for ; Tue, 8 Feb 2022 17:03:52 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B13EB41141; Tue, 8 Feb 2022 18:03:51 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 7548D4111B for ; Tue, 8 Feb 2022 18:03:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 20EDD5C00CA; Tue, 8 Feb 2022 12:03:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 08 Feb 2022 12:03:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=5k3Tr8vv8kJvtP X/JktFLG2OkvG9rBaC2VwzWHCQJ7g=; b=mAb2edclzTE5dOyF0AfyahL218nGgb khIsWnBEoIkmxtd2uRaPESDgzGQbRakrTO3VBI+NZw1CnmQecS/3Ts70XOgE2Ia+ qI1cNukdEaN8YMg3NHtfw+s7V3vV99fKtjGsR05oG9iGEWeuQiHXsGgq25cud9OT qsohonLxUmaXOYMWkfTBNycJejmrfoaX6k356CcVZskM04p6N+DnqKIabxKapJU2 s5kt/oOM31jhLZci1jXBH4K6bAxTumEyZ4kfgvd8arqMggqn+AzkqcfZQCcnsMsv AU3Kd0GEf0nJ2luSDKHry1/sUK8P/mTDRzuRFgghIgvOkJJ+I7FhX+Tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5k3Tr8vv8kJvtPX/JktFLG2OkvG9rBaC2VwzWHCQJ 7g=; b=NYTV1leVvhiCCjMZlvNpU1yzZYZw1mx07+lbe7q4UkZNtMg3/784ktvoC 8ljkyJqLkYdwxrJ423OnlXDt5WMtbuau/pVxpYxMrvA3QAMDRWbZIHVhsZNt04XZ eB1+Tp2RyIRo2ms/PXb7bagQwfxpcZn6OJM8hygblVcOWrfRAuaHAFHkXCNJbGzD XS27LqN2gPMgfz5Dki/Q9+65DoclBg1JPSweUuO9atdrs5s3vEp0/QuDKe+tuRoo 2tkzlIbnMCG/rpaNnK2ke5t0uvxbJWt+s3T727cpf+o9D/DmqSgb/Na+hY3c0yHE dXM2x1miLoGiHoWVh5MmS6zmQZR4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheejgdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Feb 2022 12:03:47 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Olivier Matz , Andrew Rybchenko , Honnappa Nagarahalli , Konstantin Ananyev Subject: Re: [PATCH v2 01/83] lib: update documentation of XXX_free() functions Date: Tue, 08 Feb 2022 18:03:46 +0100 Message-ID: <44443668.fMDQidcC6G@thomas> In-Reply-To: <2119555.NgBsaNRSFp@thomas> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220128145155.11bf10cd@hermes.local> <2119555.NgBsaNRSFp@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/01/2022 19:51, Thomas Monjalon: > 28/01/2022 23:51, Stephen Hemminger: > > On Fri, 28 Jan 2022 22:47:15 +0100 > > Thomas Monjalon wrote: > > > > > 24/01/2022 18:45, Stephen Hemminger: > > > > These functions all behave like libc free() and do > > > > nothing if handed a NULL pointer. The code is already doing > > > > this, this patch just documents the behavior. > > > > > > > > Signed-off-by: Stephen Hemminger > > > > --- > > > > /** > > > > * De-allocate all memory used by hash table. > > > > + * > > > > + * If the pointer is NULL, the function does nothing. > > > > > > Would be better to move in the context of the parameter > > > > I copied text from rte_free to other functions... > > For consistency, lets document it one way in all cases. > > Don't care which one... > > I prefer to have comments about a parameter inside the @param please. Please would you provide a v3 before -rc1?