Re: [PATCH] hw/register: Document register_init_block @memory_size

[Laurent Vivier <laurent@vivier.eu>]

Le 09/07/2020 à 19:19, Alistair Francis a écrit :
> On Wed, Jul 8, 2020 at 5:43 AM Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
>>> Document the 'memory_size' argument of register_init_block().
>>>
>>> Fixes: a74229597e ("register: Add block initialise helper")
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>>  include/hw/register.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/hw/register.h b/include/hw/register.h
>>> index 5d2c565ae0..fdac5e69b5 100644
>>> --- a/include/hw/register.h
>>> +++ b/include/hw/register.h
>>> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
>>>   * @data: Array to use for register data, must already be allocated
>>>   * @ops: Memory region ops to access registers.
>>>   * @debug enabled: turn on/off verbose debug information
>>> + * @memory_size: Size of the memory region
>>>   * returns: A structure containing all of the registers and an initialized
>>>   *          memory region (r_array->mem) the caller should add to a container.
>>>   */
>>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> 
> Can this go via the trivial tree?
> 

Yes, I will try to do a PR before the hard freeze.

Thanks,
Laurent