All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuppuswamy Sathyanarayanan  <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>,
	Dave Hansen <dave.hansen@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>,
	Kirill Shutemov <kirill.shutemov@linux.intel.com>,
	Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Raj Ashok <ashok.raj@intel.com>,
	Sean Christopherson <seanjc@google.com>,
	linux-kernel@vger.kernel.org,
	Kuppuswamy Sathyanarayanan 
	<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: [RFC v1 21/26] x86/mm: Move force_dma_unencrypted() to common code
Date: Fri,  5 Feb 2021 15:38:38 -0800	[thread overview]
Message-ID: <444fe9c7c035417f6abc3e0be2a4861cb573ab28.1612563142.git.sathyanarayanan.kuppuswamy@linux.intel.com> (raw)
In-Reply-To: <cover.1612563142.git.sathyanarayanan.kuppuswamy@linux.intel.com>

From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>

Intel TDX doesn't allow VMM to access guest memory. Any memory that is
required for communication with VMM suppose to be shared explicitly by
setting the bit in page table entry. The shared memory is similar to
unencrypted memory in AMD SME/SEV terminology.

force_dma_unencrypted() has to return true for TDX guest. Move it out of
AMD SME code.

Introduce new config option X86_MEM_ENCRYPT_COMMON that has to be
selected by all x86 memory encryption features.

This is preparation for TDX changes in DMA code.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
 arch/x86/Kconfig                 |  8 +++++--
 arch/x86/include/asm/io.h        |  4 +++-
 arch/x86/mm/Makefile             |  2 ++
 arch/x86/mm/mem_encrypt.c        | 30 -------------------------
 arch/x86/mm/mem_encrypt_common.c | 38 ++++++++++++++++++++++++++++++++
 5 files changed, 49 insertions(+), 33 deletions(-)
 create mode 100644 arch/x86/mm/mem_encrypt_common.c

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 0374d9f262a5..8fa654d61ac2 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1538,14 +1538,18 @@ config X86_CPA_STATISTICS
 	  helps to determine the effectiveness of preserving large and huge
 	  page mappings when mapping protections are changed.
 
+config X86_MEM_ENCRYPT_COMMON
+	select ARCH_HAS_FORCE_DMA_UNENCRYPTED
+	select DYNAMIC_PHYSICAL_MASK
+	def_bool n
+
 config AMD_MEM_ENCRYPT
 	bool "AMD Secure Memory Encryption (SME) support"
 	depends on X86_64 && CPU_SUP_AMD
 	select DMA_COHERENT_POOL
-	select DYNAMIC_PHYSICAL_MASK
 	select ARCH_USE_MEMREMAP_PROT
-	select ARCH_HAS_FORCE_DMA_UNENCRYPTED
 	select INSTRUCTION_DECODER
+	select X86_MEM_ENCRYPT_COMMON
 	help
 	  Say yes to enable support for the encryption of system memory.
 	  This requires an AMD processor that supports Secure Memory
diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
index 30a3b30395ad..95e534cffa99 100644
--- a/arch/x86/include/asm/io.h
+++ b/arch/x86/include/asm/io.h
@@ -257,10 +257,12 @@ static inline void slow_down_io(void)
 
 #endif
 
-#ifdef CONFIG_AMD_MEM_ENCRYPT
 #include <linux/jump_label.h>
 
 extern struct static_key_false sev_enable_key;
+
+#ifdef CONFIG_AMD_MEM_ENCRYPT
+
 static inline bool sev_key_active(void)
 {
 	return static_branch_unlikely(&sev_enable_key);
diff --git a/arch/x86/mm/Makefile b/arch/x86/mm/Makefile
index 5864219221ca..b31cb52bf1bd 100644
--- a/arch/x86/mm/Makefile
+++ b/arch/x86/mm/Makefile
@@ -52,6 +52,8 @@ obj-$(CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS)	+= pkeys.o
 obj-$(CONFIG_RANDOMIZE_MEMORY)			+= kaslr.o
 obj-$(CONFIG_PAGE_TABLE_ISOLATION)		+= pti.o
 
+obj-$(CONFIG_X86_MEM_ENCRYPT_COMMON)	+= mem_encrypt_common.o
+
 obj-$(CONFIG_AMD_MEM_ENCRYPT)	+= mem_encrypt.o
 obj-$(CONFIG_AMD_MEM_ENCRYPT)	+= mem_encrypt_identity.o
 obj-$(CONFIG_AMD_MEM_ENCRYPT)	+= mem_encrypt_boot.o
diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
index c79e5736ab2b..11a6a7b3af7e 100644
--- a/arch/x86/mm/mem_encrypt.c
+++ b/arch/x86/mm/mem_encrypt.c
@@ -15,10 +15,6 @@
 #include <linux/dma-direct.h>
 #include <linux/swiotlb.h>
 #include <linux/mem_encrypt.h>
-#include <linux/device.h>
-#include <linux/kernel.h>
-#include <linux/bitops.h>
-#include <linux/dma-mapping.h>
 
 #include <asm/tlbflush.h>
 #include <asm/fixmap.h>
@@ -389,32 +385,6 @@ bool noinstr sev_es_active(void)
 	return sev_status & MSR_AMD64_SEV_ES_ENABLED;
 }
 
-/* Override for DMA direct allocation check - ARCH_HAS_FORCE_DMA_UNENCRYPTED */
-bool force_dma_unencrypted(struct device *dev)
-{
-	/*
-	 * For SEV, all DMA must be to unencrypted addresses.
-	 */
-	if (sev_active())
-		return true;
-
-	/*
-	 * For SME, all DMA must be to unencrypted addresses if the
-	 * device does not support DMA to addresses that include the
-	 * encryption mask.
-	 */
-	if (sme_active()) {
-		u64 dma_enc_mask = DMA_BIT_MASK(__ffs64(sme_me_mask));
-		u64 dma_dev_mask = min_not_zero(dev->coherent_dma_mask,
-						dev->bus_dma_limit);
-
-		if (dma_dev_mask <= dma_enc_mask)
-			return true;
-	}
-
-	return false;
-}
-
 void __init mem_encrypt_free_decrypted_mem(void)
 {
 	unsigned long vaddr, vaddr_end, npages;
diff --git a/arch/x86/mm/mem_encrypt_common.c b/arch/x86/mm/mem_encrypt_common.c
new file mode 100644
index 000000000000..964e04152417
--- /dev/null
+++ b/arch/x86/mm/mem_encrypt_common.c
@@ -0,0 +1,38 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * AMD Memory Encryption Support
+ *
+ * Copyright (C) 2016 Advanced Micro Devices, Inc.
+ *
+ * Author: Tom Lendacky <thomas.lendacky@amd.com>
+ */
+
+#include <linux/mm.h>
+#include <linux/mem_encrypt.h>
+#include <linux/dma-mapping.h>
+
+/* Override for DMA direct allocation check - ARCH_HAS_FORCE_DMA_UNENCRYPTED */
+bool force_dma_unencrypted(struct device *dev)
+{
+	/*
+	 * For SEV, all DMA must be to unencrypted/shared addresses.
+	 */
+	if (sev_active())
+		return true;
+
+	/*
+	 * For SME, all DMA must be to unencrypted addresses if the
+	 * device does not support DMA to addresses that include the
+	 * encryption mask.
+	 */
+	if (sme_active()) {
+		u64 dma_enc_mask = DMA_BIT_MASK(__ffs64(sme_me_mask));
+		u64 dma_dev_mask = min_not_zero(dev->coherent_dma_mask,
+						dev->bus_dma_limit);
+
+		if (dma_dev_mask <= dma_enc_mask)
+			return true;
+	}
+
+	return false;
+}
-- 
2.25.1


  parent reply	other threads:[~2021-02-06  3:00 UTC|newest]

Thread overview: 161+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 23:38 [RFC v1 00/26] Add TDX Guest Support Kuppuswamy Sathyanarayanan
2021-02-05 23:38 ` Kuppuswamy Sathyanarayanan
2021-02-06  6:24   ` sathyanarayanan.kuppuswamy
2021-02-06  3:04   ` Test Email sathyanarayanan.kuppuswamy
2021-02-06  3:02   ` sathyanarayanan.kuppuswamy
2021-02-05 23:38   ` [RFC v1 01/26] x86/paravirt: Introduce CONFIG_PARAVIRT_XL Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 02/26] x86/cpufeatures: Add TDX Guest CPU feature Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 03/26] x86/cpufeatures: Add is_tdx_guest() interface Kuppuswamy Sathyanarayanan
2021-04-01 21:08     ` Dave Hansen
2021-04-01 21:15       ` Kuppuswamy, Sathyanarayanan
2021-04-01 21:19         ` Dave Hansen
2021-04-01 22:25           ` Kuppuswamy, Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 04/26] x86/tdx: Get TD execution environment information via TDINFO Kuppuswamy Sathyanarayanan
2021-02-08 10:00     ` Peter Zijlstra
2021-02-08 19:10       ` Kuppuswamy, Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 05/26] x86/traps: Add #VE support for TDX guest Kuppuswamy Sathyanarayanan
2021-02-08 10:20     ` Peter Zijlstra
2021-02-08 16:23       ` Andi Kleen
2021-02-08 16:33         ` Peter Zijlstra
2021-02-08 16:46           ` Sean Christopherson
2021-02-08 16:59             ` Peter Zijlstra
2021-02-08 19:05               ` Kuppuswamy, Sathyanarayanan
2021-02-08 16:46           ` Andi Kleen
2021-02-12 19:20     ` Dave Hansen
2021-02-12 19:47     ` Andy Lutomirski
2021-02-12 20:06       ` Sean Christopherson
2021-02-12 20:17         ` Dave Hansen
2021-02-12 20:37           ` Sean Christopherson
2021-02-12 20:46             ` Dave Hansen
2021-02-12 20:54               ` Sean Christopherson
2021-02-12 21:06                 ` Dave Hansen
2021-02-12 21:37                   ` Sean Christopherson
2021-02-12 21:47                     ` Andy Lutomirski
2021-02-12 21:48                       ` Dave Hansen
2021-02-14 19:33                         ` Andi Kleen
2021-02-14 19:54                           ` Andy Lutomirski
2021-02-12 20:20         ` Andy Lutomirski
2021-02-12 20:44           ` Sean Christopherson
2021-02-05 23:38   ` [RFC v1 06/26] x86/tdx: Add HLT " Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 07/26] x86/tdx: Wire up KVM hypercalls Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 08/26] x86/tdx: Add MSR support for TDX guest Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 09/26] x86/tdx: Handle CPUID via #VE Kuppuswamy Sathyanarayanan
2021-02-05 23:42     ` Andy Lutomirski
2021-02-07 14:13       ` Kirill A. Shutemov
2021-02-07 16:01         ` Dave Hansen
2021-02-07 20:29           ` Kirill A. Shutemov
2021-02-07 22:31             ` Dave Hansen
2021-02-07 22:45               ` Andy Lutomirski
2021-02-08 17:10                 ` Sean Christopherson
2021-02-08 17:35                   ` Andy Lutomirski
2021-02-08 17:47                     ` Sean Christopherson
2021-03-18 21:30                 ` [PATCH v1 1/1] x86/tdx: Add tdcall() and tdvmcall() helper functions Kuppuswamy Sathyanarayanan
2021-03-19 16:55                   ` Sean Christopherson
2021-03-19 17:42                     ` Kuppuswamy, Sathyanarayanan
2021-03-19 18:22                       ` Dave Hansen
2021-03-19 19:58                         ` Kuppuswamy, Sathyanarayanan
2021-03-26 23:38                           ` [PATCH v2 1/1] x86/tdx: Add __tdcall() and __tdvmcall() " Kuppuswamy Sathyanarayanan
2021-04-20 17:36                             ` Dave Hansen
2021-04-20 19:20                               ` Kuppuswamy, Sathyanarayanan
2021-04-20 19:59                                 ` Dave Hansen
2021-04-20 23:12                                   ` Kuppuswamy, Sathyanarayanan
2021-04-20 23:42                                     ` Dave Hansen
2021-04-23  1:09                                       ` Kuppuswamy, Sathyanarayanan
2021-04-23  1:21                                         ` Dave Hansen
2021-04-23  1:35                                           ` Andi Kleen
2021-04-23 15:15                                             ` Sean Christopherson
2021-04-23 15:28                                               ` Dan Williams
2021-04-23 15:38                                                 ` Andi Kleen
2021-04-23 15:50                                                 ` Sean Christopherson
2021-04-23 15:47                                               ` Andi Kleen
2021-04-23 18:18                                               ` Kuppuswamy, Sathyanarayanan
2021-04-20 23:53                                     ` Dan Williams
2021-04-20 23:59                                       ` Kuppuswamy, Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 10/26] x86/io: Allow to override inX() and outX() implementation Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 11/26] x86/tdx: Handle port I/O Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 12/26] x86/tdx: Handle in-kernel MMIO Kuppuswamy Sathyanarayanan
2021-04-01 19:56     ` Dave Hansen
2021-04-01 22:26       ` Sean Christopherson
2021-04-01 22:53         ` Dave Hansen
2021-02-05 23:38   ` [RFC v1 13/26] x86/tdx: Handle MWAIT, MONITOR and WBINVD Kuppuswamy Sathyanarayanan
2021-02-05 23:43     ` Andy Lutomirski
2021-02-05 23:54       ` Kuppuswamy, Sathyanarayanan
2021-02-06  1:05         ` Andy Lutomirski
2021-03-27  0:18           ` [PATCH v1 1/1] " Kuppuswamy Sathyanarayanan
2021-03-27  2:40             ` Andy Lutomirski
2021-03-27  3:40               ` Kuppuswamy, Sathyanarayanan
2021-03-27 16:03                 ` Andy Lutomirski
2021-03-27 22:54                   ` [PATCH v2 " Kuppuswamy Sathyanarayanan
2021-03-29 17:14                     ` Dave Hansen
2021-03-29 21:55                       ` Kuppuswamy, Sathyanarayanan
2021-03-29 22:02                         ` Dave Hansen
2021-03-29 22:09                           ` Kuppuswamy, Sathyanarayanan
2021-03-29 22:12                             ` Dave Hansen
2021-03-29 22:42                               ` Kuppuswamy, Sathyanarayanan
2021-03-29 23:16                               ` [PATCH v3 " Kuppuswamy Sathyanarayanan
2021-03-29 23:23                                 ` Andy Lutomirski
2021-03-29 23:37                                   ` Kuppuswamy, Sathyanarayanan
2021-03-29 23:42                                     ` Sean Christopherson
2021-03-29 23:58                                       ` Andy Lutomirski
2021-03-30  2:04                                         ` Andi Kleen
2021-03-30  2:58                                           ` Andy Lutomirski
2021-03-30 15:14                                             ` Sean Christopherson
2021-03-30 16:37                                               ` Andy Lutomirski
2021-03-30 16:57                                                 ` Sean Christopherson
2021-04-07 15:24                                                   ` Andi Kleen
2021-03-31 21:09                                             ` [PATCH v4 " Kuppuswamy Sathyanarayanan
2021-03-31 21:49                                               ` Dave Hansen
2021-03-31 22:29                                                 ` Kuppuswamy, Sathyanarayanan
2021-03-31 21:53                                               ` Sean Christopherson
2021-03-31 22:00                                                 ` Dave Hansen
2021-03-31 22:06                                                   ` Sean Christopherson
2021-03-31 22:11                                                     ` Dave Hansen
2021-03-31 22:28                                                       ` Kuppuswamy, Sathyanarayanan
2021-03-31 22:32                                                         ` Sean Christopherson
2021-03-31 22:34                                                         ` Dave Hansen
2021-04-01  3:28                                                           ` Andi Kleen
2021-04-01  3:46                                                             ` Dave Hansen
2021-04-01  4:24                                                               ` Andi Kleen
2021-04-01  4:51                                                                 ` [PATCH v5 " Kuppuswamy Sathyanarayanan
2021-03-29 23:39                                   ` [PATCH v3 " Sean Christopherson
2021-03-29 23:38                                 ` Dave Hansen
2021-03-30  4:56             ` [PATCH v1 " Xiaoyao Li
2021-03-30 15:00               ` Andi Kleen
2021-03-30 15:10                 ` Dave Hansen
2021-03-30 17:02                   ` Kuppuswamy, Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 14/26] ACPI: tables: Add multiprocessor wake-up support Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 15/26] x86/boot: Add a trampoline for APs booting in 64-bit mode Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 16/26] x86/boot: Avoid #VE during compressed boot for TDX platforms Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 17/26] x86/boot: Avoid unnecessary #VE during boot process Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 18/26] x86/topology: Disable CPU hotplug support for TDX platforms Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 19/26] x86/tdx: Forcefully disable legacy PIC for TDX guests Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 20/26] x86/tdx: Introduce INTEL_TDX_GUEST config option Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` Kuppuswamy Sathyanarayanan [this message]
2021-04-01 20:06     ` [RFC v1 21/26] x86/mm: Move force_dma_unencrypted() to common code Dave Hansen
2021-04-06 15:37       ` Kirill A. Shutemov
2021-04-06 16:11         ` Dave Hansen
2021-04-06 16:37           ` Kirill A. Shutemov
2021-02-05 23:38   ` [RFC v1 22/26] x86/tdx: Exclude Shared bit from __PHYSICAL_MASK Kuppuswamy Sathyanarayanan
2021-04-01 20:13     ` Dave Hansen
2021-04-06 15:54       ` Kirill A. Shutemov
2021-04-06 16:12         ` Dave Hansen
2021-02-05 23:38   ` [RFC v1 23/26] x86/tdx: Make pages shared in ioremap() Kuppuswamy Sathyanarayanan
2021-04-01 20:26     ` Dave Hansen
2021-04-06 16:00       ` Kirill A. Shutemov
2021-04-06 16:14         ` Dave Hansen
2021-02-05 23:38   ` [RFC v1 24/26] x86/tdx: Add helper to do MapGPA TDVMALL Kuppuswamy Sathyanarayanan
2021-02-05 23:38   ` [RFC v1 25/26] x86/tdx: Make DMA pages shared Kuppuswamy Sathyanarayanan
2021-04-01 21:01     ` Dave Hansen
2021-04-06 16:31       ` Kirill A. Shutemov
2021-04-06 16:38         ` Dave Hansen
2021-04-06 17:16           ` Sean Christopherson
2021-02-05 23:38   ` [RFC v1 26/26] x86/kvm: Use bounce buffers for TD guest Kuppuswamy Sathyanarayanan
2021-04-01 21:17     ` Dave Hansen
2021-03-31 21:38   ` [RFC v1 00/26] Add TDX Guest Support Kuppuswamy, Sathyanarayanan
2021-04-02  0:02   ` Dave Hansen
2021-04-02  2:48     ` Andi Kleen
2021-04-02 15:27       ` Dave Hansen
2021-04-02 21:32         ` Andi Kleen
2021-04-03 16:26           ` Dave Hansen
2021-04-03 17:28             ` Andi Kleen
2021-04-04 15:02   ` Dave Hansen
2021-04-12 17:24     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=444fe9c7c035417f6abc3e0be2a4861cb573ab28.1612563142.git.sathyanarayanan.kuppuswamy@linux.intel.com \
    --to=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=ak@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=knsathya@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.