All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com,
	qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata
Date: Thu, 23 Jul 2020 15:18:54 -0500	[thread overview]
Message-ID: <445af8f9-2749-480a-09dd-572172653f47@redhat.com> (raw)
In-Reply-To: <20743b55-8eeb-3cac-86db-eab8c2bcd4ea@redhat.com>

On 7/23/20 2:42 PM, Eric Blake wrote:
> On 7/17/20 3:14 AM, Andrey Shinkevich wrote:
>> Add dirty bitmap information to QCOW2 metadata dump in the 
>> qcow2_format.py.
>>

>>   block/qcow2.c                      |   2 +-
>>   docs/interop/qcow2.txt             |   2 +-
>>   tests/qemu-iotests/qcow2.py        |  18 ++-
>>   tests/qemu-iotests/qcow2_format.py | 221 
>> ++++++++++++++++++++++++++++++++++---
>>   4 files changed, 220 insertions(+), 23 deletions(-)
> 
> I still don't see any obvious coverage of the new output, which makes it 
> harder to test (I have to manually run qcow2.py on a file rather than 
> seeing what changes in a ???.out file).  I know we said back in v9 that 
> test 291 is not the right test, but that does not stop you from adding a 
> new test just for that purpose.

The bulk of this series is touching a non-installed utility. At this 
point, I feel safer deferring it to 5.2 (it is a feature addition for 
testsuite use only, and we missed soft freeze), even though it has no 
negative impact to installed binaries.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2020-07-23 20:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17  8:14 [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 01/11] qcow2: Fix capitalization of header extension constant Andrey Shinkevich
2020-07-23 19:46   ` Eric Blake
2020-07-17  8:14 ` [PATCH v11 02/11] qcow2_format.py: make printable data an extension class member Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method Andrey Shinkevich
2020-07-28  9:39   ` Vladimir Sementsov-Ogievskiy
2020-07-17  8:14 ` [PATCH v11 04/11] qcow2_format.py: dump bitmap flags in human readable way Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 05/11] qcow2_format.py: Dump bitmap directory information Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 06/11] qcow2_format.py: pass cluster size to substructures Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 07/11] qcow2_format.py: Dump bitmap table serialized entries Andrey Shinkevich
2020-07-28 10:02   ` Vladimir Sementsov-Ogievskiy
2020-07-17  8:14 ` [PATCH v11 08/11] qcow2.py: Introduce '-j' key to dump in JSON format Andrey Shinkevich
2020-07-28 10:07   ` Vladimir Sementsov-Ogievskiy
2020-07-17  8:14 ` [PATCH v11 09/11] qcow2_format.py: collect fields " Andrey Shinkevich
2020-07-28 11:09   ` Vladimir Sementsov-Ogievskiy
2020-07-29  5:56     ` Andrey Shinkevich
2020-08-05  7:49       ` Vladimir Sementsov-Ogievskiy
2020-07-17  8:14 ` [PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class Andrey Shinkevich
2020-07-28 11:36   ` Vladimir Sementsov-Ogievskiy
2020-07-28 13:27     ` Andrey Shinkevich
2020-07-28 14:05       ` Vladimir Sementsov-Ogievskiy
2020-07-30 14:11     ` Andrey Shinkevich
2020-07-30 14:24     ` Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 11/11] qcow2_format.py: support dumping metadata in JSON format Andrey Shinkevich
2020-07-28 12:37   ` Vladimir Sementsov-Ogievskiy
2020-07-23 19:42 ` [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Eric Blake
2020-07-23 20:18   ` Eric Blake [this message]
2020-07-24 10:50     ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445af8f9-2749-480a-09dd-572172653f47@redhat.com \
    --to=eblake@redhat.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.