From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gao, Bin" Subject: RE: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask Date: Wed, 26 Apr 2017 16:42:02 +0000 Message-ID: <4460FA1017EA3844B646E90DA4E984057E358D94@ORSMSX112.amr.corp.intel.com> References: <3257d22879148692da6887f89843389bd37ee877.1493060870.git.sathyanarayanan.kuppuswamy@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com ([192.55.52.88]:56690 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdDZQmG (ORCPT ); Wed, 26 Apr 2017 12:42:06 -0400 In-Reply-To: Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij , Kuppuswamy Sathyanarayanan , Mika Westerberg , Andy Shevchenko Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sathyaosid@gmail.com" T24gV2VkLCBBcHJpbCAyNiwgMjAxNyBhdCA3OjI2IEFNLCBMaW51cyBXYWxsZWlqIHdyb3RlOg0K Pk9uIE1vbiwgQXByIDI0LCAyMDE3IGF0IDk6MTUgUE0sDQo+PHNhdGh5YW5hcmF5YW5hbi5rdXBw dXN3YW15QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6DQo+DQo+PiBGcm9tOiBLdXBwdXN3YW15IFNh dGh5YW5hcmF5YW5hbiANCj4+IDxzYXRoeWFuYXJheWFuYW4ua3VwcHVzd2FteUBsaW51eC5pbnRl bC5jb20+DQo+Pg0KPj4gQWNjb3JkaW5nIHRvIFdoaXNrZXkgQ292ZSBQTUlDIHNwZWMsIGJpdCA3 IG9mIEdQSU9JUlEwX1JFRyBiZWxvbmdzIHRvIA0KPj4gYmF0dGVyeSBJTy4gU28gd2Ugc2hvdWxk IHNraXAgdGhpcyBiaXQgd2hlbiBjaGVja2luZyBmb3IgR1BJTyBJUlEgDQo+PiBwZW5kaW5nIHN0 YXR1cy4gT3RoZXJ3aXNlLCB3Y292ZV9ncGlvX2lycV9oYW5kbGVyKCkgbWlnaHQgZ28gaW50byB0 aGUgDQo+PiBpbmZpbml0ZSBsb29wIHVudGlsIElSUSAicGVuZGluZyIgc3RhdHVzIGJlY29tZXMg MC4gVGhpcyBwYXRjaCBmaXhlcyB0aGlzIGlzc3VlLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEt1 cHB1c3dhbXkgU2F0aHlhbmFyYXlhbmFuIA0KPj4gPHNhdGh5YW5hcmF5YW5hbi5rdXBwdXN3YW15 QGxpbnV4LmludGVsLmNvbT4NCj4NCj5Mb29rcyBmaW5lIHRvIG1lLCB0ZW50YXRpdmVseSBhcHBs aWVkLg0KPg0KPkJpbiwgTWlrYSwgQW5keSwgT0s/DQo+DQo+WW91cnMsDQo+TGludXMgV2FsbGVp ag0KDQpMb29rcyByZWFzb25hYmxlIHRvIG1lLg0KDQpUaGFua3MsDQpCaW4NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932315AbdDZQmM (ORCPT ); Wed, 26 Apr 2017 12:42:12 -0400 Received: from mga01.intel.com ([192.55.52.88]:56690 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdDZQmG (ORCPT ); Wed, 26 Apr 2017 12:42:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,255,1488873600"; d="scan'208";a="94478861" From: "Gao, Bin" To: Linus Walleij , Kuppuswamy Sathyanarayanan , Mika Westerberg , Andy Shevchenko CC: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sathyaosid@gmail.com" Subject: RE: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask Thread-Topic: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask Thread-Index: AQHSvpkj8oCApvpW50ajEzeFH54eKqHX2gKQ Date: Wed, 26 Apr 2017 16:42:02 +0000 Message-ID: <4460FA1017EA3844B646E90DA4E984057E358D94@ORSMSX112.amr.corp.intel.com> References: <3257d22879148692da6887f89843389bd37ee877.1493060870.git.sathyanarayanan.kuppuswamy@linux.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3QGjkoU027250 On Wed, April 26, 2017 at 7:26 AM, Linus Walleij wrote: >On Mon, Apr 24, 2017 at 9:15 PM, > wrote: > >> From: Kuppuswamy Sathyanarayanan >> >> >> According to Whiskey Cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to >> battery IO. So we should skip this bit when checking for GPIO IRQ >> pending status. Otherwise, wcove_gpio_irq_handler() might go into the >> infinite loop until IRQ "pending" status becomes 0. This patch fixes this issue. >> >> Signed-off-by: Kuppuswamy Sathyanarayanan >> > >Looks fine to me, tentatively applied. > >Bin, Mika, Andy, OK? > >Yours, >Linus Walleij Looks reasonable to me. Thanks, Bin