From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28754C433EF for ; Wed, 8 Sep 2021 06:06:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E5F26113C for ; Wed, 8 Sep 2021 06:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347673AbhIHGHZ (ORCPT ); Wed, 8 Sep 2021 02:07:25 -0400 Received: from goliath.siemens.de ([192.35.17.28]:49603 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235478AbhIHGHW (ORCPT ); Wed, 8 Sep 2021 02:07:22 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 188661Yp012402 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Sep 2021 08:06:01 +0200 Received: from [167.87.38.78] ([167.87.38.78]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 188660hR002071; Wed, 8 Sep 2021 08:06:00 +0200 Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering To: Nishanth Menon Cc: Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bao Cheng Su , Chao Zeng References: <0dce149347353556e38a0bdf9a9489ffc9cf66d2.1631032682.git.jan.kiszka@siemens.com> <20210908024442.jskmqqye432p4nmt@gatherer> <674ccec8-c972-a32b-6722-922bf3c55abd@siemens.com> <20210908054844.7ym3flo6f2pryd2x@unplug> From: Jan Kiszka Message-ID: <448c6afe-0451-9927-8b8a-a9567cc03a92@siemens.com> Date: Wed, 8 Sep 2021 08:06:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210908054844.7ym3flo6f2pryd2x@unplug> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.09.21 07:48, Nishanth Menon wrote: > On 07:25-20210908, Jan Kiszka wrote: >> On 08.09.21 04:44, Nishanth Menon wrote: >>> On 18:37-20210907, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> This ensures that the SD card will remain mmc0 across devices with and >>>> without eMMC. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am65.dtsi | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi >>>> index a9fc1af03f27..785d931a2dd9 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi >>>> @@ -31,6 +31,8 @@ aliases { >>>> i2c4 = &main_i2c2; >>>> i2c5 = &main_i2c3; >>>> ethernet0 = &cpsw_port1; >>>> + mmc0 = &sdhci1; >>>> + mmc1 = &sdhci0; >>> >>> Jan, >>> >>> Responding in context of [1]. Suggestion from Aswath is to do the >>> following instead at SoC level: >>> + mmc0 = &sdhci0; >>> + mmc1 = &sdhci1; >>> >> >> Then I will leave this up to you and will go back to v1 of this patch >> (as we require it the other way around). > > Could you elaborate on the rationale as to why the other way around? > That would probably provide the reasoning to override the SoC generic > definitions in the board dts/dtsi as the exception case. > As I wrote in v1: We have deployed devices that use mmcblk0 == SD card in the field. Those should now be migrated to upstream kernel/DT, but ideally without glitches in the interface. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C51C433F5 for ; Wed, 8 Sep 2021 06:07:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F57361026 for ; Wed, 8 Sep 2021 06:07:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4F57361026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=A0RwKWeFqkHdqsCk63DoxOP5n1qzl71xvHZpGET34bc=; b=k/DWU0ruLLHbvsNX2IB1NbLX8D kI6UTAUj0KjxYqgIzHz+aqodZ8UsoeJ+yuC2rYMDAo9yHaAHZkB8idnjdbMb9llwgGw6j6rzCkUSi sj+Vr7gXDA93YW9S6s+s3BNM4qZbv0eAtWtELbikyrnM93FBGzGrlHhOp65aIGfjN/fafa4RH+1np 4t8BG+4xFMd6zW9p8YfTy+W/zgBJ7gX2j4B4lVsU4i2UG3XODwgCqkVZER+EZle7Bnp0B7/IrMhN1 AaY6akYKeRBWQAtOlLzibsmJRhG2bHg+jYAYiVcm2EtW6ALVnColrIsgLqdkuF7id3U1CHMhMOq8P 0Xs2DMaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNqir-005StE-71; Wed, 08 Sep 2021 06:06:13 +0000 Received: from goliath.siemens.de ([192.35.17.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNqik-005Sqx-B4 for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 06:06:10 +0000 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 188661Yp012402 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Sep 2021 08:06:01 +0200 Received: from [167.87.38.78] ([167.87.38.78]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 188660hR002071; Wed, 8 Sep 2021 08:06:00 +0200 Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65: Flip mmc device ordering To: Nishanth Menon Cc: Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bao Cheng Su , Chao Zeng References: <0dce149347353556e38a0bdf9a9489ffc9cf66d2.1631032682.git.jan.kiszka@siemens.com> <20210908024442.jskmqqye432p4nmt@gatherer> <674ccec8-c972-a32b-6722-922bf3c55abd@siemens.com> <20210908054844.7ym3flo6f2pryd2x@unplug> From: Jan Kiszka Message-ID: <448c6afe-0451-9927-8b8a-a9567cc03a92@siemens.com> Date: Wed, 8 Sep 2021 08:06:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210908054844.7ym3flo6f2pryd2x@unplug> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_230606_743426_30E08778 X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08.09.21 07:48, Nishanth Menon wrote: > On 07:25-20210908, Jan Kiszka wrote: >> On 08.09.21 04:44, Nishanth Menon wrote: >>> On 18:37-20210907, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> This ensures that the SD card will remain mmc0 across devices with and >>>> without eMMC. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am65.dtsi | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi >>>> index a9fc1af03f27..785d931a2dd9 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi >>>> @@ -31,6 +31,8 @@ aliases { >>>> i2c4 = &main_i2c2; >>>> i2c5 = &main_i2c3; >>>> ethernet0 = &cpsw_port1; >>>> + mmc0 = &sdhci1; >>>> + mmc1 = &sdhci0; >>> >>> Jan, >>> >>> Responding in context of [1]. Suggestion from Aswath is to do the >>> following instead at SoC level: >>> + mmc0 = &sdhci0; >>> + mmc1 = &sdhci1; >>> >> >> Then I will leave this up to you and will go back to v1 of this patch >> (as we require it the other way around). > > Could you elaborate on the rationale as to why the other way around? > That would probably provide the reasoning to override the SoC generic > definitions in the board dts/dtsi as the exception case. > As I wrote in v1: We have deployed devices that use mmcblk0 == SD card in the field. Those should now be migrated to upstream kernel/DT, but ideally without glitches in the interface. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel