From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 05/14] sh_eth: remove useless serialization in sh_eth_get_link_ksettings() Date: Fri, 6 Jul 2018 22:06:44 +0300 Message-ID: <44976f40-3004-e532-1980-78d473088f18@cogentembedded.com> References: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com> <20180704081451.7482-1-vladimir_zapolskiy@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , Geert Uytterhoeven , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org To: Vladimir Zapolskiy , "David S . Miller" Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:37410 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932751AbeGFTGr (ORCPT ); Fri, 6 Jul 2018 15:06:47 -0400 Received: by mail-wm0-f68.google.com with SMTP id n17-v6so15371552wmh.2 for ; Fri, 06 Jul 2018 12:06:46 -0700 (PDT) In-Reply-To: <20180704081451.7482-1-vladimir_zapolskiy@mentor.com> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 07/04/2018 11:14 AM, Vladimir Zapolskiy wrote: > phy_ethtool_ksettings_get() call does not modify device state or device > driver state, hence there is no need to utilize a driver specific > spinlock. > > Signed-off-by: Vladimir Zapolskiy [...] Reviewed-by: Sergei Shtylyov MBR, Sergei