From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Fri, 1 Jun 2018 10:07:35 +0200
Subject: [U-Boot] [PATCH] spi: cadence_qspi: Fix warning cast from
 pointer to integer of different size
In-Reply-To: <1525686177-49276-3-git-send-email-ley.foon.tan@intel.com>
References: <1525686177-49276-1-git-send-email-ley.foon.tan@intel.com>
 <1525686177-49276-3-git-send-email-ley.foon.tan@intel.com>
Message-ID: <449c740a-c6a2-2b8c-e8dc-58e78ad09fec@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

On 05/07/2018 11:42 AM, Ley Foon Tan wrote:
> Cast to ulong data type.
> 
> Compilation warning as below:
> 
>   CC      spl/drivers/spi/cadence_qspi_apb.o
>   LD      spl/lib/built-in.o
> drivers/spi/cadence_qspi_apb.c: In function ‘cadence_qspi_apb_indirect_write_setup’:
> drivers/spi/cadence_qspi_apb.c:696:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>           cmdlen, (unsigned int)cmdbuf);
> 
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
>  drivers/spi/cadence_qspi_apb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c
> index aa3a9ff..5bef0ae 100644
> --- a/drivers/spi/cadence_qspi_apb.c
> +++ b/drivers/spi/cadence_qspi_apb.c
> @@ -692,8 +692,8 @@ int cadence_qspi_apb_indirect_write_setup(struct cadence_spi_platdata *plat,
>  	unsigned int addr_bytes = cmdlen > 4 ? 4 : 3;
>  
>  	if (cmdlen < 4 || cmdbuf == NULL) {
> -		printf("QSPI: iInvalid input argument, len %d cmdbuf 0x%08x\n",
> -		       cmdlen, (unsigned int)cmdbuf);
> +		printf("QSPI: Invalid input argument, len %d cmdbuf 0x%08lx\n",
> +		       cmdlen, (unsigned long)cmdbuf);

%p ?

>  		return -EINVAL;
>  	}
>  	/* Setup the indirect trigger address */
> 


-- 
Best regards,
Marek Vasut