All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: "Shaohua Li" <shaohua.li@intel.com>
Cc: "Rajesh Shah" <rajesh.shah@intel.com>, "Greg KH" <greg@kroah.com>,
	"arjan" <arjan@linux.intel.com>, "Andrew Morton" <akpm@osdl.org>,
	"Tigran Aivazian" <tigran@veritas.com>,
	"lkml" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]microcode update driver rewrite - takes 2
Date: Thu, 29 Jun 2006 11:03:43 +0200	[thread overview]
Message-ID: <44A3B38F.76E4.0078.0@novell.com> (raw)
In-Reply-To: <1151569119.21189.106.camel@sli10-desk.sh.intel.com>

I'm not having a problem removing the messages if the current state can be obtained
elsewhere.

Looking at the patch I see at least one problem (in more than one place) - before
accessing data, you should check that the relevant piece to be read is entirely within
range. You should not (as done at least once) rely on copy_from_user() failing - the
data may be readable, but out of bounds wrt. the information in the headers (or the
header sizes themselves).

Jan



  reply	other threads:[~2006-06-29  9:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-27  2:51 [PATCH]microcode update driver rewrite - takes 2 Shaohua Li
2006-06-27  6:02 ` Greg KH
2006-06-27  8:15   ` Shaohua Li
2006-06-29  8:18     ` Shaohua Li
2006-06-29  9:03       ` Jan Beulich [this message]
2006-06-29  9:15         ` Shaohua Li
2006-06-29  9:40           ` Jan Beulich
2006-06-27  8:15   ` Shaohua Li
2006-06-27  8:15   ` Shaohua Li
2006-06-27 17:30     ` Randy.Dunlap
2006-06-28 12:16   ` Tigran Aivazian
2007-02-14 10:41 ` Alex Riesen
2006-06-27  8:14 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A3B38F.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=akpm@osdl.org \
    --cc=arjan@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rajesh.shah@intel.com \
    --cc=shaohua.li@intel.com \
    --cc=tigran@veritas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.