All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henne <henne@nachtwindheim.de>
To: gregkh@suse.de
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: [PATCH] Change pci_module_init from macro to inline function marked as deprecated
Date: Tue, 15 Aug 2006 11:03:30 +0200	[thread overview]
Message-ID: <44E18DE2.8020700@nachtwindheim.de> (raw)

From: Henrik Kretzschmar <henne@nachtwindheim.de>

Replaces the pci_module_init()-macro with a inline function,
which is marked as deprecated.
This gives a warning at compile time, which may be useful for driver developers who still use
pci_module_init() on 2.6 drivers.

Signed-of-by: Henrik Kretzschmar <henne@nachtwindheim.de>

---

--- linux-2.6.18-rc4/include/linux/pci.h	2006-08-11 10:10:08.000000000 +0200
+++ linux/include/linux/pci.h	2006-08-11 15:04:21.000000000 +0200
@@ -384,12 +384,6 @@
 	.vendor = PCI_ANY_ID, .device = PCI_ANY_ID, \
 	.subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID
 
-/*
- * pci_module_init is obsolete, this stays here till we fix up all usages of it
- * in the tree.
- */
-#define pci_module_init	pci_register_driver
-
 /* these external functions are only available when PCI support is enabled */
 #ifdef CONFIG_PCI
 
@@ -547,6 +541,16 @@
 	return __pci_register_driver(driver, THIS_MODULE);
 }
 
+/*
+ * pci_module_init is obsolete, this stays here till we fix up all usages of it
+ * in the tree.
+ */
+
+static inline int __deprecated pci_module_init(struct pci_driver* drv)
+{
+	return pci_register_driver(drv);
+}
+
 void pci_unregister_driver(struct pci_driver *);
 void pci_remove_behind_bridge(struct pci_dev *);
 struct pci_driver *pci_dev_driver(const struct pci_dev *);



WARNING: multiple messages have this Message-ID (diff)
From: Henne <henne@nachtwindheim.de>
To: gregkh@suse.de
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: [KJ] [PATCH] Change pci_module_init from macro to inline function
Date: Tue, 15 Aug 2006 09:03:30 +0000	[thread overview]
Message-ID: <44E18DE2.8020700@nachtwindheim.de> (raw)

From: Henrik Kretzschmar <henne@nachtwindheim.de>

Replaces the pci_module_init()-macro with a inline function,
which is marked as deprecated.
This gives a warning at compile time, which may be useful for driver developers who still use
pci_module_init() on 2.6 drivers.

Signed-of-by: Henrik Kretzschmar <henne@nachtwindheim.de>

---

--- linux-2.6.18-rc4/include/linux/pci.h	2006-08-11 10:10:08.000000000 +0200
+++ linux/include/linux/pci.h	2006-08-11 15:04:21.000000000 +0200
@@ -384,12 +384,6 @@
 	.vendor = PCI_ANY_ID, .device = PCI_ANY_ID, \
 	.subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID
 
-/*
- * pci_module_init is obsolete, this stays here till we fix up all usages of it
- * in the tree.
- */
-#define pci_module_init	pci_register_driver
-
 /* these external functions are only available when PCI support is enabled */
 #ifdef CONFIG_PCI
 
@@ -547,6 +541,16 @@
 	return __pci_register_driver(driver, THIS_MODULE);
 }
 
+/*
+ * pci_module_init is obsolete, this stays here till we fix up all usages of it
+ * in the tree.
+ */
+
+static inline int __deprecated pci_module_init(struct pci_driver* drv)
+{
+	return pci_register_driver(drv);
+}
+
 void pci_unregister_driver(struct pci_driver *);
 void pci_remove_behind_bridge(struct pci_dev *);
 struct pci_driver *pci_dev_driver(const struct pci_dev *);


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2006-08-15  9:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-15  9:03 Henne [this message]
2006-08-15  9:03 ` [KJ] [PATCH] Change pci_module_init from macro to inline function Henne
2006-08-15  9:42 ` [PATCH] Change pci_module_init from macro to inline function marked as deprecated Arjan van de Ven
2006-08-15  9:42   ` [KJ] [PATCH] Change pci_module_init from macro to inline Arjan van de Ven
2006-08-15  9:48   ` [PATCH] Change pci_module_init from macro to inline function marked as deprecated Henne
2006-08-15  9:48     ` [KJ] [PATCH] Change pci_module_init from macro to inline Henne
2006-08-15 19:37 ` [PATCH] Change pci_module_init from macro to inline function marked as deprecated Greg KH
2006-08-15 19:37   ` [KJ] [PATCH] Change pci_module_init from macro to inline Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44E18DE2.8020700@nachtwindheim.de \
    --to=henne@nachtwindheim.de \
    --cc=gregkh@suse.de \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.