From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0273CC636D7 for ; Thu, 23 Feb 2023 10:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233092AbjBWK32 (ORCPT ); Thu, 23 Feb 2023 05:29:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233390AbjBWK32 (ORCPT ); Thu, 23 Feb 2023 05:29:28 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09E902B634 for ; Thu, 23 Feb 2023 02:29:26 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id l2-20020a05600c1d0200b003e1f6dff952so9736784wms.1 for ; Thu, 23 Feb 2023 02:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MKc6y021FHBN+LrR2vkeYuDgxpGOSK9TOESkAOOS40g=; b=MSle8iSbfDKnGj+DESFAgoxCe7S1XWAzXDqXieuC2nduiLZtUbpte2AAM7V5Q2WJ7C 3M7MtTxqzcWoSOW3Gb2NlBoYXOZVwl9P269yiCLckSBxg/zxybz5Jr9W00ZYf4UpmqPA rSD7OkH2aMUPXgJjduf0nE5K3xZksEFRZ81NY+pR3a1U+zaMQk+ko0GZz/jJDPOmBLu+ ocJwnczeXPqyKUGt6ywnHCuwRQGc8wZtlsjlip3jqHIexlB07we2vgF835BdMU6JOF1D cVKrctmZxTJXCUOU043OHyFXyP3HEl+hN3W1oyi0kk+IV/tKAckfMJwY1++9V2GDamai zyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MKc6y021FHBN+LrR2vkeYuDgxpGOSK9TOESkAOOS40g=; b=EGtk1q4dFPTSBg6monIdpw0NvWwqpmOZr44qiLJufHeNEncABPJGe4OP3LtXIIFQPr +WFRyF/2Bax4+ahIEEVA9suEe+OMiOj7El0/HhKBCtq7QzceLspNL0dgaQMnjC6Gy6p+ lhjVxTmHeF0kW5HoLmMMtPoetgMnA5ZnZGe9xKg1HnyhwS11C/idAyEoFOh9I8tW40l/ vY2xCy+f2p1Iu+fge1grH8nzNzdR/DFpERZy7nbead3EgNhNmYj5FUFc6U2Ruhbu+/EW JKcDhJsteqWJZj1uBfbYUygRvnFRxwOAwZbXD0bGdtzo89qMpgjCXpDQCwSp9tzZlM3d BGXg== X-Gm-Message-State: AO0yUKWBbtfLMSgsZM9bpoV+xCzuzh0McuAMjZbVnA0zGGwYCUYCgUnZ gZT97Q6y9SlxLeQy4vtiZDR22g== X-Google-Smtp-Source: AK7set/DuYj5W4k5F3QFJwDnJAJ3FKK5euZhS7JWUpdW8R6uN/+e1dKH4fcozE/UQmRBX+gaCwo5aw== X-Received: by 2002:a05:600c:6001:b0:3e7:772d:22de with SMTP id az1-20020a05600c600100b003e7772d22demr6847506wmb.30.1677148164513; Thu, 23 Feb 2023 02:29:24 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id m17-20020a05600c3b1100b003e896d953a8sm6516457wms.17.2023.02.23.02.29.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 02:29:23 -0800 (PST) Message-ID: <44a59ea4-da6e-e96a-5e89-dfd41db72823@linaro.org> Date: Thu, 23 Feb 2023 10:29:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 08/26] gunyah: rsc_mgr: Add resource manager RPC core Content-Language: en-US To: Elliot Berman , Alex Elder , Prakruthi Deepak Heragu Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Bagas Sanjaya , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230214211229.3239350-1-quic_eberman@quicinc.com> <20230214212327.3310128-1-quic_eberman@quicinc.com> <94ebe2f0-0baf-21c0-45d5-c5bc4df9ad94@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <94ebe2f0-0baf-21c0-45d5-c5bc4df9ad94@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 22/02/2023 23:18, Elliot Berman wrote: >>> >>> +EXPORT_SYMBOL_GPL(gh_rm_notifier_unregister); >>> + >>> +void get_gh_rm(struct gh_rm *rm) >>> +{ >>> +    get_device(rm->dev); >>> +} >>> +EXPORT_SYMBOL_GPL(get_gh_rm); >> >> Can we have some consistency in the exported symbol naming, >> we have two combinations now. >> >> EXPORT_SYMBOL_GPL(gh_rm_notifier_register); >> EXPORT_SYMBOL_GPL(get_gh_rm); >> >> lets stick to one. > > done. > >>> + >>> +void put_gh_rm(struct gh_rm *rm) >>> +{ >>> +    put_device(rm->dev); >>> +} >>> +EXPORT_SYMBOL_GPL(put_gh_rm); >>> >> ... >> >>> + >>> +static int gh_rm_drv_probe(struct platform_device *pdev) >>> +{ >>> +    struct gh_msgq_tx_data *msg; >>> +    struct gh_rm *rm; >>> +    int ret; >>> + >> How are we ensuring that gunyah driver is probed before this driver? >> >> > > Which driver? Am referring to gunyah.ko TBH, gunyah.c should be merged as part of resource manager, and check if uuids and features in probe before proceeding further. -srini > >>> +    rm = devm_kzalloc(&pdev->dev, sizeof(*rm), GFP_KERNEL); >>> +    if (!rm) >>> +        return -ENOMEM; >>> + >>> +    platform_set_drvdata(pdev, rm); >>> +    rm->dev = &pdev->dev; >>> + >>> +    mutex_init(&rm->call_idr_lock); >>> +    idr_init(&rm->call_idr); >>> +    rm->cache = kmem_cache_create("gh_rm", struct_size(msg, data, >>> GH_MSGQ_MAX_MSG_SIZE), 0, >>> +        SLAB_HWCACHE_ALIGN, NULL); >>> +    if (!rm->cache) >>> +        return -ENOMEM; >> new line here would be nice. >> > > done. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CF6DC61DA4 for ; Thu, 23 Feb 2023 10:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZmzrpY/fYkFBd8l3DBXuEPHgQBu09jglr3mVv3jIc3I=; b=RTJsGGqoW/FLbf b1Q9ZswDD2JWdzRT+/CpYwv87IJuZKaQJEyeTq1gbWhp1U696XKisyS/xiRdKJsr0dfmlgTtCyA2n VE5RwmrXeFy2fzZtbylPvVw+3VEQvictdhWuMStn72IgmzzRMJIuxRKWdZgo5hDd6dmvxrt/r1GkT t9UuaVb0BAJDhygu9BhYRFxba+I3nPifrrCBywKqPbsCGDb1xu7Hs0amlM5Cact1TmFaa9UhELbvh P8iV1lcLMCe0G3r1IQ2R5Mp7ixU7tpeUJhcnfSg+w7ltQrmoNbkJ/dIQ0f6Pg0uPL1/B883ZhZiBn VA0ILvR9+Yg+MeKckKEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV8qx-00FxLO-76; Thu, 23 Feb 2023 10:29:31 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV8qu-00FxJo-CF for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2023 10:29:29 +0000 Received: by mail-wm1-x335.google.com with SMTP id k14-20020a05600c1c8e00b003e22107b7ccso2656404wms.0 for ; Thu, 23 Feb 2023 02:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MKc6y021FHBN+LrR2vkeYuDgxpGOSK9TOESkAOOS40g=; b=MSle8iSbfDKnGj+DESFAgoxCe7S1XWAzXDqXieuC2nduiLZtUbpte2AAM7V5Q2WJ7C 3M7MtTxqzcWoSOW3Gb2NlBoYXOZVwl9P269yiCLckSBxg/zxybz5Jr9W00ZYf4UpmqPA rSD7OkH2aMUPXgJjduf0nE5K3xZksEFRZ81NY+pR3a1U+zaMQk+ko0GZz/jJDPOmBLu+ ocJwnczeXPqyKUGt6ywnHCuwRQGc8wZtlsjlip3jqHIexlB07we2vgF835BdMU6JOF1D cVKrctmZxTJXCUOU043OHyFXyP3HEl+hN3W1oyi0kk+IV/tKAckfMJwY1++9V2GDamai zyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MKc6y021FHBN+LrR2vkeYuDgxpGOSK9TOESkAOOS40g=; b=PJwHY3SkIf4bq57kA9fgnMpN8FQEiK4eTSyq3MzvmP1Cy7MXyCKvinhXE1jvve2KbC AfZcTkFPO5ekpUP5wOJSoqtjtb2F4DenaZZSCcazrsmWXl/uWMz5rXGmIix/dE9jUn2A MctZdGYOsnvCh7E2f3Lod2oaS4eLwEhG8SMazn2Inan0MuhGEttKSlrLzOgXKFwp0xlj KtoOqgH+B/hxv56LdVrOeUwt2uEePkbOY6t5rZsvhjXuj5lhTHqOXOgcKxnkL8eyWElm 1QFzVJC6aGU6nY4ToJ9RLh96L3H0F1RcA6Q4yzxFzFfZWtyRd+R7TX85GYLcYWYKCpsS GMGA== X-Gm-Message-State: AO0yUKX4DYdK9iFnQhiEa5/MVqaRks5DrXlDGjqzvTESLw5yEQzXAiJC JS49bp6MgB369/iQBFezrV3OQw== X-Google-Smtp-Source: AK7set/DuYj5W4k5F3QFJwDnJAJ3FKK5euZhS7JWUpdW8R6uN/+e1dKH4fcozE/UQmRBX+gaCwo5aw== X-Received: by 2002:a05:600c:6001:b0:3e7:772d:22de with SMTP id az1-20020a05600c600100b003e7772d22demr6847506wmb.30.1677148164513; Thu, 23 Feb 2023 02:29:24 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id m17-20020a05600c3b1100b003e896d953a8sm6516457wms.17.2023.02.23.02.29.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 02:29:23 -0800 (PST) Message-ID: <44a59ea4-da6e-e96a-5e89-dfd41db72823@linaro.org> Date: Thu, 23 Feb 2023 10:29:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 08/26] gunyah: rsc_mgr: Add resource manager RPC core Content-Language: en-US To: Elliot Berman , Alex Elder , Prakruthi Deepak Heragu Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Bagas Sanjaya , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230214211229.3239350-1-quic_eberman@quicinc.com> <20230214212327.3310128-1-quic_eberman@quicinc.com> <94ebe2f0-0baf-21c0-45d5-c5bc4df9ad94@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <94ebe2f0-0baf-21c0-45d5-c5bc4df9ad94@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230223_022928_462495_C32D2F2E X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMi8wMi8yMDIzIDIzOjE4LCBFbGxpb3QgQmVybWFuIHdyb3RlOgo+Pj4KPj4+ICtFWFBP UlRfU1lNQk9MX0dQTChnaF9ybV9ub3RpZmllcl91bnJlZ2lzdGVyKTsKPj4+ICsKPj4+ICt2b2lk IGdldF9naF9ybShzdHJ1Y3QgZ2hfcm0gKnJtKQo+Pj4gK3sKPj4+ICvCoMKgwqAgZ2V0X2Rldmlj ZShybS0+ZGV2KTsKPj4+ICt9Cj4+PiArRVhQT1JUX1NZTUJPTF9HUEwoZ2V0X2doX3JtKTsKPj4K Pj4gQ2FuIHdlIGhhdmUgc29tZSBjb25zaXN0ZW5jeSBpbiB0aGUgZXhwb3J0ZWQgc3ltYm9sIG5h bWluZywKPj4gd2UgaGF2ZSB0d28gY29tYmluYXRpb25zIG5vdy4KPj4KPj4gRVhQT1JUX1NZTUJP TF9HUEwoZ2hfcm1fbm90aWZpZXJfcmVnaXN0ZXIpOwo+PiBFWFBPUlRfU1lNQk9MX0dQTChnZXRf Z2hfcm0pOwo+Pgo+PiBsZXRzIHN0aWNrIHRvIG9uZS4KPiAKPiBkb25lLgo+IAo+Pj4gKwo+Pj4g K3ZvaWQgcHV0X2doX3JtKHN0cnVjdCBnaF9ybSAqcm0pCj4+PiArewo+Pj4gK8KgwqDCoCBwdXRf ZGV2aWNlKHJtLT5kZXYpOwo+Pj4gK30KPj4+ICtFWFBPUlRfU1lNQk9MX0dQTChwdXRfZ2hfcm0p Owo+Pj4KPj4gLi4uCj4+Cj4+PiArCj4+PiArc3RhdGljIGludCBnaF9ybV9kcnZfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4+ICt7Cj4+PiArwqDCoMKgIHN0cnVjdCBnaF9t c2dxX3R4X2RhdGEgKm1zZzsKPj4+ICvCoMKgwqAgc3RydWN0IGdoX3JtICpybTsKPj4+ICvCoMKg wqAgaW50IHJldDsKPj4+ICsKPj4gSG93IGFyZSB3ZSBlbnN1cmluZyB0aGF0IGd1bnlhaCBkcml2 ZXIgaXMgcHJvYmVkIGJlZm9yZSB0aGlzIGRyaXZlcj8KPj4KPj4KPiAKPiBXaGljaCBkcml2ZXI/ CgpBbSByZWZlcnJpbmcgdG8gZ3VueWFoLmtvCgpUQkgsIGd1bnlhaC5jIHNob3VsZCBiZSBtZXJn ZWQgYXMgcGFydCBvZiByZXNvdXJjZSBtYW5hZ2VyLCBhbmQgY2hlY2sgaWYgCnV1aWRzIGFuZCBm ZWF0dXJlcyBpbiBwcm9iZSBiZWZvcmUgcHJvY2VlZGluZyBmdXJ0aGVyLgoKCi1zcmluaQoKPiAK Pj4+ICvCoMKgwqAgcm0gPSBkZXZtX2t6YWxsb2MoJnBkZXYtPmRldiwgc2l6ZW9mKCpybSksIEdG UF9LRVJORUwpOwo+Pj4gK8KgwqDCoCBpZiAoIXJtKQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVy biAtRU5PTUVNOwo+Pj4gKwo+Pj4gK8KgwqDCoCBwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCBy bSk7Cj4+PiArwqDCoMKgIHJtLT5kZXYgPSAmcGRldi0+ZGV2Owo+Pj4gKwo+Pj4gK8KgwqDCoCBt dXRleF9pbml0KCZybS0+Y2FsbF9pZHJfbG9jayk7Cj4+PiArwqDCoMKgIGlkcl9pbml0KCZybS0+ Y2FsbF9pZHIpOwo+Pj4gK8KgwqDCoCBybS0+Y2FjaGUgPSBrbWVtX2NhY2hlX2NyZWF0ZSgiZ2hf cm0iLCBzdHJ1Y3Rfc2l6ZShtc2csIGRhdGEsIAo+Pj4gR0hfTVNHUV9NQVhfTVNHX1NJWkUpLCAw LAo+Pj4gK8KgwqDCoMKgwqDCoMKgIFNMQUJfSFdDQUNIRV9BTElHTiwgTlVMTCk7Cj4+PiArwqDC oMKgIGlmICghcm0tPmNhY2hlKQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAtRU5PTUVNOwo+ PiBuZXcgbGluZSBoZXJlIHdvdWxkIGJlIG5pY2UuCj4+Cj4gCj4gZG9uZS4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK