All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	"Juergen Gross" <jgross@suse.com>,
	"Dario Faggioli" <dfaggioli@suse.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT
Date: Mon, 18 Jul 2022 12:48:14 +0200	[thread overview]
Message-ID: <44a6e983-59e1-b60d-c86f-db2a1747ddf7@suse.com> (raw)
In-Reply-To: <20220718071825.22113-6-andrew.cooper3@citrix.com>

On 18.07.2022 09:18, Andrew Cooper wrote:
> With the waitqueue logic updated to not use an absolute stack pointer
> reference, the vCPU can safely be resumed anywhere.
> 
> Remove VCPU_AFFINITY_WAIT completely, getting rid of two domain crashes,

I understand you mean two domain_crash() invocations here, but ...

> and a
> logical corner case where resetting the vcpu with an oustanding waitqueue
> would crash the domain.

... some other domain crash here?

> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

I assume you've checked thoroughly that calling code hasn't
grown dependencies on execution coming back on the same CPU?

Jan


  reply	other threads:[~2022-07-18 10:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18  7:18 [PATCH 0/5] xen/wait: Improvements Andrew Cooper
2022-07-18  7:18 ` [PATCH 1/5] xen/wait: Drop vestigial remnants of TRAP_regs_partial Andrew Cooper
2022-07-18  9:53   ` Jan Beulich
2022-07-18  7:18 ` [PATCH 2/5] xen/wait: Extend the description of how this logic actually works Andrew Cooper
2022-07-18 10:00   ` Jan Beulich
2022-07-18 10:11     ` Andrew Cooper
2022-07-18 10:49       ` Jan Beulich
2022-07-18  7:18 ` [PATCH 3/5] xen/wait: Minor asm improvements Andrew Cooper
2022-07-18 10:04   ` Jan Beulich
2022-07-18  7:18 ` [PATCH 4/5] xen/wait: Use relative stack adjustments Andrew Cooper
2022-07-18 10:29   ` Jan Beulich
2022-07-18 10:41     ` Andrew Cooper
2022-07-18 10:51       ` Jan Beulich
2022-07-18  7:18 ` [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT Andrew Cooper
2022-07-18 10:48   ` Jan Beulich [this message]
2022-07-18 11:16     ` Andrew Cooper
2022-07-18 11:11 ` [PATCH 0/5] xen/wait: Improvements Jan Beulich
2022-07-18 11:24   ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44a6e983-59e1-b60d-c86f-db2a1747ddf7@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dfaggioli@suse.com \
    --cc=jgross@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.