All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] configs/pcengines_apu2_defconfig: bump kernel to 5.16
@ 2022-01-16 20:15 Danilo Bargen
  2022-01-17 20:06 ` Giulio Benetti
  0 siblings, 1 reply; 4+ messages in thread
From: Danilo Bargen @ 2022-01-16 20:15 UTC (permalink / raw)
  To: buildroot

This fixes the compile errors that were present with the previous kernel
version (4.19).

Signed-off-by: Danilo Bargen <mail@dbrgn.ch>
---
 configs/pcengines_apu2_defconfig | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/configs/pcengines_apu2_defconfig
b/configs/pcengines_apu2_defconfig index 68cebb8f6a..eb30f6aee7 100644
--- a/configs/pcengines_apu2_defconfig
+++ b/configs/pcengines_apu2_defconfig
@@ -1,16 +1,26 @@
+# Architecture
 BR2_x86_64=y
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
-BR2_TARGET_GENERIC_HOSTNAME="apu2"
-BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
-BR2_SYSTEM_DHCP="eth0"
+
+# Kernel
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_16=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.16"
 BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
 BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/pcengines/apu2/linux.config"
+
+# Default hostname and TTY
+BR2_TARGET_GENERIC_HOSTNAME="apu2"
+BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
+
+# Networking
+BR2_SYSTEM_DHCP="eth0"
+
+# Rootfs
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_ISO9660=y
 BR2_TARGET_ROOTFS_ISO9660_BOOT_MENU="board/pcengines/apu2/isolinux.cfg"
 BR2_TARGET_ROOTFS_ISO9660_HYBRID=y
-# BR2_TARGET_ROOTFS_TAR is not set
+
+# Bootloader
 BR2_TARGET_SYSLINUX=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] configs/pcengines_apu2_defconfig: bump kernel to 5.16
  2022-01-16 20:15 [Buildroot] [PATCH 1/1] configs/pcengines_apu2_defconfig: bump kernel to 5.16 Danilo Bargen
@ 2022-01-17 20:06 ` Giulio Benetti
  2022-01-19 23:03   ` [Buildroot] [PATCH v2 " Danilo Bargen
  0 siblings, 1 reply; 4+ messages in thread
From: Giulio Benetti @ 2022-01-17 20:06 UTC (permalink / raw)
  To: Danilo Bargen, buildroot

Hi Danilo,

On 16/01/22 21:15, Danilo Bargen wrote:
> This fixes the compile errors that were present with the previous kernel
> version (4.19).

Is there a build failure log url that you can point?

I would also mention that you are refactoring defconfig file in commit log.

Thank you!
Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Signed-off-by: Danilo Bargen <mail@dbrgn.ch>
> ---
>   configs/pcengines_apu2_defconfig | 22 ++++++++++++++++------
>   1 file changed, 16 insertions(+), 6 deletions(-)
> 
> --
> 2.34.1
> 
> diff --git a/configs/pcengines_apu2_defconfig
> b/configs/pcengines_apu2_defconfig index 68cebb8f6a..eb30f6aee7 100644
> --- a/configs/pcengines_apu2_defconfig
> +++ b/configs/pcengines_apu2_defconfig
> @@ -1,16 +1,26 @@
> +# Architecture
>   BR2_x86_64=y
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
> -BR2_TARGET_GENERIC_HOSTNAME="apu2"
> -BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
> -BR2_SYSTEM_DHCP="eth0"
> +
> +# Kernel
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_16=y
>   BR2_LINUX_KERNEL=y
>   BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.16"
>   BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
>   BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/pcengines/apu2/linux.config"
> +
> +# Default hostname and TTY
> +BR2_TARGET_GENERIC_HOSTNAME="apu2"
> +BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
> +
> +# Networking
> +BR2_SYSTEM_DHCP="eth0"
> +
> +# Rootfs
>   BR2_TARGET_ROOTFS_EXT2=y
>   BR2_TARGET_ROOTFS_ISO9660=y
>   BR2_TARGET_ROOTFS_ISO9660_BOOT_MENU="board/pcengines/apu2/isolinux.cfg"
>   BR2_TARGET_ROOTFS_ISO9660_HYBRID=y
> -# BR2_TARGET_ROOTFS_TAR is not set
> +
> +# Bootloader
>   BR2_TARGET_SYSLINUX=y
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2 1/1] configs/pcengines_apu2_defconfig: bump kernel to 5.16
  2022-01-17 20:06 ` Giulio Benetti
@ 2022-01-19 23:03   ` Danilo Bargen
  2022-01-22 12:18     ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Danilo Bargen @ 2022-01-19 23:03 UTC (permalink / raw)
  To: buildroot

This fixes the compile errors that were present with the previous
kernel version (4.19):

https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084022

Additionally, the defconfig file was refactored: Configuration
values are now grouped logically, thus increasing readability and
maintainability.

Signed-off-by: Danilo Bargen <mail@dbrgn.ch>

---
Changes v1 -> v2:
  - improved commit message

Signed-off-by: Danilo Bargen <mail@dbrgn.ch>
---
 configs/pcengines_apu2_defconfig | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/configs/pcengines_apu2_defconfig b/configs/pcengines_apu2_defconfig
index 68cebb8f6a..eb30f6aee7 100644
--- a/configs/pcengines_apu2_defconfig
+++ b/configs/pcengines_apu2_defconfig
@@ -1,16 +1,26 @@
+# Architecture
 BR2_x86_64=y
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
-BR2_TARGET_GENERIC_HOSTNAME="apu2"
-BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
-BR2_SYSTEM_DHCP="eth0"
+
+# Kernel
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_16=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.16"
 BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
 BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/pcengines/apu2/linux.config"
+
+# Default hostname and TTY
+BR2_TARGET_GENERIC_HOSTNAME="apu2"
+BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
+
+# Networking
+BR2_SYSTEM_DHCP="eth0"
+
+# Rootfs
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_ISO9660=y
 BR2_TARGET_ROOTFS_ISO9660_BOOT_MENU="board/pcengines/apu2/isolinux.cfg"
 BR2_TARGET_ROOTFS_ISO9660_HYBRID=y
-# BR2_TARGET_ROOTFS_TAR is not set
+
+# Bootloader
 BR2_TARGET_SYSLINUX=y
--
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2 1/1] configs/pcengines_apu2_defconfig: bump kernel to 5.16
  2022-01-19 23:03   ` [Buildroot] [PATCH v2 " Danilo Bargen
@ 2022-01-22 12:18     ` Thomas Petazzoni
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2022-01-22 12:18 UTC (permalink / raw)
  To: Danilo Bargen; +Cc: buildroot

On Thu, 20 Jan 2022 00:03:30 +0100
Danilo Bargen <mail@dbrgn.ch> wrote:

> This fixes the compile errors that were present with the previous
> kernel version (4.19):
> 
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1970084022
> 
> Additionally, the defconfig file was refactored: Configuration
> values are now grouped logically, thus increasing readability and
> maintainability.
> 
> Signed-off-by: Danilo Bargen <mail@dbrgn.ch>

Applied to master, with one change. See below.

> +# Rootfs
>  BR2_TARGET_ROOTFS_EXT2=y
>  BR2_TARGET_ROOTFS_ISO9660=y
>  BR2_TARGET_ROOTFS_ISO9660_BOOT_MENU="board/pcengines/apu2/isolinux.cfg"
>  BR2_TARGET_ROOTFS_ISO9660_HYBRID=y
> -# BR2_TARGET_ROOTFS_TAR is not set

Not clear why you dropped this line. So I re-added it.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-22 12:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-16 20:15 [Buildroot] [PATCH 1/1] configs/pcengines_apu2_defconfig: bump kernel to 5.16 Danilo Bargen
2022-01-17 20:06 ` Giulio Benetti
2022-01-19 23:03   ` [Buildroot] [PATCH v2 " Danilo Bargen
2022-01-22 12:18     ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.