From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49C2EC433FE for ; Sat, 29 Oct 2022 09:06:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oohmX-0006JD-Kk; Sat, 29 Oct 2022 05:05:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oohlr-00063n-Mg for qemu-devel@nongnu.org; Sat, 29 Oct 2022 05:04:56 -0400 Received: from mail.weilnetz.de ([37.120.169.71] helo=mail.v2201612906741603.powersrv.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oohlp-0000aQ-PS for qemu-devel@nongnu.org; Sat, 29 Oct 2022 05:04:51 -0400 Received: from [192.168.178.59] (p5b151d14.dip0.t-ipconnect.de [91.21.29.20]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.v2201612906741603.powersrv.de (Postfix) with ESMTPSA id D0ECFDA0C54; Sat, 29 Oct 2022 11:04:45 +0200 (CEST) Message-ID: <44dd6a20-f49d-b290-3ff1-346511fd862f@weilnetz.de> Date: Sat, 29 Oct 2022 11:04:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables To: Bin Meng , qemu-devel@nongnu.org Cc: Bin Meng , Cleber Rosa , John Snow , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= References: <20220908132817.1831008-1-bmeng.cn@gmail.com> <20220908132817.1831008-4-bmeng.cn@gmail.com> In-Reply-To: <20220908132817.1831008-4-bmeng.cn@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=37.120.169.71; envelope-from=stefan.weil@weilnetz.de; helo=mail.v2201612906741603.powersrv.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Reply-to: Stefan Weil From: Stefan Weil via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 08.09.22 um 15:28 schrieb Bin Meng: > From: Bin Meng > > At present packaging the required DLLs of QEMU executables is a > manual process, and error prone. > > Actually build/config-host.mak contains a GLIB_BINDIR variable > which is the directory where glib and other DLLs reside. This > works for both Windows native build and cross-build on Linux. > We can use it as the search directory for DLLs and automate > the whole DLL packaging process. > > Signed-off-by: Bin Meng > --- Thank you, that is really helpful to avoid broken installers because of missing DLL files. Tested-by: Stefan Weil