From: Eddie James <eajames@linux.ibm.com>
To: Joel Stanley <joel@jms.id.au>, Jeremy Kerr <jk@ozlabs.org>,
Alistar Popple <alistair@popple.id.au>,
Amitay Isaacs <amitay@ozlabs.org>
Cc: linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] fsi: sbefifo: Use specified value of start of response timeout
Date: Mon, 24 Jan 2022 08:17:51 -0600 [thread overview]
Message-ID: <44deb918-2527-7fcd-29de-f09534b0837b@linux.ibm.com> (raw)
In-Reply-To: <20220121053816.82253-2-joel@jms.id.au>
On 1/20/22 23:38, Joel Stanley wrote:
> From: Amitay Isaacs <amitay@ozlabs.org>
>
> For some of the chip-ops where sbe needs to collect trace information,
> sbe can take a long time (>30s) to respond. Currently these chip-ops
> will timeout as the start of response timeout defaults to 10s.
>
> Instead of default value, use specified value. The require timeout
> value will be set using ioctl.
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Amitay Isaacs <amitay@ozlabs.org>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/fsi/fsi-sbefifo.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 52328adef643..1e9b326e8f67 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -125,6 +125,7 @@ struct sbefifo {
> bool dead;
> bool async_ffdc;
> bool timed_out;
> + u32 timeout_start_rsp_ms;
> };
>
> struct sbefifo_user {
> @@ -549,7 +550,7 @@ static int sbefifo_read_response(struct sbefifo *sbefifo, struct iov_iter *respo
>
> dev_vdbg(dev, "reading response, buflen = %zd\n", iov_iter_count(response));
>
> - timeout = msecs_to_jiffies(SBEFIFO_TIMEOUT_START_RSP);
> + timeout = msecs_to_jiffies(sbefifo->timeout_start_rsp_ms);
> for (;;) {
> /* Grab FIFO status (this will handle parity errors) */
> rc = sbefifo_wait(sbefifo, false, &status, timeout);
> @@ -972,6 +973,7 @@ static int sbefifo_probe(struct device *dev)
> sbefifo->fsi_dev = fsi_dev;
> dev_set_drvdata(dev, sbefifo);
> mutex_init(&sbefifo->lock);
> + sbefifo->timeout_start_rsp_ms = SBEFIFO_TIMEOUT_START_RSP;
>
> /*
> * Try cleaning up the FIFO. If this fails, we still register the
next prev parent reply other threads:[~2022-01-24 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 5:38 [PATCH v3 0/2] fsi: sbefifo: Add userspace timeout control Joel Stanley
2022-01-21 5:38 ` [PATCH v3 1/2] fsi: sbefifo: Use specified value of start of response timeout Joel Stanley
2022-01-24 14:17 ` Eddie James [this message]
2022-01-21 5:38 ` [PATCH v3 2/2] fsi: sbefifo: Implement FSI_SBEFIFO_READ_TIMEOUT_SECONDS ioctl Joel Stanley
2022-01-24 14:17 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44deb918-2527-7fcd-29de-f09534b0837b@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=alistair@popple.id.au \
--cc=amitay@ozlabs.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.