All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Simon Glass <sjg@chromium.org>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Tom Rini <trini@konsulko.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 3/4] efi: Correct display of table GUIDs
Date: Sun, 12 Nov 2023 17:53:19 +0100	[thread overview]
Message-ID: <44e30885-88c8-4a22-814e-77fcc9ee339d@gmx.de> (raw)
In-Reply-To: <20231112155808.135585-4-sjg@chromium.org>

On 11/12/23 16:58, Simon Glass wrote:
> The printf() %pU option decodes GUIDs so it is not necessary to do this
> first. Drop the incorrect code.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   cmd/efi_common.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/cmd/efi_common.c b/cmd/efi_common.c
> index f4056096cd3f..1aa2351fcdfd 100644
> --- a/cmd/efi_common.c
> +++ b/cmd/efi_common.c
> @@ -17,10 +17,8 @@ void efi_show_tables(struct efi_system_table *systab)
>
>   	for (i = 0; i < systab->nr_tables; i++) {
>   		struct efi_configuration_table *tab = &systab->tables[i];
> -		char guid_str[37];
>
> -		uuid_bin_to_str(tab->guid.b, guid_str, 1);
> -		printf("%p  %pUl  %s\n", tab->table, guid_str,
> +		printf("%p  %pUl  %s\n", tab->table, tab->guid.b,
>   		       uuid_guid_get_str(tab->guid.b) ?: "(unknown)");

Please, observe, that we have printf("%pUs", &guid) for printing the
text representation of a GUID. If the text representation is unknown, it
will print the numeric representation.

Best regards

Heinrich

>   	}
>   }


  reply	other threads:[~2023-11-12 16:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-12 15:58 [PATCH 0/4] efi: Minor improvements for the EFI app Simon Glass
2023-11-12 15:58 ` [PATCH 1/4] acpi: Use __packed with struct acpi_xsdt Simon Glass
2023-11-12 16:45   ` Heinrich Schuchardt
2023-11-12 20:01     ` Simon Glass
2023-11-12 15:58 ` [PATCH 2/4] efi: Collect the ACPI tables in the app Simon Glass
2023-11-12 16:22   ` Heinrich Schuchardt
2023-11-12 20:01     ` Simon Glass
2023-11-12 15:58 ` [PATCH 3/4] efi: Correct display of table GUIDs Simon Glass
2023-11-12 16:53   ` Heinrich Schuchardt [this message]
2023-11-12 20:01     ` Simon Glass
2023-11-12 15:58 ` [PATCH 4/4] efi: Avoid using dm_scan_other() Simon Glass
2023-11-12 18:03   ` Tom Rini
2023-11-12 19:19     ` Heinrich Schuchardt
2023-11-12 19:46       ` Tom Rini
2023-11-12 20:01       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44e30885-88c8-4a22-814e-77fcc9ee339d@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.