From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C2DC54E76 for ; Fri, 6 Jan 2023 09:54:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232034AbjAFJyc (ORCPT ); Fri, 6 Jan 2023 04:54:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjAFJy2 (ORCPT ); Fri, 6 Jan 2023 04:54:28 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B7A8645641; Fri, 6 Jan 2023 01:54:27 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2AFEF11FB; Fri, 6 Jan 2023 01:55:09 -0800 (PST) Received: from [10.57.45.115] (unknown [10.57.45.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4688B3F23F; Fri, 6 Jan 2023 01:54:25 -0800 (PST) Message-ID: <44e87647-d64e-ee24-0046-06bb15f5a1f4@arm.com> Date: Fri, 6 Jan 2023 09:54:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6 11/14] kernel: events: Export perf_report_aux_output_id() From: Suzuki K Poulose To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, Mark Rutland , Alexander Shishkin Cc: mathieu.poirier@linaro.org, leo.yan@linaro.org, quic_jinlmao@quicinc.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, Mike Leach , Adrian Hunter References: <20221123195010.6859-1-mike.leach@linaro.org> <20221123195010.6859-12-mike.leach@linaro.org> <9ea2a0d8-b025-bb56-3a04-1a88e340da2d@arm.com> In-Reply-To: <9ea2a0d8-b025-bb56-3a04-1a88e340da2d@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter, Ingo, Arnaldo On 13/12/2022 10:08, Suzuki K Poulose wrote: > Peter, > > On 24/11/2022 11:04, Suzuki Kuruppassery Poulose wrote: >> Peter >> >> >> On 23/11/2022 19:50, Mike Leach wrote: >>> CoreSight trace being updated to use the perf_report_aux_output_id() >>> in a similar way to intel-pt. >>> >>> This function in needs export visibility to allow it to be called from >>> kernel loadable modules, which CoreSight may configured to be built as. >>> >>> Signed-off-by: Mike Leach >>> Acked-by: Suzuki K Poulose >>> --- >>>   kernel/events/core.c | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/kernel/events/core.c b/kernel/events/core.c >>> index 4ec3717003d5..ad388552f1d5 100644 >>> --- a/kernel/events/core.c >>> +++ b/kernel/events/core.c >>> @@ -9231,6 +9231,7 @@ void perf_report_aux_output_id(struct >>> perf_event *event, u64 hw_id) >>>       perf_output_end(&handle); >>>   } >>> +EXPORT_SYMBOL_GPL(perf_report_aux_output_id); >> >> Are you happy with me picking up this change through the coresight >> tree ? >> >> Suzuki >> > > Please could you let me know your thoughts on this ? Coresight PMU would > use this to inform the dynamically allocated trace id for a CPU to the > perf via this HWID packet. > > If you are happy with the above change, I could pick it up via the > coresight tree with your Ack. Otherwise, please could you pick it > up ? > Please could you let us know if this is acceptable and if so, how can this be pushed ? CoreSight PMU (which can be built as a module) is using these packets to advertise the traceID allocated for a given CPU bound ETM (which is made dynamic due to the limited number of ids available). The perf tool can use these packets to then decode and separate the trace data from shared buffer. As of now, the series to enable the dynamic trace id allocation is blocked on this change. Kind regards Suzuki > Suzuki > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B143C5479D for ; Fri, 6 Jan 2023 09:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CL+07cgkUafXhwcvHlhsabG4HbxCd8lTu2OUJZOBZw0=; b=l9rRbMVF4ry1GL NS3uxbPOGyvff9vZw4efC38/G82mruVocV1oq+N318SCYblwGgfD/KkFndw69O6T/EF+lixJP4z/G 0QJ+v+3BwDaJdtdLBd4/HKSDLhV1Fjjpz/4doDPc3+fCTDOkF7oWRn9YUQoRDUEafokFwzpEhW6Oo L41aQG379XjJRq7JAA0oyDRKNlKfws/726MW1kCsEwkzN3reHRFBLFjIGKurM9kqMBc2Nz5ZDHkID e7RrYRsOApSWin6qIBnnjLULaui3XpDE/QxqKd7jzi0ejpKq/Pg/V73yWjCWdv8Hj0w8GMwz12aOb r852YDSxriXwfjlaW0Zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDjQr-007F4s-3I; Fri, 06 Jan 2023 09:54:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDjQn-007F1o-HA for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 09:54:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2AFEF11FB; Fri, 6 Jan 2023 01:55:09 -0800 (PST) Received: from [10.57.45.115] (unknown [10.57.45.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4688B3F23F; Fri, 6 Jan 2023 01:54:25 -0800 (PST) Message-ID: <44e87647-d64e-ee24-0046-06bb15f5a1f4@arm.com> Date: Fri, 6 Jan 2023 09:54:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6 11/14] kernel: events: Export perf_report_aux_output_id() From: Suzuki K Poulose To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, Mark Rutland , Alexander Shishkin Cc: mathieu.poirier@linaro.org, leo.yan@linaro.org, quic_jinlmao@quicinc.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, Mike Leach , Adrian Hunter References: <20221123195010.6859-1-mike.leach@linaro.org> <20221123195010.6859-12-mike.leach@linaro.org> <9ea2a0d8-b025-bb56-3a04-1a88e340da2d@arm.com> In-Reply-To: <9ea2a0d8-b025-bb56-3a04-1a88e340da2d@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_015433_643191_D830495C X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UGV0ZXIsIEluZ28sIEFybmFsZG8KCk9uIDEzLzEyLzIwMjIgMTA6MDgsIFN1enVraSBLIFBvdWxv c2Ugd3JvdGU6Cj4gUGV0ZXIsCj4gCj4gT24gMjQvMTEvMjAyMiAxMTowNCwgU3V6dWtpIEt1cnVw cGFzc2VyeSBQb3Vsb3NlIHdyb3RlOgo+PiBQZXRlcgo+Pgo+Pgo+PiBPbiAyMy8xMS8yMDIyIDE5 OjUwLCBNaWtlIExlYWNoIHdyb3RlOgo+Pj4gQ29yZVNpZ2h0IHRyYWNlIGJlaW5nIHVwZGF0ZWQg dG8gdXNlIHRoZSBwZXJmX3JlcG9ydF9hdXhfb3V0cHV0X2lkKCkKPj4+IGluIGEgc2ltaWxhciB3 YXkgdG8gaW50ZWwtcHQuCj4+Pgo+Pj4gVGhpcyBmdW5jdGlvbiBpbiBuZWVkcyBleHBvcnQgdmlz aWJpbGl0eSB0byBhbGxvdyBpdCB0byBiZSBjYWxsZWQgZnJvbQo+Pj4ga2VybmVsIGxvYWRhYmxl IG1vZHVsZXMsIHdoaWNoIENvcmVTaWdodCBtYXkgY29uZmlndXJlZCB0byBiZSBidWlsdCBhcy4K Pj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBNaWtlIExlYWNoIDxtaWtlLmxlYWNoQGxpbmFyby5vcmc+ Cj4+PiBBY2tlZC1ieTogU3V6dWtpIEsgUG91bG9zZSA8c3V6dWtpLnBvdWxvc2VAYXJtLmNvbT4K Pj4+IC0tLQo+Pj4gwqAga2VybmVsL2V2ZW50cy9jb3JlLmMgfCAxICsKPj4+IMKgIDEgZmlsZSBj aGFuZ2VkLCAxIGluc2VydGlvbigrKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9rZXJuZWwvZXZlbnRz L2NvcmUuYyBiL2tlcm5lbC9ldmVudHMvY29yZS5jCj4+PiBpbmRleCA0ZWMzNzE3MDAzZDUuLmFk Mzg4NTUyZjFkNSAxMDA2NDQKPj4+IC0tLSBhL2tlcm5lbC9ldmVudHMvY29yZS5jCj4+PiArKysg Yi9rZXJuZWwvZXZlbnRzL2NvcmUuYwo+Pj4gQEAgLTkyMzEsNiArOTIzMSw3IEBAIHZvaWQgcGVy Zl9yZXBvcnRfYXV4X291dHB1dF9pZChzdHJ1Y3QgCj4+PiBwZXJmX2V2ZW50ICpldmVudCwgdTY0 IGh3X2lkKQo+Pj4gwqDCoMKgwqDCoCBwZXJmX291dHB1dF9lbmQoJmhhbmRsZSk7Cj4+PiDCoCB9 Cj4+PiArRVhQT1JUX1NZTUJPTF9HUEwocGVyZl9yZXBvcnRfYXV4X291dHB1dF9pZCk7Cj4+Cj4+ IEFyZSB5b3UgaGFwcHkgd2l0aCBtZSBwaWNraW5nIHVwIHRoaXMgY2hhbmdlIHRocm91Z2ggdGhl IGNvcmVzaWdodCAgCj4+IHRyZWUgPwo+Pgo+PiBTdXp1a2kKPj4KPiAKPiBQbGVhc2UgY291bGQg eW91IGxldCBtZSBrbm93IHlvdXIgdGhvdWdodHMgb24gdGhpcyA/IENvcmVzaWdodCBQTVUgd291 bGQKPiB1c2UgdGhpcyB0byBpbmZvcm0gdGhlIGR5bmFtaWNhbGx5IGFsbG9jYXRlZCB0cmFjZSBp ZCBmb3IgYSBDUFUgdG8gdGhlCj4gcGVyZiB2aWEgdGhpcyBIV0lEIHBhY2tldC4KPiAKPiBJZiB5 b3UgYXJlIGhhcHB5IHdpdGggdGhlIGFib3ZlIGNoYW5nZSwgSSBjb3VsZCBwaWNrIGl0IHVwIHZp YSB0aGUKPiBjb3Jlc2lnaHQgdHJlZSB3aXRoIHlvdXIgQWNrLiBPdGhlcndpc2UsIHBsZWFzZSBj b3VsZCB5b3UgcGljayBpdAo+IHVwID8KPgoKUGxlYXNlIGNvdWxkIHlvdSBsZXQgdXMga25vdyBp ZiB0aGlzIGlzIGFjY2VwdGFibGUgYW5kIGlmIHNvLCBob3cgY2FuCnRoaXMgYmUgcHVzaGVkID8g Q29yZVNpZ2h0IFBNVSAod2hpY2ggY2FuIGJlIGJ1aWx0IGFzIGEgbW9kdWxlKSBpcyB1c2luZwp0 aGVzZSBwYWNrZXRzIHRvIGFkdmVydGlzZSB0aGUgdHJhY2VJRCBhbGxvY2F0ZWQgZm9yIGEgZ2l2 ZW4gQ1BVIGJvdW5kCkVUTSAod2hpY2ggaXMgbWFkZSBkeW5hbWljIGR1ZSB0byB0aGUgbGltaXRl ZCBudW1iZXIgb2YgaWRzIGF2YWlsYWJsZSkuClRoZSBwZXJmIHRvb2wgY2FuIHVzZSB0aGVzZSBw YWNrZXRzIHRvIHRoZW4gZGVjb2RlIGFuZCBzZXBhcmF0ZSB0aGUKdHJhY2UgZGF0YSBmcm9tIHNo YXJlZCBidWZmZXIuCgpBcyBvZiBub3csIHRoZSBzZXJpZXMgdG8gZW5hYmxlIHRoZSBkeW5hbWlj IHRyYWNlIGlkIGFsbG9jYXRpb24gaXMKYmxvY2tlZCBvbiB0aGlzIGNoYW5nZS4KCgpLaW5kIHJl Z2FyZHMKU3V6dWtpCgo+IFN1enVraQo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK