All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: powerpc/highmem: change BUG_ON() to WARN_ON()
Date: Mon, 22 Apr 2019 00:18:42 +1000 (AEST)	[thread overview]
Message-ID: <44nBdt1tHHz9s8m@ozlabs.org> (raw)
In-Reply-To: <0365f99ce2b9273e269a241394957cba924f995e.1551951985.git.christophe.leroy@c-s.fr>

On Thu, 2019-03-07 at 09:47:50 UTC, Christophe Leroy wrote:
> In arch/powerpc/mm/highmem.c, BUG_ON() is called only when
> CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is
> not vital and can be replaced by a a WARN_ON
> 
> At the sametime, use IS_ENABLED() instead of #ifdef to clean a bit.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/6c84f8c5cbfb4bf728f88296bc035c4a

cheers

      parent reply	other threads:[~2019-04-21 14:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07  9:47 [PATCH] powerpc/highmem: change BUG_ON() to WARN_ON() Christophe Leroy
2019-03-07  9:47 ` Christophe Leroy
2019-03-21  5:29 ` Michael Ellerman
2019-03-21  5:29   ` Michael Ellerman
2019-03-21  6:00   ` Christophe Leroy
2019-03-21  6:00     ` Christophe Leroy
2019-03-21 10:07     ` Michael Ellerman
2019-03-21 10:07       ` Michael Ellerman
2019-03-21 10:14       ` Christophe Leroy
2019-03-21 10:14         ` Christophe Leroy
2019-04-21 14:18 ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44nBdt1tHHz9s8m@ozlabs.org \
    --to=patch-notifications@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.