From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm: Don't build brcmstb SMP code when building for V6
Date: Tue, 26 Aug 2014 12:54:03 +0200 [thread overview]
Message-ID: <45082124.LP9dKIUraq@wuerfel> (raw)
In-Reply-To: <20140825172713.GW18411@ld-irv-0074>
On Monday 25 August 2014 10:27:13 Brian Norris wrote:
> On Fri, Aug 22, 2014 at 09:44:03AM -0500, Mark Brown wrote:
> > On Thu, Aug 21, 2014 at 10:09:07PM -0700, Brian Norris wrote:
> > > On Thu, Aug 21, 2014 at 09:06:34PM -0500, Mark Brown wrote:
> > > > From: Mark Brown <broonie@linaro.org>
> >
> > > > building for -march=armv6 as happens when building allmodconfig. Since I
> > > > have not been able to identify a way to override the compiler architecture
> > > > selection per file add a Kconfig dependency to ensure this code is not
> > > > built if V6 support is enabled.
> >
> > > I already proposed this solution to override the compiler architecture,
> > > in the same pattern as other similar code in the same directory.
> >
> > > http://article.gmane.org/gmane.linux.drivers.devicetree/84517
> >
> > > My using 'CFLAGS_<obj> += <flags>', you can compile in v7.
> >
> > I tried that but it wasn't doing the right thing for me - it appeared
> > since the compiler ends up getting both -march=armv7-a and -march=armv6
> > it complained that it couldn't satisfy both options. It might be that
> > this is version dependant or the actual cause wsa something else, I
> > didn't investigate too hard.
I've never seen that happen. Normally, the last option just overrides
all previous conflicting ones.
> If you ever see revisit this or see this again, I'd be interested in
> seeing the gcc args (make V=1) and version that failed. My fix worked
> for me, and I'll likely use it for the next revision if I don't find a
> good reason not to.
FWIW, I haven't seen any problems with the version below:
diff --git a/arch/arm/mach-bcm/Makefile b/arch/arm/mach-bcm/Makefile
index 67c492aabf4d..546d3d3022a4 100644
--- a/arch/arm/mach-bcm/Makefile
+++ b/arch/arm/mach-bcm/Makefile
@@ -38,3 +38,5 @@ ifeq ($(CONFIG_ARCH_BRCMSTB),y)
obj-y += brcmstb.o
obj-$(CONFIG_SMP) += headsmp-brcmstb.o platsmp-brcmstb.o
endif
+
+CFLAGS_platsmp-brcmstb.o += -march=armv7-a
Arnd
prev parent reply other threads:[~2014-08-26 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 2:06 [PATCH] ARM: bcm: Don't build brcmstb SMP code when building for V6 Mark Brown
2014-08-22 5:09 ` Brian Norris
2014-08-22 14:44 ` Mark Brown
2014-08-25 17:27 ` Brian Norris
2014-08-26 10:54 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45082124.LP9dKIUraq@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.