All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	Luca Boccassi <bluca@debian.org>, dev <dev@dpdk.org>,
	Kevin Laatz <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: avoid --as-needed as it causes overlinking
Date: Sat, 12 Oct 2019 15:02:59 +0200	[thread overview]
Message-ID: <4508605.XBsqFPkRIG@xps> (raw)
In-Reply-To: <CAATJJ0JSCKu3xa_eBvymc2y6Py6aQgCnphB-vQaXZOWbQEtMyg@mail.gmail.com>

12/09/2019 15:43, Christian Ehrhardt:
> > On Wed, Sep 4, 2019 at 11:18 AM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > > > On Mon, Sep 2, 2019 at 9:09 AM Christian Ehrhardt
> > > > <christian.ehrhardt@canonical.com> wrote:
> > > > > > On Thu, 2019-08-29 at 16:34 +0100, Bruce Richardson wrote:
> > > > > > > On Thu, Aug 29, 2019 at 05:30:03PM +0200, Christian Ehrhardt wrote:
> > > > > > > > --- a/config/meson.build
> > > > > > > > +++ b/config/meson.build
> > > > > > > >  add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
> > > > > > > > -dpdk_extra_ldflags += '-Wl,--no-as-needed'
> > > > > > > >
> > > > > > >
> > > > > > > This seems strange to me. What is it about linking the dpdk apps that
> > > > > > > require the argument, but makes it safe for non-builtin apps to avoid
> > > > > > > having the arg?
[...]
> > > > > Having it accepted in upstream would make it more easy to fix this in
> > > > > the soon to be released Ubuntu 19.10.
> > > > > Is there a path to consider taking this fix as-is and continue the
> > > > > debug/discussion how the removal of the second line can even cause the
> > > > > symptoms that we have seen later?
> > >
> > > I'm ok with what you propose above.
[...]
> And actually 18.11 stable would make sense as well IMHO.
> Could one who commits could add that as:
> Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson")

+Cc stable@dpdk.org in the commit log

Applied, thanks
Title reduced to "avoid overlinking" because --as-needed mention looks wrong.

Please continue the investigation to remove
the other line "add_project_link_arguments()".



      reply	other threads:[~2019-10-12 18:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 12:27 [dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking Christian Ehrhardt
2019-08-28 13:49 ` Luca Boccassi
2019-08-28 13:53 ` Aaron Conole
2019-08-28 14:48   ` Christian Ehrhardt
2019-08-28 15:14     ` Aaron Conole
2019-08-28 15:23       ` Aaron Conole
2019-08-29 10:18         ` Christian Ehrhardt
2019-08-29 15:25           ` Christian Ehrhardt
2019-08-29 15:30             ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2019-08-29 15:34               ` Bruce Richardson
2019-08-29 16:02                 ` Luca Boccassi
2019-09-02  7:09                   ` Christian Ehrhardt
2019-09-04  9:13                     ` Christian Ehrhardt
2019-09-04  9:18                       ` Bruce Richardson
2019-09-10  6:48                         ` Christian Ehrhardt
2019-09-12 13:43                           ` Christian Ehrhardt
2019-10-12 13:02                             ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4508605.XBsqFPkRIG@xps \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.