From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Colin King <colin.king@canonical.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: socfpga: arria10: Fix memory leak of socfpga_clk on error return
Date: Wed, 7 Apr 2021 10:59:42 +0200 [thread overview]
Message-ID: <450a3b07-044d-602d-f1a0-f0748bbc5bc5@canonical.com> (raw)
In-Reply-To: <20210406170115.430990-1-colin.king@canonical.com>
On 06/04/2021 19:01, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an error return path that is not kfree'ing socfpga_clk leading
> to a memory leak. Fix this by adding in the missing kfree call.
>
> Addresses-Coverity: ("Resource leak")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/clk/socfpga/clk-gate-a10.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-04-07 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 17:01 [PATCH] clk: socfpga: arria10: Fix memory leak of socfpga_clk on error return Colin King
2021-04-06 18:13 ` Dinh Nguyen
2021-04-07 8:59 ` Krzysztof Kozlowski [this message]
2021-04-07 23:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450a3b07-044d-602d-f1a0-f0748bbc5bc5@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=colin.king@canonical.com \
--cc=dinguyen@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.