From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF67C43217 for ; Fri, 7 Oct 2022 19:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiJGTiu (ORCPT ); Fri, 7 Oct 2022 15:38:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbiJGTib (ORCPT ); Fri, 7 Oct 2022 15:38:31 -0400 Received: from relay03.th.seeweb.it (relay03.th.seeweb.it [5.144.164.164]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67BBA104503 for ; Fri, 7 Oct 2022 12:38:29 -0700 (PDT) Received: from [192.168.1.101] (95.49.30.201.neoplus.adsl.tpnet.pl [95.49.30.201]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 0381B2009D; Fri, 7 Oct 2022 21:38:26 +0200 (CEST) Message-ID: <450d2490-2640-6a4a-946f-e401ba68d52c@somainline.org> Date: Fri, 7 Oct 2022 21:38:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 3/6] arm: dts: qcom: mdm9615: wp8548-mangoh-green: fix sx150xq node names and probe-reset property Content-Language: en-US To: Neil Armstrong , Andy Gross , Lee Jones , Bjorn Andersson , Linus Walleij , Mark Brown , Krzysztof Kozlowski , Rob Herring , Liam Girdwood Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20221005-mdm9615-pinctrl-yaml-v1-0-0cbc006e2a30@linaro.org> <20221005-mdm9615-pinctrl-yaml-v1-3-0cbc006e2a30@linaro.org> From: Konrad Dybcio In-Reply-To: <20221005-mdm9615-pinctrl-yaml-v1-3-0cbc006e2a30@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 6.10.2022 11:58, Neil Armstrong wrote: > Fix the sx150xq node names to pinctrl and use the right probe-reset property. > > Signed-off-by: Neil Armstrong > --- Could you please also fix up the property order (may be in a separate patchset ofc)? Reviewed-by: Konrad Dybcio Konrad > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > index 30a110984597..a8304769b509 100644 > --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > @@ -116,7 +116,7 @@ i2c@4 { > #size-cells = <0>; > reg = <4>; > > - gpioext0: gpio@3e { > + gpioext0: pinctrl@3e { > /* GPIO Expander 0 Mapping : > * - 0: ARDUINO_RESET_Level shift > * - 1: BattChrgr_PG_N > @@ -142,7 +142,7 @@ gpioext0: gpio@3e { > interrupt-parent = <&gpioext1>; > interrupts = <0 IRQ_TYPE_EDGE_FALLING>; > > - probe-reset; > + semtech,probe-reset; > > gpio-controller; > interrupt-controller; > @@ -154,7 +154,7 @@ i2c@5 { > #size-cells = <0>; > reg = <5>; > > - gpioext1: gpio@3f { > + gpioext1: pinctrl@3f { > /* GPIO Expander 1 Mapping : > * - 0: GPIOEXP_INT1 > * - 1: Battery detect > @@ -183,7 +183,7 @@ gpioext1: gpio@3f { > interrupt-parent = <&msmgpio>; > interrupts = <0 IRQ_TYPE_EDGE_FALLING>; > > - probe-reset; > + semtech,probe-reset; > > gpio-controller; > interrupt-controller; > @@ -195,7 +195,7 @@ i2c@6 { > #size-cells = <0>; > reg = <6>; > > - gpioext2: gpio@70 { > + gpioext2: pinctrl@70 { > /* GPIO Expander 2 Mapping : > * - 0: USB_HUB_INTn > * - 1: HUB_CONNECT > @@ -221,7 +221,7 @@ gpioext2: gpio@70 { > interrupt-parent = <&gpioext1>; > interrupts = <14 IRQ_TYPE_EDGE_FALLING>; > > - probe-reset; > + semtech,probe-reset; > > gpio-controller; > interrupt-controller; >