From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B526C433FF for ; Tue, 30 Jul 2019 10:10:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4071920679 for ; Tue, 30 Jul 2019 10:10:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4071920679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsP5p-0007gx-Hr for qemu-devel@archiver.kernel.org; Tue, 30 Jul 2019 06:10:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39514) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsP4Z-0006YZ-Jo for qemu-devel@nongnu.org; Tue, 30 Jul 2019 06:09:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsP4Y-0003RH-GV for qemu-devel@nongnu.org; Tue, 30 Jul 2019 06:09:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42552) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsP4W-0003On-2e; Tue, 30 Jul 2019 06:09:32 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60BE730655F5; Tue, 30 Jul 2019 10:09:31 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-116-164.ams2.redhat.com [10.36.116.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D0E55D6A7; Tue, 30 Jul 2019 10:09:30 +0000 (UTC) To: Kevin Wolf , qemu-block@nongnu.org References: <20190729164234.11573-1-kwolf@redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <45203855-a078-e084-3ce9-d827cc99bff7@redhat.com> Date: Tue, 30 Jul 2019 12:09:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190729164234.11573-1-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="17dfXGHD1rTTfZSPstn4v7xTNuCwT7iQb" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 30 Jul 2019 10:09:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH for-4.1] scsi-cd: Fix inserting read-only media in empty drive X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --17dfXGHD1rTTfZSPstn4v7xTNuCwT7iQb Content-Type: multipart/mixed; boundary="gaNsQ5LlNZPBFy4P6lQAoL0wyXErcq1x6"; protected-headers="v1" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: eblake@redhat.com, qemu-devel@nongnu.org Message-ID: <45203855-a078-e084-3ce9-d827cc99bff7@redhat.com> Subject: Re: [PATCH for-4.1] scsi-cd: Fix inserting read-only media in empty drive References: <20190729164234.11573-1-kwolf@redhat.com> In-Reply-To: <20190729164234.11573-1-kwolf@redhat.com> --gaNsQ5LlNZPBFy4P6lQAoL0wyXErcq1x6 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 29.07.19 18:42, Kevin Wolf wrote: > scsi-disks decides whether it has a read-only device by looking at > whether the BlockBackend specified as drive=3D... is read-only. In the > case of an anonymous BlockBackend (with a node name specified in > drive=3D...), this is the read-only flag of the attached node. In the c= ase > of an empty anonymous BlockBackend, it's always read-write because > nothing prevented it from being read-write. >=20 > This is a problem because scsi-cd would take write permissions on the > anonymous BlockBackend of an empty drive created without a drive=3D... > option. Using blockdev-insert-medium with a read-only node fails then > with the error message "Block node is read-only". >=20 > Fix scsi_realize() so that scsi-cd devices always take read-only > permissions on their BlockBackend instead. >=20 > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1733920 > Signed-off-by: Kevin Wolf > --- > hw/scsi/scsi-disk.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz --gaNsQ5LlNZPBFy4P6lQAoL0wyXErcq1x6-- --17dfXGHD1rTTfZSPstn4v7xTNuCwT7iQb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl1AF1gACgkQ9AfbAGHV z0BmYwf8Db7Tnra/JDTkpPRtjRMP1g/BI8uSu3XZx6aGZCsITB849jhGhV2YErL8 KopGrTXukeyh4JKQiinAUmu5DQfGfNYPhKE4n/INXxYfToiXE4nBjNVSg8UjyLXz JZHMNiDGnaFOuowtlNx0BuWqiuVUOHsj7+Yl+7/ypZrkIcU8kgIvMcaSWAUuopWu NhLaq0BgeiUnq2AK49HfiH+RX2Mkur9AbC7YQ4zaUMeV3goXkWXaLEv6S0gsvbA6 qfjGVIISeVtEA8tzN0EkVe7piemmi9XMOVET4Z68GeVhZPCPr15iZU3ivN6ygdCm tHQhlGbhB06MxN1un+ZBowQ3U8okLA== =+f7t -----END PGP SIGNATURE----- --17dfXGHD1rTTfZSPstn4v7xTNuCwT7iQb--