From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53261C4743D for ; Sat, 5 Jun 2021 00:11:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 317BD613EA for ; Sat, 5 Jun 2021 00:11:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230344AbhFEANW (ORCPT ); Fri, 4 Jun 2021 20:13:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:38078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229847AbhFEANV (ORCPT ); Fri, 4 Jun 2021 20:13:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4FCCA61287; Sat, 5 Jun 2021 00:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622851894; bh=f5TsQHdvVfNDUeQro5QfvN7k2bDUHRhBhKEqsKjrefc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=N5Npf//n/FGbPXFQeTJRQBLb2VOXTp3u4QqYsU2zd1oQEtdlyhGlTnSDYOeMPzgqB 557EwpHqhN/WVxg0ZrnR0aCYC4ODiaRgUVuMyRSIN91w/mLOoJTEazArDNljj+8nAS zEiCKqULjAqBZvaySvonDjeAAW1KoH7XwI0dpPsGpTGPzS/+xfoqq0AFb5L049F2Y3 jZsUIXaUTsz6bzzQ03Ll2bRQjPzuCxYnLobq3DKsLfkJNy8cao6Atb8iKu+LCHRkzx JTX/VZRN9a+cnDA0Ag36Ycug7o2cfW3U62S4biUOCeGGRQ3X8SVZ9lxE0ZODY5hsuV A8uyOy45reSpg== Subject: Re: [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs To: Jaegeuk Kim , Eric Biggers Cc: Daniel Rosenberg , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com, stable@vger.kernel.org References: <20210603095038.314949-1-drosen@google.com> <20210603095038.314949-3-drosen@google.com> From: Chao Yu Message-ID: <452273b4-b386-3180-9b6e-f060bdbe3802@kernel.org> Date: Sat, 5 Jun 2021 08:11:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/4 13:38, Jaegeuk Kim wrote: > On 06/03, Eric Biggers wrote: >> On Thu, Jun 03, 2021 at 09:45:25PM -0700, Jaegeuk Kim wrote: >>> On 06/03, Eric Biggers wrote: >>>> On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: >>>>> Older kernels don't support encryption with casefolding. This adds >>>>> the sysfs entry encrypted_casefold to show support for those combined >>>>> features. Support for this feature was originally added by >>>>> commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") >>>>> >>>>> Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") >>>>> Cc: stable@vger.kernel.org # v5.11+ >>>>> Signed-off-by: Daniel Rosenberg >>>>> --- >>>>> fs/f2fs/sysfs.c | 15 +++++++++++++-- >>>>> 1 file changed, 13 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c >>>>> index 09e3f258eb52..6604291a3cdf 100644 >>>>> --- a/fs/f2fs/sysfs.c >>>>> +++ b/fs/f2fs/sysfs.c >>>>> @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, >>>>> if (f2fs_sb_has_compression(sbi)) >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> len ? ", " : "", "compression"); >>>>> + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) >>>>> + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> + len ? ", " : "", "encrypted_casefold"); >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> len ? ", " : "", "pin_file"); >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); >>>>> @@ -579,6 +582,7 @@ enum feat_id { >>>>> FEAT_CASEFOLD, >>>>> FEAT_COMPRESSION, >>>>> FEAT_TEST_DUMMY_ENCRYPTION_V2, >>>>> + FEAT_ENCRYPTED_CASEFOLD, >>>>> }; >>>> >>>> Actually looking at it more closely, this patch is wrong. >>>> >>>> It only makes sense to declare "encrypted_casefold" as a feature of the >>>> filesystem implementation, i.e. /sys/fs/f2fs/features/encrypted_casefold. >>>> >>>> It does *not* make sense to declare it as a feature of a particular filesystem >>>> instance, i.e. /sys/fs/f2fs/$disk/features, as it is already implied by the >>>> filesystem instance having both the encryption and casefold features enabled. >>>> >>>> Can we add /sys/fs/f2fs/features/encrypted_casefold only? >>> >>> wait.. /sys/fs/f2fs/features/encrypted_casefold is on by >>> CONFIG_FS_ENCRYPTION && CONFIG_UNICODE. >>> OTOH, /sys/fs/f2fs/$dis/feature_list/encrypted_casefold is on by >>> on-disk features: F2FS_FEATURE_ENCRYPT and F2FS_FEATURE_CASEFOLD. >>> >> >> Yes, but in the on-disk case, encrypted_casefold is redundant because it simply >> means encrypt && casefold. There is no encrypted_casefold flag on-disk. > > I prefer to keep encrypted_casefold likewise kernel feature, which is more > intuitive to users. encrypted_casefold is a kernel feature support flag, not a disk one, IMO, it's not needed to add it in to per-disk feature list, it may mislead user that compatible encrypted casefold needs a extra disk layout support while disk has already encrypted and casefold feature enabled. Thanks, > >> >> - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A368C4743C for ; Sat, 5 Jun 2021 00:11:50 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D11C161287; Sat, 5 Jun 2021 00:11:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D11C161287 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lpJul-0001yv-BQ; Sat, 05 Jun 2021 00:11:47 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lpJuk-0001yX-7J for linux-f2fs-devel@lists.sourceforge.net; Sat, 05 Jun 2021 00:11:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QSl08I+3agLNbXz9bOlp3PJiS2V/6qVtdHPCSdU7cR4=; b=hyCGhSivjsUkv5rHcsJu1TtuVk 8jzSkp1iJLYUPmHCgexFBlala3y3kUmUufmsBSqYtysUmKLBUewJfBKmV7p22vZ7cb7gwdphCvFpy M5Hbrxozk+y7Hrn+Oj6AqgO1ZASyTXLOfanf7KiHJ1TpLpn7TJ/fr6KQe/0BVMVoLyOg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QSl08I+3agLNbXz9bOlp3PJiS2V/6qVtdHPCSdU7cR4=; b=QgpzoJR/qK4S2SJEi/MJMCkjQD PHKzY1U44iCw4Jgwzfz6+RhJrjb1z2g13vIZmRLjhhXS+YwUKzAJNsJZdcUBF+CDbTZS8l2qaOKE2 Bbz0L5TPp5Txh54zawJIADXtNGNVa6ggM2qQ/Gz/7U6pfurPIMArFyQPgZu271Oiq3OI=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lpJud-00B0BI-Km for linux-f2fs-devel@lists.sourceforge.net; Sat, 05 Jun 2021 00:11:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4FCCA61287; Sat, 5 Jun 2021 00:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622851894; bh=f5TsQHdvVfNDUeQro5QfvN7k2bDUHRhBhKEqsKjrefc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=N5Npf//n/FGbPXFQeTJRQBLb2VOXTp3u4QqYsU2zd1oQEtdlyhGlTnSDYOeMPzgqB 557EwpHqhN/WVxg0ZrnR0aCYC4ODiaRgUVuMyRSIN91w/mLOoJTEazArDNljj+8nAS zEiCKqULjAqBZvaySvonDjeAAW1KoH7XwI0dpPsGpTGPzS/+xfoqq0AFb5L049F2Y3 jZsUIXaUTsz6bzzQ03Ll2bRQjPzuCxYnLobq3DKsLfkJNy8cao6Atb8iKu+LCHRkzx JTX/VZRN9a+cnDA0Ag36Ycug7o2cfW3U62S4biUOCeGGRQ3X8SVZ9lxE0ZODY5hsuV A8uyOy45reSpg== To: Jaegeuk Kim , Eric Biggers References: <20210603095038.314949-1-drosen@google.com> <20210603095038.314949-3-drosen@google.com> From: Chao Yu Message-ID: <452273b4-b386-3180-9b6e-f060bdbe3802@kernel.org> Date: Sat, 5 Jun 2021 08:11:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Headers-End: 1lpJud-00B0BI-Km Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Rosenberg , Gabriel Krisman Bertazi , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, kernel-team@android.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/6/4 13:38, Jaegeuk Kim wrote: > On 06/03, Eric Biggers wrote: >> On Thu, Jun 03, 2021 at 09:45:25PM -0700, Jaegeuk Kim wrote: >>> On 06/03, Eric Biggers wrote: >>>> On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: >>>>> Older kernels don't support encryption with casefolding. This adds >>>>> the sysfs entry encrypted_casefold to show support for those combined >>>>> features. Support for this feature was originally added by >>>>> commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") >>>>> >>>>> Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") >>>>> Cc: stable@vger.kernel.org # v5.11+ >>>>> Signed-off-by: Daniel Rosenberg >>>>> --- >>>>> fs/f2fs/sysfs.c | 15 +++++++++++++-- >>>>> 1 file changed, 13 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c >>>>> index 09e3f258eb52..6604291a3cdf 100644 >>>>> --- a/fs/f2fs/sysfs.c >>>>> +++ b/fs/f2fs/sysfs.c >>>>> @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, >>>>> if (f2fs_sb_has_compression(sbi)) >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> len ? ", " : "", "compression"); >>>>> + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) >>>>> + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> + len ? ", " : "", "encrypted_casefold"); >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> len ? ", " : "", "pin_file"); >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); >>>>> @@ -579,6 +582,7 @@ enum feat_id { >>>>> FEAT_CASEFOLD, >>>>> FEAT_COMPRESSION, >>>>> FEAT_TEST_DUMMY_ENCRYPTION_V2, >>>>> + FEAT_ENCRYPTED_CASEFOLD, >>>>> }; >>>> >>>> Actually looking at it more closely, this patch is wrong. >>>> >>>> It only makes sense to declare "encrypted_casefold" as a feature of the >>>> filesystem implementation, i.e. /sys/fs/f2fs/features/encrypted_casefold. >>>> >>>> It does *not* make sense to declare it as a feature of a particular filesystem >>>> instance, i.e. /sys/fs/f2fs/$disk/features, as it is already implied by the >>>> filesystem instance having both the encryption and casefold features enabled. >>>> >>>> Can we add /sys/fs/f2fs/features/encrypted_casefold only? >>> >>> wait.. /sys/fs/f2fs/features/encrypted_casefold is on by >>> CONFIG_FS_ENCRYPTION && CONFIG_UNICODE. >>> OTOH, /sys/fs/f2fs/$dis/feature_list/encrypted_casefold is on by >>> on-disk features: F2FS_FEATURE_ENCRYPT and F2FS_FEATURE_CASEFOLD. >>> >> >> Yes, but in the on-disk case, encrypted_casefold is redundant because it simply >> means encrypt && casefold. There is no encrypted_casefold flag on-disk. > > I prefer to keep encrypted_casefold likewise kernel feature, which is more > intuitive to users. encrypted_casefold is a kernel feature support flag, not a disk one, IMO, it's not needed to add it in to per-disk feature list, it may mislead user that compatible encrypted casefold needs a extra disk layout support while disk has already encrypted and casefold feature enabled. Thanks, > >> >> - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel