From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F3FBC433E6 for ; Fri, 12 Mar 2021 10:59:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70F7864F23 for ; Fri, 12 Mar 2021 10:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233663AbhCLK6h (ORCPT ); Fri, 12 Mar 2021 05:58:37 -0500 Received: from foss.arm.com ([217.140.110.172]:51610 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233939AbhCLK6W (ORCPT ); Fri, 12 Mar 2021 05:58:22 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D072DED1; Fri, 12 Mar 2021 02:58:21 -0800 (PST) Received: from [10.57.17.106] (unknown [10.57.17.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F00BE3F793; Fri, 12 Mar 2021 02:58:19 -0800 (PST) Subject: Re: [PATCH 1/3] thermal/drivers/cpufreq_cooling: Use device name instead of auto-numbering To: Daniel Lezcano Cc: rui.zhang@intel.com, amitk@kernel.org, linux-pm@vger.kernel.org, Amit Daniel Kachhap , Viresh Kumar , Javi Merino , open list References: <20210310114600.27178-1-daniel.lezcano@linaro.org> From: Lukasz Luba Message-ID: <452c1619-fcda-d006-721a-d471389aa90a@arm.com> Date: Fri, 12 Mar 2021 10:58:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210310114600.27178-1-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Only minor comments. On 3/10/21 11:45 AM, Daniel Lezcano wrote: > Currently the naming of a cooling device is just a cooling technique > followed by a number. When there are multiple cooling devices using > the same technique, it is impossible to clearly identify the related > device as this one is just a number. > > For instance: > > thermal-cpufreq-0 > thermal-cpufreq-1 > etc ... > > The 'thermal' prefix is redundant with the subsystem namespace. This > patch removes the 'thermal prefix and changes the number by the device missing ', after 'thermal > name. So the naming above becomes: > > cpufreq-cpu0 > cpufreq-cpu4 > etc ... > > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/cpufreq_cooling.c | 28 +++++++--------------------- > 1 file changed, 7 insertions(+), 21 deletions(-) > > diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c > index 10af3341e5ea..cf0332bbdcd3 100644 > --- a/drivers/thermal/cpufreq_cooling.c > +++ b/drivers/thermal/cpufreq_cooling.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include You can now also remove the header: #include other than that, LGTM Reviewed-by: Lukasz Luba