From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelnx194.ext.ti.com ([198.47.27.80]:50986 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbeCTJRR (ORCPT ); Tue, 20 Mar 2018 05:17:17 -0400 Subject: Re: [PATCH 0/3] Fix build on multi_v7_defconfig To: Sam Protsenko , Greg Kroah-Hartman CC: , Praneeth Bajjuri , Sekhar Nori , Roger Quadros , Milosz Wasilewski , Dan Rue References: <20180320080027.8948-1-semen.protsenko@linaro.org> <20180320081013.GA12444@kroah.com> From: Tero Kristo Message-ID: <452ee8f2-7b3c-be83-ba5d-f776bb73fcc3@ti.com> Date: Tue, 20 Mar 2018 11:16:54 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 20/03/18 10:20, Sam Protsenko wrote: > On 20 March 2018 at 16:10, Greg Kroah-Hartman > wrote: >> On Tue, Mar 20, 2018 at 04:00:24PM +0800, Sam Protsenko wrote: >>> Recent patches broke build on multi_v7_defconfig (ARM), on >>> stable-rc/linux-4.4.y branch. The build error as follows: >>> >>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c:2243:12: error: >>> 'HWMOD_CLKDM_NOAUTO' undeclared here (not in a function) >>> .flags = HWMOD_CLKDM_NOAUTO, >>> ^~~~~~~~~~~~~~~~~~ >> >> I just dropped this patch instead, as is it really worth adding these >> other patches to resolve this? >> > > Agree. Those patches are the actual dependency for one that breaks the > build, but it's kinda an overkill to pull that amount of code. If we > really need that patch, somebody (maintainers?) should revise it and > come up with a better solution, providing all needed dependency > patches and predicting the impact of all series on the system, as this > is a stable branch. Yea I don't see why this patch would be so critical to get it fixed in stable. If a need rises, we (as in TI) can work on that. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki