From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E275DC04AB5 for ; Tue, 4 Jun 2019 01:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B008B243D6 for ; Tue, 4 Jun 2019 01:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ScNfLN/T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbfFDBgK (ORCPT ); Mon, 3 Jun 2019 21:36:10 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42935 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfFDBgK (ORCPT ); Mon, 3 Jun 2019 21:36:10 -0400 Received: by mail-pg1-f195.google.com with SMTP id e6so8062777pgd.9 for ; Mon, 03 Jun 2019 18:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=L7M6oK1UHfGNRfGQaNApU8MBbkUXRm73r6MP5oAKCOY=; b=ScNfLN/TLf9uipgwF6lxLxK5e9vwT8wB9hrbvbwVt/gW08O3P6CHlye/86kHycK6+g DmMrHKBcBYeHWNbequR2aWoVqitFNmT9kYC6UbT1fSJ7LPsNzhdxaWyhC46cInRCGSMs L6OqQbudAiZA7pE11wJaInzymil8FfZiJ1N6e7ZL9hMthEf2n3lgxs+T+UiF1bwbD7Ff /HY+cnl1bDQWmH39NYc+IGU8IlttBGTmkyaWq+KEjWCfbcThIBZl5FsdYT3ncX8Zpinh D/kYg2zoJaFcOe+v+OkwSfLVxc9h+O4WaqOOisidcsx3tI/FkH3kVnfTNX9muzeiegsv DBPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L7M6oK1UHfGNRfGQaNApU8MBbkUXRm73r6MP5oAKCOY=; b=mnBrmEBTINaozXtN/mV08lUmBjLYdhq+tDJ4MlcznJF7tjgmg5mHUXDNkkU8CowtMp 0cK5pbt+JeMY2VmqVYwsUh8xjGTlrl1qFAjbMOzz9jxO31qW3Qne/QictTYy3waRBtpf FUmeD3qcmVruhj6+V4RpKRyApe5oJA1FmgWV7DK/+Jh9Lptr4jqcuJdpWEQ9oAeOO+A+ FlO/mImKR/BYizGbzyEw1qfJtIDGOT71p+T1IeAJ8SmvYLDroq9fC6f6dn0JiqgoNnuk LcifirUNXGaH8gcU/pU9+JUBRu07rmpr3j7OapYzAhP3LrDwAFHEX26jvdWgPSguv8x1 nxPg== X-Gm-Message-State: APjAAAWvj8M6bZKc+oUUUX6tCsV5gNMei7i0LPm62K0mdxH/n5RlyK8N bxEP2oqDkZwCkjmeIpqfA74= X-Google-Smtp-Source: APXvYqy9rQsoUUVwg02qtX2qLtKgnOPUMo8azuYP4oeBTqLsKoO9Hini8qLYOziabz/s0LTfeO88mQ== X-Received: by 2002:a62:4d03:: with SMTP id a3mr35854852pfb.2.1559612169651; Mon, 03 Jun 2019 18:36:09 -0700 (PDT) Received: from [172.27.227.197] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id a64sm12812003pgc.53.2019.06.03.18.36.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 18:36:08 -0700 (PDT) Subject: Re: [PATCH v2 net-next 4/7] ipv6: Plumb support for nexthop object in a fib6_info To: Martin Lau Cc: Wei Wang , David Ahern , "David S . Miller" , Linux Kernel Network Developers , "idosch@mellanox.com" , "saeedm@mellanox.com" References: <20190603040817.4825-1-dsahern@kernel.org> <20190603040817.4825-5-dsahern@kernel.org> <5263d3ae-1865-d935-cb03-f6dfd4604d15@gmail.com> <4cdcdf65-4d34-603e-cb21-d649b399d760@gmail.com> <20190604005840.tiful44xo34lpf6d@kafai-mbp.dhcp.thefacebook.com> From: David Ahern Message-ID: <453565b0-d08a-be96-3cd7-5608d4c21541@gmail.com> Date: Mon, 3 Jun 2019 19:36:06 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190604005840.tiful44xo34lpf6d@kafai-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/3/19 6:58 PM, Martin Lau wrote: > I have concern on calling ip6_create_rt_rcu() in general which seems > to trace back to this commit > dec9b0e295f6 ("net/ipv6: Add rt6_info create function for ip6_pol_route_lookup") > > This rt is not tracked in pcpu_rt, rt6_uncached_list or exception bucket. > In particular, how to react to NETDEV_UNREGISTER/DOWN like > the rt6_uncached_list_flush_dev() does and calls dev_put()? > > The existing callers seem to do dst_release() immediately without > caching it, but still concerning. those are the callers that don't care about the dst_entry, but are forced to deal with it. Removing the tie between fib lookups an dst_entry is again the right solution.